[{"id":33344,"web_url":"https://patchwork.libcamera.org/comment/33344/","msgid":"<173946599709.1238111.707647433269339354@ping.linuxembedded.co.uk>","date":"2025-02-13T16:59:57","subject":"Re: [PATCH] ipa: rkisp1: algorithms: agc: Fix whitespace","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-02-13 16:38:50)\n> Drop trailing whitespace introduced by mistake.\n> \n> Fixes: 0e0e32b1890c (\"ipa: rkisp1: algorithms: agc: Check for correct stats type\")\n> Signed-off-by: Laurent Pinchart \n\nNo point leaving this one hanging around:\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 45ec72188b3a..9a558a1ce29a 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -466,7 +466,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> fillMetadata(context, frameContext, metadata);\n> return;\n> }\n> - \n> +\n> if (!(stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP)) {\n> fillMetadata(context, frameContext, metadata);\n> LOG(RkISP1Agc, Error) << \"AUTOEXP data is missing in statistics\";\n> \n> base-commit: 2e8b6fd2178e199049c47b5f8f929f3d53f95362\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 096C4C3272\n\tfor ;\n\tThu, 13 Feb 2025 17:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12AD068638;\n\tThu, 13 Feb 2025 18:00:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 434916185F\n\tfor ;\n\tThu, 13 Feb 2025 18:00:00 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F9D8594;\n\tThu, 13 Feb 2025 17:58:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pPhGE3Rb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739465921;\n\tbh=GoBFN6eASn+nB6OoZJcBCXNlqjK9cBQxkmiY1jdcX3w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=pPhGE3RbKMmbyjH3TUV9thlGvUALOrObj3iA9a/aQ9ayZ7Kbmd1GMrWUYGRvDb19V\n\toLgMtybJ2+HZXu+lvm2b02Qw3PRl4Im2Hb9zjUUfL2x5akrmV5WAxKzqe68ibh7QYH\n\tWiRiJKsV6Qv5RuffAT7y2Pgx/tDi0sjr7khXSCwM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250213163850.25254-1-laurent.pinchart@ideasonboard.com>","References":"<20250213163850.25254-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: algorithms: agc: Fix whitespace","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Feb 2025 16:59:57 +0000","Message-ID":"<173946599709.1238111.707647433269339354@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33347,"web_url":"https://patchwork.libcamera.org/comment/33347/","msgid":"<6l53bo65vtadevebt45fvdpexoezwu4mxmbykayjugzwysdoqm@ifbq4m6uibl4>","date":"2025-02-13T19:22:18","subject":"Re: [PATCH] ipa: rkisp1: algorithms: agc: Fix whitespace","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"On Thu, Feb 13, 2025 at 06:38:50PM +0200, Laurent Pinchart wrote:\n> Drop trailing whitespace introduced by mistake.\n> \n> Fixes: 0e0e32b1890c (\"ipa: rkisp1: algorithms: agc: Check for correct stats type\")\n\nDang, that was mine.\n\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 45ec72188b3a..9a558a1ce29a 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -466,7 +466,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> \t\tfillMetadata(context, frameContext, metadata);\n> \t\treturn;\n> \t}\n> -\t\n> +\n> \tif (!(stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP)) {\n> \t\tfillMetadata(context, frameContext, metadata);\n> \t\tLOG(RkISP1Agc, Error) << \"AUTOEXP data is missing in statistics\";\n> \n> base-commit: 2e8b6fd2178e199049c47b5f8f929f3d53f95362\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E259BD7D8\n\tfor ;\n\tThu, 13 Feb 2025 19:22:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48CF668639;\n\tThu, 13 Feb 2025 20:22:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB49B6185F\n\tfor ;\n\tThu, 13 Feb 2025 20:22:21 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:cb40:22fb:439f:306b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D03389FF;\n\tThu, 13 Feb 2025 20:21:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NiC9UpJG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739474462;\n\tbh=TtvJhmt2TGM0M+tHNm7rlNUUnnKXM+FJVNtQnI91dAg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NiC9UpJGtNSmUjQn33rjuyqq/pli+ose1Kjz6pLfRLrfFdmo6gZoSMtHWb+B8d9AI\n\ttdKDuP4KtY3NtPsB1GZB2Lw2xAk0W2Tiwi0ADzgiB7NXOTTYuh0DE9P8yFPTiFhOCR\n\tHxFfkc6hbsHS3a5Vg2NPzkZVY+Q4Unxgs1E2bxzE=","Date":"Thu, 13 Feb 2025 20:22:18 +0100","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rkisp1: algorithms: agc: Fix whitespace","Message-ID":"<6l53bo65vtadevebt45fvdpexoezwu4mxmbykayjugzwysdoqm@ifbq4m6uibl4>","References":"<20250213163850.25254-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250213163850.25254-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]