[{"id":33340,"web_url":"https://patchwork.libcamera.org/comment/33340/","msgid":"","date":"2025-02-13T09:49:51","subject":"Re: [PATCH v1] ipa: rpi: Fix incorrect cast for ExposureTime\n\tControlInfo","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for fixing this.\n\nOn Thu, 13 Feb 2025 at 08:58, Naushir Patuck wrote:\n>\n> controls::ExposureTime is of type ControlTypeInteger32, but the\n> default ControlInfoMap casts a value to int64_t causing incorrect\n> initialisation of the associated ControlInfo.\n>\n> Fix this by casting correctly to int32_t.\n>\n> Fixes: bea2db5e (\"ipa: rpi: Apply default ControlInfo values for sensor controls\")\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nDavid\n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index d5948c4a1ef4..6734c32ed1b1 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -62,7 +62,7 @@ const ControlInfoMap::Map ipaControls{\n> static_cast(controls::ExposureTimeModeManual),\n> static_cast(controls::ExposureTimeModeAuto)) },\n> { &controls::ExposureTime,\n> - ControlInfo(1, 66666, static_cast(defaultExposureTime.get())) },\n> + ControlInfo(1, 66666, static_cast(defaultExposureTime.get())) },\n> { &controls::AnalogueGainMode,\n> ControlInfo(static_cast(controls::AnalogueGainModeAuto),\n> static_cast(controls::AnalogueGainModeManual),\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69A34C3306\n\tfor ;\n\tThu, 13 Feb 2025 09:50:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13A8168634;\n\tThu, 13 Feb 2025 10:50:06 +0100 (CET)","from mail-qk1-x729.google.com (mail-qk1-x729.google.com\n\t[IPv6:2607:f8b0:4864:20::729])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85F2561862\n\tfor ;\n\tThu, 13 Feb 2025 10:50:03 +0100 (CET)","by mail-qk1-x729.google.com with SMTP id\n\taf79cd13be357-7c07441ee4eso140280985a.0\n\tfor ;\n\tThu, 13 Feb 2025 01:50:03 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"hbHWZ6Dd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1739440202; x=1740045002;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=1f4oahkVTVwik1AGkqJRvFQ8eavHj7dyWs/W0mNNSRQ=;\n\tb=hbHWZ6DdWATncf1QobDGynTuizNf9kGo0iI0Sd6j3wH1HgfSKBeNbqyud0JbAO/lOe\n\t9our7L8WTg7HAzQSxS1Ho8paHkNmr1SltYd4Q1PaF1os1CbJM1ZjKq+8sVGYM2ApIi47\n\t1vXocJEhNtpnNdlGMKOKDSgId5mWYcpdJa+eihhqOQ1qCn7UgTibtjc6KUlftCEoKk9p\n\tzoMHYpm9AbOgM0jZKXncm+9MKNq9hGGyti0+C+fy76jxlgO+LtNgybzlU5l/4IgeD0Wj\n\t3dRIuznooHxwi2zqxjyWuo7b6/VpGEkb7HxHHv7RFmji18LLKO7s0AEMmN3paN+U9kma\n\tWvbw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1739440202; x=1740045002;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=1f4oahkVTVwik1AGkqJRvFQ8eavHj7dyWs/W0mNNSRQ=;\n\tb=bcG+wHww7enGJMFV3TdSXKqgVH98oDiC0Ld0ogWtHAr9SmCDU4vjHZxN0ioYNZezvD\n\tIOXdjF4kO2GGCG53MzRd8haW5mNVzlMZ7GPn/Mdu7rZO6kfq24XI/FVjTa+IIsgH8osE\n\t7R5WMrT6HiJvkNv24tWOiRw7pkyQls7HcsKHpZjTbA046AURYD2geNyU65HzRlanM787\n\tEw0ValJueVH2CaA/rCdvBndwWBf9+eU8IqiECjfNsSwynvPZesgI9kj+as1pOYFo2+11\n\tZSDFiZ/NePHAbhXCUBQAVF+c9wQuvZ1f6jinQxWjWjCBbzRVsM+sru9aKvIoT9Z0Yxq8\n\tDz0A==","X-Gm-Message-State":"AOJu0Yx968ATX3X9SoupHCYZygjPz2sS7Hplqf7dmQ2HV0wxT6i6kwFW\n\tze3Siz4vjt4MFXX1J1zv0yTtC/qBOFFbGZBzu3rcARgkTGNcamIWLibNQxQFB83d1tfuOs4I5FR\n\tMQ7wTe1Y77uTx9zgqMMswpkVcR3nnQjgaY62u92h6KalSntWN","X-Gm-Gg":"ASbGnctzmaIicH7nCjM4Zq6vth9RFRcShMbQL50kilpJyVBY2X9Bd9Zok5gPQ3rFIyA\n\tY6tWLSdSJhVAN3b+E6SvfxQj6P+qEydaZl+KiE0CrBNERBj6poDlesr+YfiPx7FvL6vhNdr7MQg\n\trjHDP5b0aUJucjPWVRWUQ0rqJxS1bh","X-Google-Smtp-Source":"AGHT+IEJQhWhEjEgsbf9wLLd1waN9y0a+Q5lKCCF6wTZL4wuupbOobSct1wDjFtJoMdtcpiPhBJp/VVylL0KTUR3oiw=","X-Received":"by 2002:a05:620a:6841:b0:7b6:d611:ce6f with SMTP id\n\taf79cd13be357-7c07a89294cmr387441585a.8.1739440202439;\n\tThu, 13 Feb 2025 01:50:02 -0800 (PST)","MIME-Version":"1.0","References":"<20250213085825.228191-1-naush@raspberrypi.com>","In-Reply-To":"<20250213085825.228191-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Thu, 13 Feb 2025 09:49:51 +0000","X-Gm-Features":"AWEUYZmcud06kV22d_kJUxJRWmnhAHKzcNAAwze7V-L22CgIKVqGVHjSSiqmdrQ","Message-ID":"","Subject":"Re: [PATCH v1] ipa: rpi: Fix incorrect cast for ExposureTime\n\tControlInfo","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33341,"web_url":"https://patchwork.libcamera.org/comment/33341/","msgid":"<173944144821.4102114.11332369397206961861@ping.linuxembedded.co.uk>","date":"2025-02-13T10:10:48","subject":"Re: [PATCH v1] ipa: rpi: Fix incorrect cast for ExposureTime\n\tControlInfo","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-02-13 08:58:21)\n> controls::ExposureTime is of type ControlTypeInteger32, but the\n> default ControlInfoMap casts a value to int64_t causing incorrect\n> initialisation of the associated ControlInfo.\n> \n> Fix this by casting correctly to int32_t.\n> \n> Fixes: bea2db5e (\"ipa: rpi: Apply default ControlInfo values for sensor controls\")\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index d5948c4a1ef4..6734c32ed1b1 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -62,7 +62,7 @@ const ControlInfoMap::Map ipaControls{\n> static_cast(controls::ExposureTimeModeManual),\n> static_cast(controls::ExposureTimeModeAuto)) },\n> { &controls::ExposureTime,\n> - ControlInfo(1, 66666, static_cast(defaultExposureTime.get())) },\n> + ControlInfo(1, 66666, static_cast(defaultExposureTime.get())) },\n\n\nReviewed-by: Kieran Bingham \n\n> { &controls::AnalogueGainMode,\n> ControlInfo(static_cast(controls::AnalogueGainModeAuto),\n> static_cast(controls::AnalogueGainModeManual),\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54A3EBD7D8\n\tfor ;\n\tThu, 13 Feb 2025 10:10:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0392A68634;\n\tThu, 13 Feb 2025 11:10:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B58461862\n\tfor ;\n\tThu, 13 Feb 2025 11:10:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCC6F6AF;\n\tThu, 13 Feb 2025 11:09:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EpOB0TA0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739441372;\n\tbh=Ig2mNpvIWNJ6Czs3SK3PC/VTMYSXjoor7v2Woqz7U3o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=EpOB0TA0PHGUG0EOQn229M7vTOShlC3yThXXCzyBA9QArBpSr5nBPxFaSK+r1BGzT\n\t4ZiQgZn6d2PpL2OKxEpSleygiOV0MczpmQL7wWZULpY0tnkgrCgdL29PrsPZ0J8Taq\n\t2+qlpEq5+GnCKX1GoY5e4VnWzqVF/mywKVjnJfh0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250213085825.228191-1-naush@raspberrypi.com>","References":"<20250213085825.228191-1-naush@raspberrypi.com>","Subject":"Re: [PATCH v1] ipa: rpi: Fix incorrect cast for ExposureTime\n\tControlInfo","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 13 Feb 2025 10:10:48 +0000","Message-ID":"<173944144821.4102114.11332369397206961861@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]