{"id":22777,"url":"https://patchwork.libcamera.org/api/patches/22777/?format=json","web_url":"https://patchwork.libcamera.org/patch/22777/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250212113328.304528-1-stefan.klug@ideasonboard.com>","date":"2025-02-12T11:29:42","name":"libcamera: formats: Silence warning when creating a PixelFormatInfo from a null format","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8b726db3bcd6a3b188e70410856a3ae33906a850","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22777/mbox/","series":[{"id":4999,"url":"https://patchwork.libcamera.org/api/series/4999/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4999","date":"2025-02-12T11:29:42","name":"libcamera: formats: Silence warning when creating a PixelFormatInfo from a null format","version":1,"mbox":"https://patchwork.libcamera.org/series/4999/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22777/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22777/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B5BFC3304\n\tfor ;\n\tWed, 12 Feb 2025 11:33:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3775E6862C;\n\tWed, 12 Feb 2025 12:33:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AD5E685FF\n\tfor ;\n\tWed, 12 Feb 2025 12:33:35 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:533:2ab9:67b7:5f65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 195AC455;\n\tWed, 12 Feb 2025 12:32:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V+8Tf0bx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739359937;\n\tbh=5YsL9j9Q1/mW3Kn/Liq0D75xrnFAMXDm57H6ZO93YOM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=V+8Tf0bxYBIqcscF6UnE7a7ug+AC+ODK+RiPoeHsXZ8L/6jRbEJVgU1KzEh0Y/TBq\n\tArzdKGZMR9wzZtOSCGZrJeSrw3RU9wVXVX7De/JyCxPRIhB+mlNLM2sLoLMGNvQAOO\n\tFdxD9MwYWLzqWxsD7RRcvKvRGZOFJMqRvMw2m7Qk=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH] libcamera: formats: Silence warning when creating a\n\tPixelFormatInfo from a null format","Date":"Wed, 12 Feb 2025 12:29:42 +0100","Message-ID":"<20250212113328.304528-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Calling PixelFormat().toString() correctly returns \"0x0-\" but it\nalso produces the following, possibly confusing, warning:\n\nWARN Formats formats.cpp:1006 Unsupported pixel format 0x00000000\n\nSilence the warning in PixelFormatInfo::info() in case the format is\ninvalid.\n\nWhile at it, remove code duplication by using\nPixelFormatInfo::info(const PixelFormat &format) to implement\nPixelFormatInfo::info(const V4L2PixelFormat &format).\n\nSigned-off-by: Stefan Klug \n---\n\nHi all,\n\nThe attached patch has one noteworthy side effect: If\ninfo(V4L2PixelFormat &format) is called with a valid but unsupported (by\nlibcamera) format, we now get the same warning as in the\ninfo(PixelFormat &format) case. I believe that is sensible but maybe the\nwarning was left off in the V4L2 case on purpose.\n\nBest regards,\nStefan\n\n src/libcamera/formats.cpp | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex bfcdfc08960d..df7413f58ba8 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -1001,6 +1001,9 @@ const std::map pixelFormatInfo{\n */\n const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n {\n+\tif (!format.isValid())\n+\t\treturn pixelFormatInfoInvalid;\n+\n \tconst auto iter = pixelFormatInfo.find(format);\n \tif (iter == pixelFormatInfo.end()) {\n \t\tLOG(Formats, Warning)\n@@ -1021,14 +1024,7 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n {\n \tPixelFormat pixelFormat = format.toPixelFormat(false);\n-\tif (!pixelFormat.isValid())\n-\t\treturn pixelFormatInfoInvalid;\n-\n-\tconst auto iter = pixelFormatInfo.find(pixelFormat);\n-\tif (iter == pixelFormatInfo.end())\n-\t\treturn pixelFormatInfoInvalid;\n-\n-\treturn iter->second;\n+\treturn info(pixelFormat);\n }\n \n /**\n","prefixes":[]}