[{"id":33333,"web_url":"https://patchwork.libcamera.org/comment/33333/","msgid":"<173929659643.4102114.10433932082603269604@ping.linuxembedded.co.uk>","date":"2025-02-11T17:56:36","subject":"Re: [PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-02-11 17:20:56)\n> Apparently not every compiler is able to deduce types the same way. Fix\n> compile on gcc-9 by explicitly specifying the type.\n> \n> Fixes: ee918b370a08 (\"ipa: rkisp1: agc: Initialize enum controls with a list of values\")\n> Signed-off-by: Stefan Klug \n> ---\n> \n> Hi all,\n> \n> Unfortunately I broke the CI build of mainline :-(. This patch fixes it.\n> A corresponding CI run is here:\n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1362476\n\nAyeee,\n\nBeing explicit on the type looks fine here, and it's how the other\nControlValues are also specified, so I guess that's expected too.\n\nReviewed-by: Kieran Bingham \n\n> \n> Best regards,\n> Stefan\n> \n> src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index e7c6de757593..45ec72188b3a 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -151,11 +151,11 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> context.ctrlMap[&controls::ExposureTimeMode] =\n> ControlInfo({ { ControlValue(controls::ExposureTimeModeAuto),\n> ControlValue(controls::ExposureTimeModeManual) } },\n> - controls::ExposureTimeModeAuto);\n> + ControlValue(controls::ExposureTimeModeAuto));\n> context.ctrlMap[&controls::AnalogueGainMode] =\n> ControlInfo({ { ControlValue(controls::AnalogueGainModeAuto),\n> ControlValue(controls::AnalogueGainModeManual) } },\n> - controls::AnalogueGainModeAuto);\n> + ControlValue(controls::AnalogueGainModeAuto));\n> /* \\todo Move this to the Camera class */\n> context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);\n> context.ctrlMap.merge(controls());\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 169D5BD1F1\n\tfor ;\n\tTue, 11 Feb 2025 17:56:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E9F368626;\n\tTue, 11 Feb 2025 18:56:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B05EB685BE\n\tfor ;\n\tTue, 11 Feb 2025 18:56:39 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 467BD22E;\n\tTue, 11 Feb 2025 18:55:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pfpC13f1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739296522;\n\tbh=iD0aA6hmkqghGaCCbdu4wEtAeb8ZmbEEXa6eM4b8j8Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=pfpC13f1o/zZy2OJRVHkNi4SkQUHwUAi1M4B8AhRR3Zz+soIIPu60CPabxb5kQjwC\n\tdsEmFlrD7DVmHZRkFdFRv0GNcxP/S60lwfCmx8jgZQelau1gjnMmxrnPK/XQiW2dqn\n\t6uaErjHt5g76SR+I9JCwqxd/NmLwS39ASEm4ggbo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>","References":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 11 Feb 2025 17:56:36 +0000","Message-ID":"<173929659643.4102114.10433932082603269604@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33334,"web_url":"https://patchwork.libcamera.org/comment/33334/","msgid":"<173929670039.4102114.1586218293774827209@ping.linuxembedded.co.uk>","date":"2025-02-11T17:58:20","subject":"Re: [PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-02-11 17:56:36)\n> Quoting Stefan Klug (2025-02-11 17:20:56)\n> > Apparently not every compiler is able to deduce types the same way. Fix\n> > compile on gcc-9 by explicitly specifying the type.\n\nI think this fixes compilation on both gcc-9 and gcc-10 in fact, based\non both \n https://gitlab.freedesktop.org/camera/libcamera/-/jobs/70899831\nand\n https://gitlab.freedesktop.org/camera/libcamera/-/jobs/70878357\n\n--\nKieran\n\n> > \n> > Fixes: ee918b370a08 (\"ipa: rkisp1: agc: Initialize enum controls with a list of values\")\n> > Signed-off-by: Stefan Klug \n> > ---\n> > \n> > Hi all,\n> > \n> > Unfortunately I broke the CI build of mainline :-(. This patch fixes it.\n> > A corresponding CI run is here:\n> > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1362476\n> \n> Ayeee,\n> \n> Being explicit on the type looks fine here, and it's how the other\n> ControlValues are also specified, so I guess that's expected too.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > Best regards,\n> > Stefan\n> > \n> > src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> > index e7c6de757593..45ec72188b3a 100644\n> > --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> > @@ -151,11 +151,11 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> > context.ctrlMap[&controls::ExposureTimeMode] =\n> > ControlInfo({ { ControlValue(controls::ExposureTimeModeAuto),\n> > ControlValue(controls::ExposureTimeModeManual) } },\n> > - controls::ExposureTimeModeAuto);\n> > + ControlValue(controls::ExposureTimeModeAuto));\n> > context.ctrlMap[&controls::AnalogueGainMode] =\n> > ControlInfo({ { ControlValue(controls::AnalogueGainModeAuto),\n> > ControlValue(controls::AnalogueGainModeManual) } },\n> > - controls::AnalogueGainModeAuto);\n> > + ControlValue(controls::AnalogueGainModeAuto));\n> > /* \\todo Move this to the Camera class */\n> > context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);\n> > context.ctrlMap.merge(controls());\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F636BD1F1\n\tfor ;\n\tTue, 11 Feb 2025 17:58:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29DA76862C;\n\tTue, 11 Feb 2025 18:58:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ADFA685BE\n\tfor ;\n\tTue, 11 Feb 2025 18:58:23 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0EE76DF;\n\tTue, 11 Feb 2025 18:57:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o9/LAZJw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739296626;\n\tbh=hPiUn9BS240qsaxUi4Ruy0u34hHwVHzVhZMHMeN/4hk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=o9/LAZJwf/WOuF6X1XEnF5/oiyVnBfXcbPwSgs9407IC7oMHKUIeGckDbIDxVGmhj\n\t3V7Xo6FwSOTVfsR9kXxknXTytdiJvMOZ40oZtlK+AK+JYAyDDwM9/e1MHQ5fQgJIWN\n\tQyt658JW/IU7FLn59Uz4omOKwiCmy/IbePhSwvxs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<173929659643.4102114.10433932082603269604@ping.linuxembedded.co.uk>","References":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>\n\t<173929659643.4102114.10433932082603269604@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 11 Feb 2025 17:58:20 +0000","Message-ID":"<173929670039.4102114.1586218293774827209@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33335,"web_url":"https://patchwork.libcamera.org/comment/33335/","msgid":"<20250211202450.GA16912@pendragon.ideasonboard.com>","date":"2025-02-11T20:24:50","subject":"Re: [PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Feb 11, 2025 at 06:20:56PM +0100, Stefan Klug wrote:\n> Apparently not every compiler is able to deduce types the same way. Fix\n> compile on gcc-9 by explicitly specifying the type.\n> \n> Fixes: ee918b370a08 (\"ipa: rkisp1: agc: Initialize enum controls with a list of values\")\n> Signed-off-by: Stefan Klug \n\nIf this issue affected recent compilers I'd ask for a more detailed\nanalysis, and a bug report being filed to gcc. As I can't reproduce it\nneither with gcc 9.5.0 nor 10.5.0, that's not necessary. I'm still\ncurious to know why the compiler doesn't consider the right ControlInfo\nconstructor though.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> Hi all,\n> \n> Unfortunately I broke the CI build of mainline :-(. This patch fixes it.\n> A corresponding CI run is here:\n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1362476\n> \n> Best regards,\n> Stefan\n> \n> src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index e7c6de757593..45ec72188b3a 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -151,11 +151,11 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> \tcontext.ctrlMap[&controls::ExposureTimeMode] =\n> \t\tControlInfo({ { ControlValue(controls::ExposureTimeModeAuto),\n> \t\t\t\tControlValue(controls::ExposureTimeModeManual) } },\n> -\t\t\t controls::ExposureTimeModeAuto);\n> +\t\t\t ControlValue(controls::ExposureTimeModeAuto));\n> \tcontext.ctrlMap[&controls::AnalogueGainMode] =\n> \t\tControlInfo({ { ControlValue(controls::AnalogueGainModeAuto),\n> \t\t\t\tControlValue(controls::AnalogueGainModeManual) } },\n> -\t\t\t controls::AnalogueGainModeAuto);\n> +\t\t\t ControlValue(controls::AnalogueGainModeAuto));\n> \t/* \\todo Move this to the Camera class */\n> \tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);\n> \tcontext.ctrlMap.merge(controls());","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C023C326C\n\tfor ;\n\tTue, 11 Feb 2025 20:25:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AFAC6862B;\n\tTue, 11 Feb 2025 21:25:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CFE8685BE\n\tfor ;\n\tTue, 11 Feb 2025 21:25:01 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 977492B3;\n\tTue, 11 Feb 2025 21:23:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pZ2g++3s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739305423;\n\tbh=ywA8tu1cfQhC9RYmm3yJ3FPhOVXy1niNzOF6nWRhnoc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pZ2g++3s6tEnp6IaCp8FuhEwysxjx0txukQsNBOghSG2hw7zANvO9rdwlAaXoV6zD\n\tQ8Z0WQjD8rDE6exzL9GFgFfeQZ7CFIag0RYVq4/bFHPDvSL1rsTiVwPFNtlMdSmy6j\n\tCMmN75Isja2MUhVbXO7d6nMFlbBfEINCKLk24GNc=","Date":"Tue, 11 Feb 2025 22:24:50 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rkisp1: agc: Fix build on debian 11 (gcc-9)","Message-ID":"<20250211202450.GA16912@pendragon.ideasonboard.com>","References":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250211172115.210087-1-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]