[{"id":2985,"web_url":"https://patchwork.libcamera.org/comment/2985/","msgid":"<20191029143936.GK20198@bigcity.dyn.berto.se>","date":"2019-10-29T14:39:36","subject":"Re: [libcamera-devel] [PATCH v2 3/9] libcamera: bound_method: Store\n\tconnection type in BoundMethodBase","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-10-28 12:49:07 +0200, Laurent Pinchart wrote:\n> Store the connection type in the base BoundMethodBase class to make it\n> accessible to all bound methods. The default type is ConnectionTypeAuto.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/bound_method.h | 24 +++++++++++++++++-------\n> 1 file changed, 17 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index e1524c917e4b..06c5a3b12305 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -24,8 +24,10 @@ enum ConnectionType {\n> class BoundMethodBase\n> {\n> public:\n> -\tBoundMethodBase(void *obj, Object *object)\n> -\t\t: obj_(obj), object_(object) {}\n> +\tBoundMethodBase(void *obj, Object *object, ConnectionType type)\n> +\t\t: obj_(obj), object_(object), connectionType_(type)\n> +\t{\n> +\t}\n> \tvirtual ~BoundMethodBase() {}\n> \n> \ttemplate::value>::type * = nullptr>\n> @@ -33,6 +35,7 @@ public:\n> \tbool match(Object *object) { return object == object_; }\n> \n> \tObject *object() const { return object_; }\n> +\tConnectionType connectionType() const { return connectionType_; }\n> \n> \tvoid activatePack(void *pack);\n> \tvirtual void invokePack(void *pack) = 0;\n> @@ -40,6 +43,7 @@ public:\n> protected:\n> \tvoid *obj_;\n> \tObject *object_;\n> +\tConnectionType connectionType_;\n> };\n> \n> template\n> @@ -76,8 +80,8 @@ private:\n> \t}\n> \n> public:\n> -\tBoundMethodArgs(void *obj, Object *object)\n> -\t\t: BoundMethodBase(obj, object) {}\n> +\tBoundMethodArgs(void *obj, Object *object, ConnectionType type)\n> +\t\t: BoundMethodBase(obj, object, type) {}\n> \n> \tvoid invokePack(void *pack) override\n> \t{\n> @@ -94,8 +98,11 @@ class BoundMemberMethod : public BoundMethodArgs\n> public:\n> \tusing PackType = std::tuple::type...>;\n> \n> -\tBoundMemberMethod(T *obj, Object *object, void (T::*func)(Args...))\n> -\t\t: BoundMethodArgs(obj, object), func_(func) {}\n> +\tBoundMemberMethod(T *obj, Object *object, void (T::*func)(Args...),\n> +\t\t\t ConnectionType type = ConnectionTypeAuto)\n> +\t\t: BoundMethodArgs(obj, object, type), func_(func)\n> +\t{\n> +\t}\n> \n> \tbool match(void (T::*func)(Args...)) const { return func == func_; }\n> \n> @@ -121,7 +128,10 @@ class BoundStaticMethod : public BoundMethodArgs\n> {\n> public:\n> \tBoundStaticMethod(void (*func)(Args...))\n> -\t\t: BoundMethodArgs(nullptr, nullptr), func_(func) {}\n> +\t\t: BoundMethodArgs(nullptr, nullptr, ConnectionTypeAuto),\n> +\t\t func_(func)\n> +\t{\n> +\t}\n> \n> \tbool match(void (*func)(Args...)) const { return func == func_; }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78CFF6017E\n\tfor ;\n\tTue, 29 Oct 2019 15:39:38 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id q28so10717657lfa.5\n\tfor ;\n\tTue, 29 Oct 2019 07:39:38 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ti8sm811934ljj.11.2019.10.29.07.39.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 29 Oct 2019 07:39:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=rrhp0r8ggHGHr53zf2sR60w0wdo3ctpiQr2Sni8KQ74=;\n\tb=rd9RDDaU2HlOvrxohLylTs4rXYha79IyzW5x6zR9U+qiIb48rMkDIzQRA3Tt7JNgvH\n\t3tZqO6HsmoAromOD8DxkE0h1e6WypoQh0ZAUZ2jJ32r4CyhItN7eUXHzznmBS6O8O9WU\n\tdkRfe8ndXJQSyYN1mtjbHxoAUJJ7hUA1Ck3Wfw6K/GrmK2yzCYyh5v2zP4lSn8LJQ+1o\n\tM4XWLV2ESTzPS6Q2CY0uJJBOuN1pA4P76Q1P0v2MVzpzYtOKFFmXugkpjb52KOdNx7MQ\n\tAC+8BeZvjyhfObOnMY7F4ExW/4c+VjedR1QYuSnpgR9u4HBV2OBDv2rTrlwboD2lV5sN\n\t8Ueg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=rrhp0r8ggHGHr53zf2sR60w0wdo3ctpiQr2Sni8KQ74=;\n\tb=jNxgLfBihyTCa0sS7Dm91MccwJOhCLErKAri2xa2LyMY3MKjIv50rCmY5hjfT6+68W\n\tJ/L+QutNWiomISGrsTJJbmr81j1hDTqnRFH3edZ203L2lybstmE1ty+qk8lgHxsFiFkc\n\tZ0Z84a4jLZZat4M47SAhqnbqGR79C2+JxtuEo3LUGgXF5Awxe8CC//SaWpCLHe9GaM0G\n\ty7Fh1ShmIS7P1pCvombFaJQRxe1reDRJHMZof8gnNGA9RL5hnKL7CEk+l5bBRlbaefCd\n\tB6s+yFu2HR9L8pxQYYq8ATh+R1GvS7wT5WHak3nCWnJLRMqJfvtS2+2WcFyclwAZ8gUC\n\twt9w==","X-Gm-Message-State":"APjAAAWFqX5h2dsZCOfyEUWaQBjkU2fDZZU5ytdWW6snIdBB1YGeJiDf\n\tgwZvoA996fvbXJkdqRnbjXG9hQ==","X-Google-Smtp-Source":"APXvYqxYFGU3U/6LcnxeeJ//f8opzz3TtVONBPFwCTH1IacQ7PHchUmNmaucpRunv7bYtAjzxDelXQ==","X-Received":"by 2002:a05:6512:40e:: with SMTP id\n\tu14mr2779179lfk.73.1572359977826; \n\tTue, 29 Oct 2019 07:39:37 -0700 (PDT)","Date":"Tue, 29 Oct 2019 15:39:36 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191029143936.GK20198@bigcity.dyn.berto.se>","References":"<20191028104913.14985-1-laurent.pinchart@ideasonboard.com>\n\t<20191028104913.14985-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028104913.14985-4-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 3/9] libcamera: bound_method: Store\n\tconnection type in BoundMethodBase","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Oct 2019 14:39:38 -0000"}}]