{"id":2275,"url":"https://patchwork.libcamera.org/api/patches/2275/?format=json","web_url":"https://patchwork.libcamera.org/patch/2275/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191028104913.14985-3-laurent.pinchart@ideasonboard.com>","date":"2019-10-28T10:49:06","name":"[libcamera-devel,v2,2/9] libcamera: bound_method: Define connection type for method invocation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cc5cd708e315bd0bd047e227fab532fd31fd731f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2275/mbox/","series":[{"id":562,"url":"https://patchwork.libcamera.org/api/series/562/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=562","date":"2019-10-28T10:49:04","name":"Add support for blocking method invocation","version":2,"mbox":"https://patchwork.libcamera.org/series/562/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2275/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2275/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D3A760180\n\tfor ;\n\tMon, 28 Oct 2019 11:49:26 +0100 (CET)","from pendragon.ideasonboard.com (unknown [91.217.168.176])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0628325\n\tfor ;\n\tMon, 28 Oct 2019 11:49:25 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572259765;\n\tbh=bZ0U1F0cR4aWfYQjFJGt08aQHdMjbaUgrBZtrHOjRh4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=TknU/cwt/GOHT40MaWaYuKFEPaZ9RuGU2UQO4VntN6nZ6NQG7nVjW9DrLjtGTQLCw\n\thYO/VXPLN2LChVC7qNxfK1MeH7RS0+mjH5b8bW5YjEC0ycnMZjXMUp2+2+glH6DnC5\n\tNM06wijv+J/mGF4xpRuC8BDIkFK+Vy9Q06vgqPNA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Oct 2019 12:49:06 +0200","Message-Id":"<20191028104913.14985-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191028104913.14985-1-laurent.pinchart@ideasonboard.com>","References":"<20191028104913.14985-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/9] libcamera: bound_method: Define\n\tconnection type for method invocation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 28 Oct 2019 10:49:26 -0000"},"content":"From: Jacopo Mondi \n\nDefine an enumeration of connection types to describe the delivery\nmethod of signals and method invocation.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Laurent Pinchart \n---\n Documentation/Doxyfile.in | 4 +---\n include/libcamera/bound_method.h | 7 +++++++\n src/libcamera/bound_method.cpp | 34 ++++++++++++++++++++++++++++++++\n 3 files changed, 42 insertions(+), 3 deletions(-)","diff":"diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\nindex 5237cf60854f..24babfd8b366 100644\n--- a/Documentation/Doxyfile.in\n+++ b/Documentation/Doxyfile.in\n@@ -837,9 +837,7 @@ RECURSIVE = YES\n # Note that relative paths are relative to the directory from which doxygen is\n # run.\n \n-EXCLUDE = @TOP_SRCDIR@/include/libcamera/bound_method.h \\\n-\t\t\t @TOP_SRCDIR@/src/libcamera/bound_method.cpp \\\n-\t\t\t @TOP_SRCDIR@/src/libcamera/device_enumerator_sysfs.cpp \\\n+EXCLUDE = @TOP_SRCDIR@/src/libcamera/device_enumerator_sysfs.cpp \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/device_enumerator_udev.cpp \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/include/device_enumerator_sysfs.h \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/include/device_enumerator_udev.h \\\ndiff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex 8ebaadbec887..e1524c917e4b 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -14,6 +14,13 @@ namespace libcamera {\n \n class Object;\n \n+enum ConnectionType {\n+\tConnectionTypeAuto,\n+\tConnectionTypeDirect,\n+\tConnectionTypeQueued,\n+\tConnectionTypeBlocking,\n+};\n+\n class BoundMethodBase\n {\n public:\ndiff --git a/src/libcamera/bound_method.cpp b/src/libcamera/bound_method.cpp\nindex d89f84c03f4d..ab6ecd9423d1 100644\n--- a/src/libcamera/bound_method.cpp\n+++ b/src/libcamera/bound_method.cpp\n@@ -11,8 +11,42 @@\n #include \"thread.h\"\n #include \"utils.h\"\n \n+/**\n+ * \\file bound_method.h\n+ * \\brief Method bind and invocation\n+ */\n+\n namespace libcamera {\n \n+/**\n+ * \\enum ConnectionType\n+ * \\brief Connection type for asynchronous communication\n+ *\n+ * This enumeration describes the possible types of asynchronous communication\n+ * between a sender and a receiver. It applies to Signal::emit() and\n+ * Object::invokeMethod().\n+ *\n+ * \\var ConnectionType::ConnectionTypeAuto\n+ * \\brief If the sender and the receiver live in the same thread,\n+ * ConnectionTypeDirect is used. Otherwise ConnectionTypeQueued is used.\n+ *\n+ * \\var ConnectionType::ConnectionTypeDirect\n+ * \\brief The receiver is invoked immediately and synchronously in the sender's\n+ * thread.\n+ *\n+ * \\var ConnectionType::ConnectionTypeQueued\n+ * \\brief The receiver is invoked asynchronously in its thread when control\n+ * returns to the thread's event loop. The sender proceeds without waiting for\n+ * the invocation to complete.\n+ *\n+ * \\var ConnectionType::ConnectionTypeBlocking\n+ * \\brief The receiver is invoked asynchronously in its thread when control\n+ * returns to the thread's event loop. The sender blocks until the receiver\n+ * signals the completion of the invocation. This connection type shall not be\n+ * used when the sender and receiver live in the same thread, otherwise\n+ * deadlock will occur.\n+ */\n+\n void BoundMethodBase::activatePack(void *pack)\n {\n \tif (Thread::current() == object_->thread()) {\n","prefixes":["libcamera-devel","v2","2/9"]}