{"id":22740,"url":"https://patchwork.libcamera.org/api/patches/22740/?format=json","web_url":"https://patchwork.libcamera.org/patch/22740/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250206092446.36237-1-naush@raspberrypi.com>","date":"2025-02-06T09:24:36","name":"[v2] ipa: rpi: Apply default ControlInfo values for sensor controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8c69d402b15c95a5f7c350f7c44caff579caff0f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22740/mbox/","series":[{"id":4991,"url":"https://patchwork.libcamera.org/api/series/4991/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4991","date":"2025-02-06T09:24:36","name":"[v2] ipa: rpi: Apply default ControlInfo values for sensor controls","version":2,"mbox":"https://patchwork.libcamera.org/series/4991/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22740/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22740/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70149C0F2A\n\tfor ;\n\tThu, 6 Feb 2025 09:24:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D36685D8;\n\tThu, 6 Feb 2025 10:24:52 +0100 (CET)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F9356858E\n\tfor ;\n\tThu, 6 Feb 2025 10:24:51 +0100 (CET)","by mail-wr1-x42d.google.com with SMTP id\n\tffacd0b85a97d-38dc33a4426so12926f8f.1\n\tfor ;\n\tThu, 06 Feb 2025 01:24:51 -0800 (PST)","from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4390d933523sm49742755e9.1.2025.02.06.01.24.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 06 Feb 2025 01:24:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"V2ff6r3G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1738833890; x=1739438690;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eDgxzKuvgqGWG2k8IhVaUFFuUSKlaWtvR3gM1OeIgIg=;\n\tb=V2ff6r3Gq0IV+5YbeLICvSCzLkQ/E315buOC/fnTbpWyNZ3HXGXC+Hxspczvt8vxZS\n\tpOeSGWyz9Hnw1AOSgvDoQbXlHPFXq1hM2PY/M9wLHf30kZESRjt7g6pTbmfK1Na2HUhp\n\t9RswgOl9QoYe+3PrzpYpy7wOF2OyAZSkziPXXoZryY05WbpNQwC8HKCbP6SVlMTM+oLr\n\tUGY1heigHuegz9IPD1xDROtbPRkg0QMvHm/WnAKwOcBr+ncZjrQFvqI+HS9tKQx007WD\n\tsp/5hxSbWfruYu8G8pDXxoQHCIek0jraZK6mXfNBLWjk2Yv9iEG2YUvGNLqp4ea96BrV\n\tREmw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1738833890; x=1739438690;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=eDgxzKuvgqGWG2k8IhVaUFFuUSKlaWtvR3gM1OeIgIg=;\n\tb=O1d+UUwmpYXivuXEA8VdtkukFGV6HCFBF0LxWCoUPHCqDPcRhS2d7sKt3PojXJk3A9\n\ta1U3gBnDMICXVZrr4WTDVVgBtxfkuqaDLoz1ZiPGVRgnXbvQwBLMzW9qqOpSdrupfOwG\n\tjWFAcQtGk3MpD6xz6vjIGbqt4hFVKp59sQsFrq8ZIRZ9oCQkXLku3EaoXpWVL8MZ88Ua\n\t4KiQVJ+tr1DgrjEgu3dWK7CDiQtwEiS/W3wrXUWgZWuMqpFA/2fkFiQ5x+JmqNSY901N\n\tQeBdA1hp6SmCXLybSw/6FZyNVdpCLNaJdfwSsGeCKtFP990exT1Se7sWUsgV4J0ddXkO\n\tHhFA==","X-Gm-Message-State":"AOJu0YyFXkJkQt80JaNR2Vn5mmzALTvQspUKjRbvqbAycnAfEVhWF8XN\n\tJLHvNA1ZHRL5whDibVPVqos7eB81DHtBGnb41YPqUSZY9aEn4ngaGeBOM2arKRxf3GfYo62J+NI\n\tHUWY=","X-Gm-Gg":"ASbGncuL7LO0eBhsMzKaaZon+KnfCivfWuQofvaIss55p/+C8UYEVDJfLneYo/Xumky\n\t40IQ8njNzFBjjFgIPmib1Zi1RHwsP7x6OqfXeyDTaO8HhrYu/0JSWKFRbProRoinYMq213SIZ0w\n\tDD8SQZa5ftX1DDjl2HBUsKviXaHe9zmiVczGPGcAJKeBxU9ZZlF8mo1EP1ITY/6eAHOPXH6JbNz\n\tY94KFcgITEZhIQG8S2e7ZtmIMWEASLyoXF62r4J5n+nXS4r7NVLvso1pGZGEk73BByQKxJmzQHg\n\tIQ+oDUsd3LJVgUmkVmyMUG9wVZD+hp94kH8=","X-Google-Smtp-Source":"AGHT+IFoFszNhyDSSKtIAM2mW0l5crkZ0rMiIBoYI4aiKa+s/mLumqNgFZGGNtEAorPZ6zCsqj1mUQ==","X-Received":"by 2002:a05:600c:1910:b0:42c:c0d8:bf49 with SMTP id\n\t5b1f17b1804b1-4390d34c649mr19196575e9.0.1738833890146; \n\tThu, 06 Feb 2025 01:24:50 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH v2] ipa: rpi: Apply default ControlInfo values for sensor\n\tcontrols","Date":"Thu, 6 Feb 2025 09:24:36 +0000","Message-ID":"<20250206092446.36237-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The existing IPA initialisation code did not set default values for\nsome sensor related controls. This caused a crash using libcamerify\nwhen the it was trying to access the default value for\ncontrols::FrameDurationLimits as part of a recent change.\n\nEnsure controls::FrameDurationLimits, controls::AnalogueGain and\ncontrols::ExposureTime advertise default values along with the existing\nmin/max values. The default is set to the defaults defined in the IPA\nset during initialisation.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=253\nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/common/ipa_base.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex bd3c22000df5..3c77665e6ab4 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -259,15 +259,18 @@ int32_t IpaBase::configure(const IPACameraSensorInfo &sensorInfo, const ConfigPa\n \tControlInfoMap::Map ctrlMap = ipaControls;\n \tctrlMap[&controls::FrameDurationLimits] =\n \t\tControlInfo(static_cast(mode_.minFrameDuration.get()),\n-\t\t\t static_cast(mode_.maxFrameDuration.get()));\n+\t\t\t static_cast(mode_.maxFrameDuration.get()),\n+\t\t\t static_cast(defaultMinFrameDuration.get()));\n \n \tctrlMap[&controls::AnalogueGain] =\n \t\tControlInfo(static_cast(mode_.minAnalogueGain),\n-\t\t\t static_cast(mode_.maxAnalogueGain));\n+\t\t\t static_cast(mode_.maxAnalogueGain),\n+\t\t\t static_cast(defaultAnalogueGain));\n \n \tctrlMap[&controls::ExposureTime] =\n \t\tControlInfo(static_cast(mode_.minExposureTime.get()),\n-\t\t\t static_cast(mode_.maxExposureTime.get()));\n+\t\t\t static_cast(mode_.maxExposureTime.get()),\n+\t\t\t static_cast(defaultExposureTime.get()));\n \n \t/* Declare colour processing related controls for non-mono sensors. */\n \tif (!monoSensor_)\n","prefixes":["v2"]}