{"id":22724,"url":"https://patchwork.libcamera.org/api/patches/22724/?format=json","web_url":"https://patchwork.libcamera.org/patch/22724/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250203104318.135628-3-pobrn@protonmail.com>","date":"2025-02-03T10:43:31","name":"[v1,2/3] libcamera: pipeline: virtual: Fill buffer's metadata","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bf48efe9e86ef427676404af224c09b18bcf8dc2","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22724/mbox/","series":[{"id":4987,"url":"https://patchwork.libcamera.org/api/series/4987/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4987","date":"2025-02-03T10:43:20","name":"libcamera: pipeline: virtual: Fill buffer's metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/4987/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22724/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22724/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E681C3260\n\tfor ;\n\tMon, 3 Feb 2025 10:43:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 397AA6858C;\n\tMon, 3 Feb 2025 11:43:37 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42AA26857A\n\tfor ;\n\tMon, 3 Feb 2025 11:43:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"YjFUIG+x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738579414; x=1738838614;\n\tbh=NXTZOwbq7qrLNYlXyivWbbyUZ65fjgU3U3UGXy1aELY=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=YjFUIG+xJlijAcoookSNtEh0vjo9LOTXe+UzgoInvH9T7D68uEYCfkrVTQU57L8uN\n\tnyr1ZLGEHW6MgtVnqin0yfcMapLROftWtR8HKMl94tBJjRA1CeCb3YIy1zBr5BQVQD\n\t6XRkgZwSZrI0Cm+y36TAOUBnQ5dy2Aeltn7M3fytQh08J+ajUyIBWqGbvCIOmtEpTP\n\tscoy3I0nL95hp+Jfj6JDWC5VXClS7Z31LtBOrq40yLJTYlujip6G3zl5Llf9bAKlU2\n\t2g+kzG3kIQJl8yDJhXFIhDTKoxzxPjeYT3X5kd1u5DoP5nma46cBVa++MnrBWr5B+F\n\t3W1953OG+K4dw==","Date":"Mon, 03 Feb 2025 10:43:31 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1 2/3] libcamera: pipeline: virtual: Fill buffer's metadata","Message-ID":"<20250203104318.135628-3-pobrn@protonmail.com>","In-Reply-To":"<20250203104318.135628-1-pobrn@protonmail.com>","References":"<20250203104318.135628-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"8fa4db268adadcbc9030686ecc36f9350dff7f2e","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fill the `FrameMetadata` object of the `FrameBuffer`s because it\nshould not be left uninitialized as users expect to be able to\naccess it and find reasonable data there.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=245\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/virtual/virtual.cpp | 18 +++++++++++++++++-\n src/libcamera/pipeline/virtual/virtual.h | 1 +\n 2 files changed, 18 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex 94c2bd91e..1a75f35aa 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -286,6 +286,11 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,\n int PipelineHandlerVirtual::start([[maybe_unused]] Camera *camera,\n \t\t\t\t [[maybe_unused]] const ControlList *controls)\n {\n+\tVirtualCameraData *data = cameraData(camera);\n+\n+\tfor (auto &s : data->streamConfigs_)\n+\t\ts.seq = 0;\n+\n \treturn 0;\n }\n \n@@ -297,13 +302,24 @@ int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera,\n \t\t\t\t\t Request *request)\n {\n \tVirtualCameraData *data = cameraData(camera);\n+\tconst auto timestamp = currentTimestamp();\n \n \tfor (auto const &[stream, buffer] : request->buffers()) {\n \t\tbool found = false;\n \t\t/* map buffer and fill test patterns */\n \t\tfor (auto &streamConfig : data->streamConfigs_) {\n \t\t\tif (stream == &streamConfig.stream) {\n+\t\t\t\tFrameMetadata &fmd = buffer->_d()->metadata();\n+\n+\t\t\t\tfmd.status = FrameMetadata::Status::FrameSuccess;\n+\t\t\t\tfmd.sequence = streamConfig.seq++;\n+\t\t\t\tfmd.timestamp = timestamp;\n+\n+\t\t\t\tfor (const auto [i, p] : utils::enumerate(buffer->planes()))\n+\t\t\t\t\tfmd.planes()[i].bytesused = p.length;\n+\n \t\t\t\tfound = true;\n+\n \t\t\t\tif (streamConfig.frameGenerator->generateFrame(\n \t\t\t\t\t stream->configuration().size, buffer))\n \t\t\t\t\tbuffer->_d()->cancel();\n@@ -315,7 +331,7 @@ int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera,\n \t\tASSERT(found);\n \t}\n \n-\trequest->metadata().set(controls::SensorTimestamp, currentTimestamp());\n+\trequest->metadata().set(controls::SensorTimestamp, timestamp);\n \tcompleteRequest(request);\n \n \treturn 0;\ndiff --git a/src/libcamera/pipeline/virtual/virtual.h b/src/libcamera/pipeline/virtual/virtual.h\nindex 92ad7d4a9..683cb82b4 100644\n--- a/src/libcamera/pipeline/virtual/virtual.h\n+++ b/src/libcamera/pipeline/virtual/virtual.h\n@@ -37,6 +37,7 @@ public:\n \tstruct StreamConfig {\n \t\tStream stream;\n \t\tstd::unique_ptr frameGenerator;\n+\t\tunsigned int seq = 0;\n \t};\n \t/* The config file is parsed to the Configuration struct */\n \tstruct Configuration {\n","prefixes":["v1","2/3"]}