[{"id":33253,"web_url":"https://patchwork.libcamera.org/comment/33253/","msgid":"<173858051370.1773152.5868757282341063572@ping.linuxembedded.co.uk>","date":"2025-02-03T11:01:53","subject":"Re: [PATCH v1 1/3] libcamera: pipeline: virtual: Simplify error\n\treturn","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-02-03 10:43:24)\n> Just return an `std::unique_ptr` constructed from an empty\n> initializer instead of doing a `reset()` on the existing\n> `config` variable and returning that. This is simpler.\n> \n> Signed-off-by: Barnabás Pőcze \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/virtual/virtual.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\n> index fc46653f6..94c2bd91e 100644\n> --- a/src/libcamera/pipeline/virtual/virtual.cpp\n> +++ b/src/libcamera/pipeline/virtual/virtual.cpp\n> @@ -232,8 +232,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera,\n> default:\n> LOG(Virtual, Error)\n> << \"Requested stream role not supported: \" << role;\n> - config.reset();\n> - return config;\n> + return {};\n> }\n> \n> std::map> streamFormats;\n> -- \n> 2.48.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8677BD80A\n\tfor ;\n\tMon, 3 Feb 2025 11:01:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEFE76857B;\n\tMon, 3 Feb 2025 12:01:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D61E61876\n\tfor ;\n\tMon, 3 Feb 2025 12:01:57 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C05A497;\n\tMon, 3 Feb 2025 12:00:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rAuOQp5x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738580446;\n\tbh=zQBWcA5ik1X/Oux0Cb11TOyZ3fKCV5LKoB99tgGOqn8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=rAuOQp5xZ5wp74cbfcoF8dkRsg5tYb0KBJxkvdnlLWS35LEQnP+wRUcPzVHsTqiQh\n\t77YiGd0NYIUH4yoofEm6tCmhy7nqhefPM3od7MUsijhc7k6SGMQnNQIbd3XsxIFv01\n\tQ4Fb0ZBCRuLspNQ3uxJWJ50EC0OfNyTMyYKM+alY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250203104318.135628-2-pobrn@protonmail.com>","References":"<20250203104318.135628-1-pobrn@protonmail.com>\n\t<20250203104318.135628-2-pobrn@protonmail.com>","Subject":"Re: [PATCH v1 1/3] libcamera: pipeline: virtual: Simplify error\n\treturn","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Feb 2025 11:01:53 +0000","Message-ID":"<173858051370.1773152.5868757282341063572@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33268,"web_url":"https://patchwork.libcamera.org/comment/33268/","msgid":"","date":"2025-02-03T17:31:33","subject":"Re: [PATCH v1 1/3] libcamera: pipeline: virtual: Simplify error\n\treturn","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Feb 03, 2025 at 10:43:24AM +0000, Barnabás Pőcze wrote:\n> Just return an `std::unique_ptr` constructed from an empty\n> initializer instead of doing a `reset()` on the existing\n> `config` variable and returning that. This is simpler.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/virtual/virtual.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\n> index fc46653f6..94c2bd91e 100644\n> --- a/src/libcamera/pipeline/virtual/virtual.cpp\n> +++ b/src/libcamera/pipeline/virtual/virtual.cpp\n> @@ -232,8 +232,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera,\n> \t\tdefault:\n> \t\t\tLOG(Virtual, Error)\n> \t\t\t\t<< \"Requested stream role not supported: \" << role;\n> -\t\t\tconfig.reset();\n> -\t\t\treturn config;\n> +\t\t\treturn {};\n> \t\t}\n>\n> \t\tstd::map> streamFormats;\n> --\n> 2.48.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69BEEC3260\n\tfor ;\n\tMon, 3 Feb 2025 17:31:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F3976859A;\n\tMon, 3 Feb 2025 18:31:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3117C61876\n\tfor ;\n\tMon, 3 Feb 2025 18:31:37 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 800DD8DB;\n\tMon, 3 Feb 2025 18:30:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kljfzhw5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738603825;\n\tbh=0Q45bfpFZh3h18rJhJu4xRpIJqkNaXvI6iNhglUE20o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kljfzhw52Hbq7iYxpR0eMLwDs7BITZDnqGJO6Zj+qPpD/OhKXh2ajurTaDgky/6MU\n\tNZVR47VwtkMpovTcb51E5VbU5QXUFEI/HVSu8gUZQOrJqgdJJzYRJQeUDePVH5+csh\n\tMtxTb3k6i41X/4rlMiIAMxeIfDI8MVSHzpQui1ps=","Date":"Mon, 3 Feb 2025 18:31:33 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/3] libcamera: pipeline: virtual: Simplify error\n\treturn","Message-ID":"","References":"<20250203104318.135628-1-pobrn@protonmail.com>\n\t<20250203104318.135628-2-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250203104318.135628-2-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]