{"id":22723,"url":"https://patchwork.libcamera.org/api/patches/22723/?format=json","web_url":"https://patchwork.libcamera.org/patch/22723/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250203104318.135628-2-pobrn@protonmail.com>","date":"2025-02-03T10:43:24","name":"[v1,1/3] libcamera: pipeline: virtual: Simplify error return","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b93a344c5369a355470617727c32495beba5e50d","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22723/mbox/","series":[{"id":4987,"url":"https://patchwork.libcamera.org/api/series/4987/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4987","date":"2025-02-03T10:43:20","name":"libcamera: pipeline: virtual: Fill buffer's metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/4987/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22723/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22723/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA8BAC3260\n\tfor ;\n\tMon, 3 Feb 2025 10:43:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74AA868588;\n\tMon, 3 Feb 2025 11:43:31 +0100 (CET)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F6036857A\n\tfor ;\n\tMon, 3 Feb 2025 11:43:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"M5CYYgX/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738579410; x=1738838610;\n\tbh=1R1BISHVdqErcyRJD1onzerDZ+4cX2jP6Z5GP/xx5qc=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=M5CYYgX/JJWK2DYIj2l7La0gGcSJCJp1jWPX4Wfhba+o5y4cPbDaVLMRiCF+LhFgL\n\tFDLSCwFf8jVeItp4bRR5dbz0obgZqwfh1QmoVMA0nUAzFBZEirrzqZtXf4iuWzFrh1\n\thXBXr2k8t8JgXVXQW3EZExoyJeDoetnlT4+X6pDFVjrW1liox0xOuyY0MXK8h0nhPI\n\tpgmgh5/73IQelJxbkUUXh25cyT5YqgX40ik6oSOR7hf9sD0flph+UGmnoeMb0bTG7h\n\trzw4sVHd/GQ14nttdSld2F7LGs2i7UtpAUxgn59i+bqbxE7OL4SFozV8WzEBBqm9jI\n\tKPv1ZNOvchd8g==","Date":"Mon, 03 Feb 2025 10:43:24 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1 1/3] libcamera: pipeline: virtual: Simplify error return","Message-ID":"<20250203104318.135628-2-pobrn@protonmail.com>","In-Reply-To":"<20250203104318.135628-1-pobrn@protonmail.com>","References":"<20250203104318.135628-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"7ad9abafa74da0594e7c9b957f38305ebdf0f529","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Just return an `std::unique_ptr` constructed from an empty\ninitializer instead of doing a `reset()` on the existing\n`config` variable and returning that. This is simpler.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/virtual/virtual.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex fc46653f6..94c2bd91e 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -232,8 +232,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera,\n \t\tdefault:\n \t\t\tLOG(Virtual, Error)\n \t\t\t\t<< \"Requested stream role not supported: \" << role;\n-\t\t\tconfig.reset();\n-\t\t\treturn config;\n+\t\t\treturn {};\n \t\t}\n \n \t\tstd::map> streamFormats;\n","prefixes":["v1","1/3"]}