{"id":22701,"url":"https://patchwork.libcamera.org/api/patches/22701/?format=json","web_url":"https://patchwork.libcamera.org/patch/22701/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130181449.130492-5-mzamazal@redhat.com>","date":"2025-01-30T18:14:41","name":"[v5,04/10] libcamera: software_isp: lut: Remove maybe_unused on a used argument","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"1fa54d5e324a99c3a1ef4d83e0a4e155ee59ae26","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22701/mbox/","series":[{"id":4980,"url":"https://patchwork.libcamera.org/api/series/4980/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4980","date":"2025-01-30T18:14:37","name":"Software ISP support for CCM","version":5,"mbox":"https://patchwork.libcamera.org/series/4980/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22701/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22701/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 854BBBD808\n\tfor ;\n\tThu, 30 Jan 2025 18:15:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 363B168572;\n\tThu, 30 Jan 2025 19:15:22 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECF5768563\n\tfor ;\n\tThu, 30 Jan 2025 19:15:19 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-83-gLOZEKUJOPePKceee0YGtQ-1;\n\tThu, 30 Jan 2025 13:15:15 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B7B6D1956050; Thu, 30 Jan 2025 18:15:14 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.122])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6D8C330001BE; Thu, 30 Jan 2025 18:15:12 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XKU1vDdp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738260919;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=gkrjfbICJlLohfzs0+B2squ+TC5EbtoFtQsTYgYHlvQ=;\n\tb=XKU1vDdprTEn7UoIhpDp+185BQlP6HhSHgpT0m/CNsCZKODcgGxDcUiCx5C/HlTdUmGHO0\n\tLaLfaBn+0jUq3fEqDp9txWCXtzOJY5pK1ielD/YtbfTdarPci0wBWszCkLvDWb1ETowwam\n\tSvfr1uc/uctfLcVFx9h7M1mvxT3Vr+g=","X-MC-Unique":"gLOZEKUJOPePKceee0YGtQ-1","X-Mimecast-MFC-AGG-ID":"gLOZEKUJOPePKceee0YGtQ","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tRobert Mader ,\n\tHans de Goede ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v5 04/10] libcamera: software_isp: lut: Remove maybe_unused\n\ton a used argument","Date":"Thu, 30 Jan 2025 19:14:41 +0100","Message-ID":"<20250130181449.130492-5-mzamazal@redhat.com>","In-Reply-To":"<20250130181449.130492-1-mzamazal@redhat.com>","References":"<20250130181449.130492-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9iK4iK3wB7yKicXK2pgeSimIdcJFulCeorIXSGdWgEg_1738260914","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"`params' argument of Lut::prepare is actually used, let's remove\nmaybe_unused from it.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/simple/algorithms/lut.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex bd37a955..e5e995c7 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -83,7 +83,7 @@ void Lut::updateGammaTable(IPAContext &context)\n void Lut::prepare(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n-\t\t [[maybe_unused]] DebayerParams *params)\n+\t\t DebayerParams *params)\n {\n \t/*\n \t * Update the gamma table if needed. This means if black level changes\n","prefixes":["v5","04/10"]}