{"id":22692,"url":"https://patchwork.libcamera.org/api/patches/22692/?format=json","web_url":"https://patchwork.libcamera.org/patch/22692/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130173254.112895-2-mzamazal@redhat.com>","date":"2025-01-30T17:32:48","name":"[v4,1/6] libcamera: software_isp: Track frames and requests","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ed8b7e27e7e09b8c566b78c7b40711d677c1a054","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22692/mbox/","series":[{"id":4979,"url":"https://patchwork.libcamera.org/api/series/4979/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4979","date":"2025-01-30T17:32:47","name":"ipa: simple: Introduce metadata reporting","version":4,"mbox":"https://patchwork.libcamera.org/series/4979/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22692/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22692/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB6D3C324C\n\tfor ;\n\tThu, 30 Jan 2025 17:33:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B73106856E;\n\tThu, 30 Jan 2025 18:33:12 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F97168559\n\tfor ;\n\tThu, 30 Jan 2025 18:33:09 +0100 (CET)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-581-5BqbX7IlMlqP1NyD2hPwIg-1;\n\tThu, 30 Jan 2025 12:33:04 -0500","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id EB12D19560AF; Thu, 30 Jan 2025 17:33:02 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.122])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id EB26E1956094; Thu, 30 Jan 2025 17:33:00 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"b1dT6FV5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738258388;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=JsJK5TzQ2MRpZTNymsDFwD1Wt8wjT3TJfSgbZhPdRdk=;\n\tb=b1dT6FV5GSYn0lJ2RmbB+aNPy5OjC3RCFv3v1ZezTyNxFuMgf1jTsKJU7wKduKjsKs9jFH\n\tUnvOu+46miOHlCO/TPFL7cSzgKQfx2GvPy7rHhnVLjf3T+dvHqCSX4SKh9ZW3wlr2CIB6P\n\tvQMOS4niRzmuRCJgxrBUaYQMmlqZhrY=","X-MC-Unique":"5BqbX7IlMlqP1NyD2hPwIg-1","X-Mimecast-MFC-AGG-ID":"5BqbX7IlMlqP1NyD2hPwIg","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"[PATCH v4 1/6] libcamera: software_isp: Track frames and requests","Date":"Thu, 30 Jan 2025 18:32:48 +0100","Message-ID":"<20250130173254.112895-2-mzamazal@redhat.com>","In-Reply-To":"<20250130173254.112895-1-mzamazal@redhat.com>","References":"<20250130173254.112895-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"DEJPoibluMg4b3b8Bcwy_wOy0eVbKI8sARCTf43RPIM_1738258383","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hardware pipelines track requests and other information related to\nparticular frames. This hasn't been needed in software ISP so far. But\nin order to be able to track metadata corresponding to a given frame,\nframe-request tracking mechanism starts being useful. This patch\nintroduces the basic tracking structure, actual metadata handling is\nadded in the following patch.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 85 ++++++++++++++++++++++--\n 1 file changed, 80 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 8ac24e6e..2cfa4e42 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -181,6 +181,64 @@ LOG_DEFINE_CATEGORY(SimplePipeline)\n \n class SimplePipelineHandler;\n \n+struct SimpleFrameInfo {\n+\tuint32_t frame;\n+\tRequest *request;\n+};\n+\n+class SimpleFrames\n+{\n+public:\n+\tvoid create(Request *request);\n+\tvoid destroy(uint32_t frame);\n+\tvoid clear();\n+\n+\tSimpleFrameInfo *find(uint32_t frame);\n+\tSimpleFrameInfo *find(Request *request);\n+\n+private:\n+\tstd::map frameInfo_;\n+};\n+\n+void SimpleFrames::create(Request *request)\n+{\n+\tuint32_t frame = request->sequence();\n+\tauto [it, inserted] = frameInfo_.try_emplace(request->sequence());\n+\tASSERT(inserted);\n+\tit->second.frame = frame;\n+\tit->second.request = request;\n+}\n+\n+void SimpleFrames::destroy(uint32_t frame)\n+{\n+\tframeInfo_.erase(frame);\n+}\n+\n+void SimpleFrames::clear()\n+{\n+\tframeInfo_.clear();\n+}\n+\n+SimpleFrameInfo *SimpleFrames::find(uint32_t frame)\n+{\n+\tauto info = frameInfo_.find(frame);\n+\tif (info == frameInfo_.end())\n+\t\treturn nullptr;\n+\treturn &info->second;\n+}\n+\n+SimpleFrameInfo *SimpleFrames::find(Request *request)\n+{\n+\tfor (auto &itInfo : frameInfo_) {\n+\t\tSimpleFrameInfo *info = &itInfo.second;\n+\n+\t\tif (info->request == request)\n+\t\t\treturn info;\n+\t}\n+\n+\treturn nullptr;\n+}\n+\n struct SimplePipelineInfo {\n \tconst char *driver;\n \t/*\n@@ -293,11 +351,13 @@ public:\n \n \tstd::unique_ptr converter_;\n \tstd::unique_ptr swIsp_;\n+\tSimpleFrames frameInfo_;\n \n private:\n \tvoid tryPipeline(unsigned int code, const Size &size);\n \tstatic std::vector routedSourcePads(MediaPad *sink);\n \n+\tvoid completeRequest(Request *request);\n \tvoid conversionInputDone(FrameBuffer *buffer);\n \tvoid conversionOutputDone(FrameBuffer *buffer);\n \n@@ -799,7 +859,7 @@ void SimpleCameraData::imageBufferReady(FrameBuffer *buffer)\n \t\t\t/* No conversion, just complete the request. */\n \t\t\tRequest *request = buffer->request();\n \t\t\tpipe->completeBuffer(request, buffer);\n-\t\t\tpipe->completeRequest(request);\n+\t\t\tcompleteRequest(request);\n \t\t\treturn;\n \t\t}\n \n@@ -817,7 +877,7 @@ void SimpleCameraData::imageBufferReady(FrameBuffer *buffer)\n \t\tconst RequestOutputs &outputs = conversionQueue_.front();\n \t\tfor (auto &[stream, buf] : outputs.outputs)\n \t\t\tpipe->completeBuffer(outputs.request, buf);\n-\t\tpipe->completeRequest(outputs.request);\n+\t\tcompleteRequest(outputs.request);\n \t\tconversionQueue_.pop();\n \n \t\treturn;\n@@ -875,7 +935,7 @@ void SimpleCameraData::imageBufferReady(FrameBuffer *buffer)\n \n \t/* Otherwise simply complete the request. */\n \tpipe->completeBuffer(request, buffer);\n-\tpipe->completeRequest(request);\n+\tcompleteRequest(request);\n }\n \n void SimpleCameraData::clearIncompleteRequests()\n@@ -886,6 +946,18 @@ void SimpleCameraData::clearIncompleteRequests()\n \t}\n }\n \n+void SimpleCameraData::completeRequest(Request *request)\n+{\n+\tSimpleFrameInfo *info = frameInfo_.find(request);\n+\tif (!info) {\n+\t\t/* Something is really wrong, let's return. */\n+\t\treturn;\n+\t}\n+\n+\tframeInfo_.destroy(info->frame);\n+\tpipe()->completeRequest(request);\n+}\n+\n void SimpleCameraData::conversionInputDone(FrameBuffer *buffer)\n {\n \t/* Queue the input buffer back for capture. */\n@@ -899,7 +971,7 @@ void SimpleCameraData::conversionOutputDone(FrameBuffer *buffer)\n \t/* Complete the buffer and the request. */\n \tRequest *request = buffer->request();\n \tif (pipe->completeBuffer(request, buffer))\n-\t\tpipe->completeRequest(request);\n+\t\tcompleteRequest(request);\n }\n \n void SimpleCameraData::ispStatsReady(uint32_t frame, uint32_t bufferId)\n@@ -1412,6 +1484,7 @@ void SimplePipelineHandler::stopDevice(Camera *camera)\n \n \tvideo->bufferReady.disconnect(data, &SimpleCameraData::imageBufferReady);\n \n+\tdata->frameInfo_.clear();\n \tdata->clearIncompleteRequests();\n \tdata->conversionBuffers_.clear();\n \n@@ -1442,8 +1515,10 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \n \tif (data->useConversion_) {\n \t\tdata->conversionQueue_.push({ request, std::move(buffers) });\n-\t\tif (data->swIsp_)\n+\t\tif (data->swIsp_) {\n+\t\t\tdata->frameInfo_.create(request);\n \t\t\tdata->swIsp_->queueRequest(request->sequence(), request->controls());\n+\t\t}\n \t}\n \n \treturn 0;\n","prefixes":["v4","1/6"]}