[{"id":33307,"web_url":"https://patchwork.libcamera.org/comment/33307/","msgid":"<3msobvtlnaacprxmf3zvafb6tioidcsu5mcffmxdvg7a2cfo37@ctslat5ow6av>","date":"2025-02-06T16:54:00","subject":"Re: [RFC PATCH v3 21/21] apps: lc-compliance: Rename\n\t`CaptureUnbalanced`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Thu, Jan 30, 2025 at 11:51:50AM +0000, Barnabás Pőcze wrote:\n> Rename the test to `StopWithRequestsQueued` for more clarity.\n>\n> Suggested-by: Jacopo Mondi \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/apps/lc-compliance/tests/capture_test.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\n> index db1d52fc9..39761f9b1 100644\n> --- a/src/apps/lc-compliance/tests/capture_test.cpp\n> +++ b/src/apps/lc-compliance/tests/capture_test.cpp\n> @@ -104,13 +104,13 @@ TEST_P(SimpleCapture, CaptureStartStop)\n> }\n>\n> /*\n> - * Test unbalanced stop\n> + * Test stop with queued requests\n> *\n> * Makes sure the camera supports a stop with requests queued. Example failure\n> * is a camera that does not handle cancelation of buffers coming back from the\n> * video device while stopping.\n> */\n> -TEST_P(SimpleCapture, UnbalancedStop)\n> +TEST_P(SimpleCapture, StopWithRequestsQueued)\n> {\n> \tconst auto &[roles, numRequests] = GetParam();\n>\n> --\n> 2.48.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF37CC32EF\n\tfor ;\n\tThu, 6 Feb 2025 16:54:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6E84685EB;\n\tThu, 6 Feb 2025 17:54:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27AE86053F\n\tfor ;\n\tThu, 6 Feb 2025 17:54:05 +0100 (CET)","from ideasonboard.com (mob-5-90-139-204.net.vodafone.it\n\t[5.90.139.204])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0780F11DA;\n\tThu, 6 Feb 2025 17:52:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U7/e4VbX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738860771;\n\tbh=wIK46hrJoE0OfmT2wwq3U+tMqJfrSzgywWc7T+7KQ4c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U7/e4VbXnT2aazHBhwpASt65TlR8MVlqCc3avz7PqDikW3CvvieKQoZrZCTZd4aOx\n\t9QlfygMDKICYKiAFB3bIEaQTI0Oj/Srkn9VavahgtnxMe4FUryPqf1Bhn2uslsAlph\n\t+Etm8VUrIdKrZjpkBKqt1c+NP3p+tkU7NRwF2/Qk=","Date":"Thu, 6 Feb 2025 17:54:00 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ","Subject":"Re: [RFC PATCH v3 21/21] apps: lc-compliance: Rename\n\t`CaptureUnbalanced`","Message-ID":"<3msobvtlnaacprxmf3zvafb6tioidcsu5mcffmxdvg7a2cfo37@ctslat5ow6av>","References":"<20250130115001.1129305-1-pobrn@protonmail.com>\n\t<20250130115001.1129305-22-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250130115001.1129305-22-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]