{"id":22676,"url":"https://patchwork.libcamera.org/api/patches/22676/?format=json","web_url":"https://patchwork.libcamera.org/patch/22676/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130115001.1129305-12-pobrn@protonmail.com>","date":"2025-01-30T11:50:55","name":"[RFC,v3,11/21] apps: lc-compliance: Remove redundant getter call","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e74b960ea8c6e8bd7d57d9ace6fd4c46cf247ba5","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22676/mbox/","series":[{"id":4978,"url":"https://patchwork.libcamera.org/api/series/4978/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4978","date":"2025-01-30T11:50:08","name":"apps: lc-compliance: Multi-stream tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4978/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22676/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22676/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99FF6BDB1C\n\tfor ;\n\tThu, 30 Jan 2025 11:51:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B93468580;\n\tThu, 30 Jan 2025 12:51:44 +0100 (CET)","from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FE366856A\n\tfor ;\n\tThu, 30 Jan 2025 12:51:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"mRcu+YI3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237901; x=1738497101;\n\tbh=6LZdqGHRubU4bkTEAjaYF73miEfHhdYWLPMaF/agJSE=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=mRcu+YI3XD9eLmJ+qUYGvUObuDJ7AYThWK4AGH8r5WumCNjSUXHqnZG3Zgn4fZd2D\n\tkPvCCkqI76x3AA/d+n7d3GRcThjCM5t88uMx1JVNXGHOJffFyZMYr7WuCFRXu+O5wZ\n\t3Xdz7zV9SmJ5A10e/lhbSSYUuDkZSnWniLyDQj2PfCOfC6XX+h8XMoubgDT9uDJ393\n\tuVqAlnn5JnL2+5guuaZrkdw9Y/5TKFZTs9Z4I0n39y+L1dBpC/WYj/thZABnNzc6zt\n\t97X/yDXCqp8y02+KORsupDnUtvj6vxpzsTiXiulvBoaju0bgMnkR26xDv36ESLhmET\n\tgnD+yPZfid75Q==","Date":"Thu, 30 Jan 2025 11:50:55 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[RFC PATCH v3 11/21] apps: lc-compliance: Remove redundant getter\n\tcall","Message-ID":"<20250130115001.1129305-12-pobrn@protonmail.com>","In-Reply-To":"<20250130115001.1129305-1-pobrn@protonmail.com>","References":"<20250130115001.1129305-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"ce11d9b09d9fa4ef351a0ed915bcc1cda73b571d","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Smart pointers overload `operator->()`, no reason to use `get()`.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n---\n src/apps/lc-compliance/main.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp\nindex 98f2573d0..cdd0bd515 100644\n--- a/src/apps/lc-compliance/main.cpp\n+++ b/src/apps/lc-compliance/main.cpp\n@@ -45,7 +45,7 @@ class ThrowListener : public testing::EmptyTestEventListener\n static void listCameras(CameraManager *cm)\n {\n \tfor (const std::shared_ptr &cam : cm->cameras())\n-\t\tstd::cout << \"- \" << cam.get()->id() << std::endl;\n+\t\tstd::cout << \"- \" << cam->id() << std::endl;\n }\n \n static int initCamera(CameraManager *cm, OptionsParser::Options options)\n","prefixes":["RFC","v3","11/21"]}