{"id":22672,"url":"https://patchwork.libcamera.org/api/patches/22672/?format=json","web_url":"https://patchwork.libcamera.org/patch/22672/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130115001.1129305-16-pobrn@protonmail.com>","date":"2025-01-30T11:51:16","name":"[RFC,v3,15/21] apps: lc-compliance: Add message to `GTEST_SKIP()`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5efb73bad5cf66522218ca8fd8648e8d27ea3887","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22672/mbox/","series":[{"id":4978,"url":"https://patchwork.libcamera.org/api/series/4978/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4978","date":"2025-01-30T11:50:08","name":"apps: lc-compliance: Multi-stream tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4978/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22672/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22672/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF96ABDB1C\n\tfor ;\n\tThu, 30 Jan 2025 11:51:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67B4B6856B;\n\tThu, 30 Jan 2025 12:51:23 +0100 (CET)","from mail-10631.protonmail.ch (mail-10631.protonmail.ch\n\t[79.135.106.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CC9F68567\n\tfor ;\n\tThu, 30 Jan 2025 12:51:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"CfDHkSCP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237881; x=1738497081;\n\tbh=DEbUidfSCnUI+HkVH6T6+a3fD4zi5Dum9YJRCtNXAks=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=CfDHkSCPLBVfiXgZISlu8egxBSblV9gDSv0OhVZnt1J1RQo+Sy8H9QWPOAuX15bLh\n\tflHOL2qx4MsjZyVvlwgXbqo6BEntH/zcJJeiQKbWw7psB9u9PhQZ7m3Rx53ibx5W/l\n\teQWLc+t539PX8FVmG1M2qf6n78pac+eqZDd7IKZMqbuuHx368qQXtEDsMneaRs++Io\n\tTSZFkFVdDa0YZkyAuV0OklLNwiIlXE0fap3dIg7+8jfWLBU6g0hehLLW5bRRcJFw7V\n\txSsaI8TafhYD30aKD8BWJQOIMNWiNHw6YuiS0sFl6clDyuhepdj9qPSOQA22vbqNL2\n\tn9zyfDge3ZiQw==","Date":"Thu, 30 Jan 2025 11:51:16 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[RFC PATCH v3 15/21] apps: lc-compliance: Add message to\n\t`GTEST_SKIP()`","Message-ID":"<20250130115001.1129305-16-pobrn@protonmail.com>","In-Reply-To":"<20250130115001.1129305-1-pobrn@protonmail.com>","References":"<20250130115001.1129305-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"238472c94445cd4844c5afd5464d7f1f0ec9bb7c","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Just like other gtest macros, `GTEST_SKIP()` returns an object\nto which a formatted message can be added using the usual `<<`\nstream operator. So use it instead of printing to `std::cout`.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n---\n src/apps/lc-compliance/helpers/capture.cpp | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex 91c4d4400..43db15d2d 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -26,10 +26,8 @@ void Capture::configure(StreamRole role)\n {\n \tconfig_ = camera_->generateConfiguration({ role });\n \n-\tif (!config_) {\n-\t\tstd::cout << \"Role not supported by camera\" << std::endl;\n-\t\tGTEST_SKIP();\n-\t}\n+\tif (!config_)\n+\t\tGTEST_SKIP() << \"Role not supported by camera\";\n \n \tif (config_->validate() != CameraConfiguration::Valid) {\n \t\tconfig_.reset();\n@@ -85,10 +83,8 @@ void CaptureBalanced::capture(unsigned int numRequests)\n \n \t/* No point in testing less requests then the camera depth. */\n \tif (buffers.size() > numRequests) {\n-\t\tstd::cout << \"Camera needs \" + std::to_string(buffers.size())\n-\t\t\t+ \" requests, can't test only \"\n-\t\t\t+ std::to_string(numRequests) << std::endl;\n-\t\tGTEST_SKIP();\n+\t\tGTEST_SKIP() << \"Camera needs \" << buffers.size()\n+\t\t\t << \" requests, can't test only \" << numRequests;\n \t}\n \n \tqueueCount_ = 0;\n","prefixes":["RFC","v3","15/21"]}