{"id":22668,"url":"https://patchwork.libcamera.org/api/patches/22668/?format=json","web_url":"https://patchwork.libcamera.org/patch/22668/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130115001.1129305-11-pobrn@protonmail.com>","date":"2025-01-30T11:50:49","name":"[RFC,v3,10/21] apps: lc-compliance: Optimize `std::shared_ptr` usage","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0c4929949797691510310e2c118dc54175493afb","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22668/mbox/","series":[{"id":4978,"url":"https://patchwork.libcamera.org/api/series/4978/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4978","date":"2025-01-30T11:50:08","name":"apps: lc-compliance: Multi-stream tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4978/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22668/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22668/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0DF3BDB1C\n\tfor ;\n\tThu, 30 Jan 2025 11:50:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C00168574;\n\tThu, 30 Jan 2025 12:50:56 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A319068567\n\tfor ;\n\tThu, 30 Jan 2025 12:50:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"YxYFhTKv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237854; x=1738497054;\n\tbh=EmlKr/K5pA9A3sAhwLBPYk63SFj8WerfxfMelmGXeaI=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=YxYFhTKv1KW7xGSNZ91BCL/8pUFsHtfuJC/ZrKjbk+muR6K0hM0/O84vcEzD6GNdx\n\tFc7lwaWvanwG1IE4l14/gqA0+S8AYUM6OjULySW4XdXGnVrdySfy1wqMLAjlL+OJU6\n\tVbZZe+Gobuay4BtLUUrL/WinuN4jb27NyNydpOKkGmGKfIWOyZ570RVwRaC0a79lZU\n\tiqtD8Ec1BfHMbBCFgmuG1qG2HEF0X6hMNg4NBWv4t+gAIlM9yoo87SryvvTjaEhDa9\n\tAiz3AWeSlaYasQYBZDoHPbec7f1TVJ8wrXnyfl4pLhz5T+9dwycNzi6c+gD67IftoT\n\tsuetaBXUNkWSg==","Date":"Thu, 30 Jan 2025 11:50:49 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Laurent Pinchart ,\n\tPaul Elder ","Subject":"[RFC PATCH v3 10/21] apps: lc-compliance: Optimize `std::shared_ptr`\n\tusage","Message-ID":"<20250130115001.1129305-11-pobrn@protonmail.com>","In-Reply-To":"<20250130115001.1129305-1-pobrn@protonmail.com>","References":"<20250130115001.1129305-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"583ed973c0106fb0230165f604a8bf3504032a01","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Avoid unnecessary copies and try to move construct `std::shared_ptr`\nwhenever possible.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n---\n src/apps/lc-compliance/helpers/capture.cpp | 8 ++++----\n src/apps/lc-compliance/main.cpp | 4 +---\n 2 files changed, 5 insertions(+), 7 deletions(-)","diff":"diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex 90c1530ba..d1dafb6cf 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -12,8 +12,8 @@\n using namespace libcamera;\n \n Capture::Capture(std::shared_ptr camera)\n-\t: loop_(nullptr), camera_(camera),\n-\t allocator_(std::make_unique(camera))\n+\t: loop_(nullptr), camera_(std::move(camera)),\n+\t allocator_(std::make_unique(camera_))\n {\n }\n \n@@ -72,7 +72,7 @@ void Capture::stop()\n /* CaptureBalanced */\n \n CaptureBalanced::CaptureBalanced(std::shared_ptr camera)\n-\t: Capture(camera)\n+\t: Capture(std::move(camera))\n {\n }\n \n@@ -144,7 +144,7 @@ void CaptureBalanced::requestComplete(Request *request)\n /* CaptureUnbalanced */\n \n CaptureUnbalanced::CaptureUnbalanced(std::shared_ptr camera)\n-\t: Capture(camera)\n+\t: Capture(std::move(camera))\n {\n }\n \ndiff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp\nindex 3f1d2a61b..98f2573d0 100644\n--- a/src/apps/lc-compliance/main.cpp\n+++ b/src/apps/lc-compliance/main.cpp\n@@ -50,8 +50,6 @@ static void listCameras(CameraManager *cm)\n \n static int initCamera(CameraManager *cm, OptionsParser::Options options)\n {\n-\tstd::shared_ptr camera;\n-\n \tint ret = cm->start();\n \tif (ret) {\n \t\tstd::cout << \"Failed to start camera manager: \"\n@@ -66,7 +64,7 @@ static int initCamera(CameraManager *cm, OptionsParser::Options options)\n \t}\n \n \tconst std::string &cameraId = options[OptCamera];\n-\tcamera = cm->get(cameraId);\n+\tstd::shared_ptr camera = cm->get(cameraId);\n \tif (!camera) {\n \t\tstd::cout << \"Camera \" << cameraId << \" not found, available cameras:\" << std::endl;\n \t\tlistCameras(cm);\n","prefixes":["RFC","v3","10/21"]}