{"id":22667,"url":"https://patchwork.libcamera.org/api/patches/22667/?format=json","web_url":"https://patchwork.libcamera.org/patch/22667/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250130115001.1129305-10-pobrn@protonmail.com>","date":"2025-01-30T11:50:45","name":"[RFC,v3,09/21] apps: lc-compliance: Put tests into anonymous namespace","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4d9647de8cb417422e3beacc1d4edb64648b8948","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22667/mbox/","series":[{"id":4978,"url":"https://patchwork.libcamera.org/api/series/4978/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4978","date":"2025-01-30T11:50:08","name":"apps: lc-compliance: Multi-stream tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4978/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22667/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22667/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2A82BDB1C\n\tfor ;\n\tThu, 30 Jan 2025 11:50:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BE0C68577;\n\tThu, 30 Jan 2025 12:50:51 +0100 (CET)","from mail-10629.protonmail.ch (mail-10629.protonmail.ch\n\t[79.135.106.29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D37868567\n\tfor ;\n\tThu, 30 Jan 2025 12:50:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"I9KlM9SK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237848; x=1738497048;\n\tbh=lsg7THwC1Sxs3MJW1yLsvHg6gnUUKyaAWT1fLdPFGbE=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=I9KlM9SKrm9zGhhMNspN0ooKkSYiz3jl6nhwTqcKL4CZXZqXle4XyyjWmfkACb+Cw\n\tTo5ACyCig3I83rH8cbIRtWTRMV7vLkzjWYVSGWubMZim5xrMBOE9oIDAFxzH7EQm/n\n\tuL2MPrLJv4rqUwAof4yu8ZugzoY5B44TV2HNQZ8076pxBnBko212WIPiRONFYg5A5k\n\t5QeOQO4SfY1ybz/ypVP8ivpbXfRZn308uw9TYZ9XUslLSG6V8RuimXgwNT55/2nz2S\n\tklpE1px37PuCYV95t+n+5xzW6fo+U8T9Hctp7jL634nsg7wdiPhHVHGEJnMMgXT+U9\n\tk95oBy5Jfygsw==","Date":"Thu, 30 Jan 2025 11:50:45 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[RFC PATCH v3 09/21] apps: lc-compliance: Put tests into anonymous\n\tnamespace","Message-ID":"<20250130115001.1129305-10-pobrn@protonmail.com>","In-Reply-To":"<20250130115001.1129305-1-pobrn@protonmail.com>","References":"<20250130115001.1129305-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"7d69735555ab37ac48f52fd61accfac49209c178","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no reason for these symbols to be global.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n---\n src/apps/lc-compliance/tests/capture_test.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp\nindex ad3a1da2f..db196a949 100644\n--- a/src/apps/lc-compliance/tests/capture_test.cpp\n+++ b/src/apps/lc-compliance/tests/capture_test.cpp\n@@ -14,6 +14,8 @@\n \n #include \"environment.h\"\n \n+namespace {\n+\n using namespace libcamera;\n \n const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n@@ -134,3 +136,5 @@ INSTANTIATE_TEST_SUITE_P(CaptureTests,\n \t\t\t testing::Combine(testing::ValuesIn(ROLES),\n \t\t\t\t\t testing::ValuesIn(NUMREQUESTS)),\n \t\t\t SingleStream::nameParameters);\n+\n+} /* namespace */\n","prefixes":["RFC","v3","09/21"]}