[{"id":3073,"web_url":"https://patchwork.libcamera.org/comment/3073/","msgid":"<20191118191803.GH4888@pendragon.ideasonboard.com>","date":"2019-11-18T19:18:03","subject":"Re: [libcamera-devel] [RFC 05/12] libcamera: buffer: Remove request\n\ttracking","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:25:18AM +0100, Niklas Söderlund wrote:\n> It's no longer needed to track which request the application provided\n> buffer belongs to, drop the helpers for this.\n> \n> Signed-off-by: Niklas Söderlund \n\nSame concern as for 05/12, and\n\nReviewed-by: Laurent Pinchart \n\nfor the same reason, still with lots of doubts.\n\n> ---\n> include/libcamera/buffer.h | 4 ----\n> src/libcamera/buffer.cpp | 3 +--\n> src/libcamera/request.cpp | 3 ---\n> 3 files changed, 1 insertion(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index c349b995e1eb35ee..54c757ef7db8b5f6 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -83,7 +83,6 @@ public:\n> \tunsigned int sequence() const { return sequence_; }\n> \n> \tStatus status() const { return status_; }\n> -\tRequest *request() const { return request_; }\n> \tStream *stream() const { return stream_; }\n> \n> private:\n> @@ -94,8 +93,6 @@ private:\n> \n> \tvoid cancel();\n> \n> -\tvoid setRequest(Request *request) { request_ = request; }\n> -\n> \tunsigned int index_;\n> \tstd::array dmabuf_;\n> \tBufferMemory *mem_;\n> @@ -105,7 +102,6 @@ private:\n> \tunsigned int sequence_;\n> \n> \tStatus status_;\n> -\tRequest *request_;\n> \tStream *stream_;\n> };\n> \n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index 4407201bd81c368d..10b16a862393b536 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -270,8 +270,7 @@ void BufferPool::destroyBuffers()\n> */\n> Buffer::Buffer(unsigned int index, const Buffer *metadata)\n> \t: index_(index), dmabuf_({ -1, -1, -1 }),\n> -\t status_(Buffer::BufferSuccess), request_(nullptr),\n> -\t stream_(nullptr)\n> +\t status_(Buffer::BufferSuccess), stream_(nullptr)\n> {\n> \tif (metadata) {\n> \t\tbytesused_ = metadata->bytesused_;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index c14ed1a4d3ce55d0..a9468ed4b0512a7f 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -220,7 +220,6 @@ int Request::prepare()\n> \n> \tfor (auto const &pair : bufferMap_) {\n> \t\tBuffer *buffer = pair.second;\n> -\t\tbuffer->setRequest(this);\n> \t\tpending_.insert(buffer);\n> \t}\n> \n> @@ -258,8 +257,6 @@ bool Request::completeBuffer(Buffer *buffer)\n> \tint ret = pending_.erase(buffer);\n> \tASSERT(ret == 1);\n> \n> -\tbuffer->setRequest(nullptr);\n> -\n> \tif (buffer->status() == Buffer::BufferCancelled)\n> \t\tcancelled_ = true;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AD5160F1C\n\tfor ;\n\tMon, 18 Nov 2019 20:18:19 +0100 (CET)","from pendragon.ideasonboard.com (unknown [38.98.37.142])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D469540;\n\tMon, 18 Nov 2019 20:18:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574104699;\n\tbh=DATp4mngW3LFD1Rw/ktM+igMaEfNEDmDexwb3k8cmb8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZYNqA6v1IbYee4FGamjgdA3/bcJN+O8/65j1dTpmAERpH8a67zFiXzdYAykFydUc1\n\tDGwfwxW/sUEDnIri4Yzq9xaEIA7LV2YTCtwBdZiC2ML3ulhLJmIEVWJsdKBB/UZIUU\n\tgnDqtzsosCAmWxOuGPY1eKtDw3dP+Tyv/CFwA2k8=","Date":"Mon, 18 Nov 2019 21:18:03 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118191803.GH4888@pendragon.ideasonboard.com>","References":"<20191028022525.796995-1-niklas.soderlund@ragnatech.se>\n\t<20191028022525.796995-6-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022525.796995-6-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 05/12] libcamera: buffer: Remove request\n\ttracking","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 19:18:19 -0000"}}]