[{"id":33232,"web_url":"https://patchwork.libcamera.org/comment/33232/","msgid":"<173822787340.1773152.12857012955768884574@ping.linuxembedded.co.uk>","date":"2025-01-30T09:04:33","subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-01-30 07:47:15)\n> The mentioned commit mistakenly introduced a new variable for storing\n> the camera instead of just assigining to the global variable defined\n> earlier in the tutorial. Fix that by making it an assignment.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=252\n> Fixes: e77a2751100e38 (\"treewide: Query list of cameras just once\")\n> Signed-off-by: Barnabás Pőcze \n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 67f5bd7e7..297586a1c 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -128,7 +128,7 @@ available.\n> \n> std::string cameraId = cameras[0]->id();\n> \n> - auto camera = cm->get(cameraId);\n> + camera = cm->get(cameraId);\n\nI always thought we should be providing a request->camera() helper to\nreturn the associated camera with a request to make this easier for\napplciations but it didn't seem to get any traction when I posted this: \n\n https://patchwork.libcamera.org/patch/9328/\n\nSo for this patch indeed this stops the aliased variable.\n\n\nReviewed-by: Kieran Bingham \n\n\n> /*\n> * Note that `camera` may not compare equal to `cameras[0]`.\n> * In fact, it might simply be a `nullptr`, as the particular\n> -- \n> 2.48.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A17EBBD808\n\tfor ;\n\tThu, 30 Jan 2025 09:04:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95B0B68563;\n\tThu, 30 Jan 2025 10:04:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 607C161876\n\tfor ;\n\tThu, 30 Jan 2025 10:04:36 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD366886;\n\tThu, 30 Jan 2025 10:03:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rXSdVLpm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738227807;\n\tbh=EPVv+hB/MHpCIRFORLbritYiSm/VpkBGe+4oXTCGa74=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=rXSdVLpm3WsTEMihG3trLI7XFpmqtvxHY4UgsSGMUhNAQu0topzXpBD6X+GQPzZAw\n\tfpduk+T3sS6Dx/+eIbjiBvFCI/7G22UDayOSAywEW+d+lKDN2PqqNcbgViD2H5AV/l\n\tkd0qNUIEGg0NN4RRLTClGy168pVfwAzJmlc0KNJQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250130074712.959046-1-pobrn@protonmail.com>","References":"<20250130074712.959046-1-pobrn@protonmail.com>","Subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 30 Jan 2025 09:04:33 +0000","Message-ID":"<173822787340.1773152.12857012955768884574@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33233,"web_url":"https://patchwork.libcamera.org/comment/33233/","msgid":"","date":"2025-01-30T10:37:22","subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2025. január 30., csütörtök 10:04 keltezéssel, Kieran Bingham írta:\n\n> Quoting Barnabás Pőcze (2025-01-30 07:47:15)\n> > The mentioned commit mistakenly introduced a new variable for storing\n> > the camera instead of just assigining to the global variable defined\n> > earlier in the tutorial. Fix that by making it an assignment.\n> >\n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=252\n> > Fixes: e77a2751100e38 (\"treewide: Query list of cameras just once\")\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > Documentation/guides/application-developer.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > index 67f5bd7e7..297586a1c 100644\n> > --- a/Documentation/guides/application-developer.rst\n> > +++ b/Documentation/guides/application-developer.rst\n> > @@ -128,7 +128,7 @@ available.\n> >\n> > std::string cameraId = cameras[0]->id();\n> >\n> > - auto camera = cm->get(cameraId);\n> > + camera = cm->get(cameraId);\n> \n> I always thought we should be providing a request->camera() helper to\n> return the associated camera with a request to make this easier for\n> applciations but it didn't seem to get any traction when I posted this:\n> \n> https://patchwork.libcamera.org/patch/9328/\n\nI see the camera pointer has been moved to `Request::Private`, but I think\nthis still seems like a good idea. Although I have no idea what the mentioned\nplans with `Request` were.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> So for this patch indeed this stops the aliased variable.\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> > /*\n> > * Note that `camera` may not compare equal to `cameras[0]`.\n> > * In fact, it might simply be a `nullptr`, as the particular\n> > --\n> > 2.48.1\n> >\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E239EBDB1C\n\tfor ;\n\tThu, 30 Jan 2025 10:37:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C2DC68563;\n\tThu, 30 Jan 2025 11:37:29 +0100 (CET)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F47E61876\n\tfor ;\n\tThu, 30 Jan 2025 11:37:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"MGjOs5TS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738233446; x=1738492646;\n\tbh=odxmDPdHWO+t/vDFuIdGALf4Tg6mNn/MAL9r0toX8Kw=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=MGjOs5TSOCpfAnQQbkl8cPsJggnHRmtOgHRZr+g3l2QWXPFV3v7803R4gejz5xFUV\n\t6qvNw2HOIa2EoINIxATg4rjPKsR+qM8u3msNaeGkSkxo1pFabAaKeIVycAMarF/63A\n\tvNTHPaEGbd9ghrkOJn7eHW7AS+9HEcT0B0p0JVa1obSSyeZZTOFBjcJ9T5LjfQ9ux8\n\tKYsWejoEnphBneWCi08h+HrfplUyYbYvHYWNJVDBmCisnjiX8ITXWTeHu1E93+CVpR\n\tX4TlcY01pFgAY7PFe1iB3M7Ae4wYCgckx12S6lSj8pwAbepbcM4p+vtCI1bxjcg0Q1\n\tvUJWn9vouiq7Q==","Date":"Thu, 30 Jan 2025 10:37:22 +0000","To":"Kieran Bingham ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","Message-ID":"","In-Reply-To":"<173822787340.1773152.12857012955768884574@ping.linuxembedded.co.uk>","References":"<20250130074712.959046-1-pobrn@protonmail.com>\n\t<173822787340.1773152.12857012955768884574@ping.linuxembedded.co.uk>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"54e2c5cd11c2484d9da19a9c99ec1c04ab15fb9c","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33238,"web_url":"https://patchwork.libcamera.org/comment/33238/","msgid":"<173824234649.1368758.13962383155084051060@ping.linuxembedded.co.uk>","date":"2025-01-30T13:05:46","subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-01-30 10:37:22)\n> 2025. január 30., csütörtök 10:04 keltezéssel, Kieran Bingham írta:\n> \n> > Quoting Barnabás Pőcze (2025-01-30 07:47:15)\n> > > The mentioned commit mistakenly introduced a new variable for storing\n> > > the camera instead of just assigining to the global variable defined\n> > > earlier in the tutorial. Fix that by making it an assignment.\n> > >\n> > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=252\n> > > Fixes: e77a2751100e38 (\"treewide: Query list of cameras just once\")\n> > > Signed-off-by: Barnabás Pőcze \n> > > ---\n> > > Documentation/guides/application-developer.rst | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> > > index 67f5bd7e7..297586a1c 100644\n> > > --- a/Documentation/guides/application-developer.rst\n> > > +++ b/Documentation/guides/application-developer.rst\n> > > @@ -128,7 +128,7 @@ available.\n> > >\n> > > std::string cameraId = cameras[0]->id();\n> > >\n> > > - auto camera = cm->get(cameraId);\n> > > + camera = cm->get(cameraId);\n> > \n> > I always thought we should be providing a request->camera() helper to\n> > return the associated camera with a request to make this easier for\n> > applciations but it didn't seem to get any traction when I posted this:\n> > \n> > https://patchwork.libcamera.org/patch/9328/\n> \n> I see the camera pointer has been moved to `Request::Private`, but I think\n> this still seems like a good idea. Although I have no idea what the mentioned\n> plans with `Request` were.\n\nI don't know what the resistance context was either, but I still think\nit seems like a useful way to access the camera in the async delivery\nespecially as the camera is already stored /in/ the request and is\nguaranteed to be correctly associated.\n\nMaybe it's worth refreshing the patch to see.\n\n--\nKieran\n\n> \n> Regards,\n> Barnabás Pőcze\n> \n> > \n> > So for this patch indeed this stops the aliased variable.\n> > \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > \n> > > /*\n> > > * Note that `camera` may not compare equal to `cameras[0]`.\n> > > * In fact, it might simply be a `nullptr`, as the particular\n> > > --\n> > > 2.48.1\n> > >\n> > >\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4561AC324C\n\tfor ;\n\tThu, 30 Jan 2025 13:05:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E4946851B;\n\tThu, 30 Jan 2025 14:05:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAD9B6034C\n\tfor ;\n\tThu, 30 Jan 2025 14:05:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39228886;\n\tThu, 30 Jan 2025 14:04:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fhPy/mpl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738242280;\n\tbh=JSPNNu73zfyUZ5PXaWYdZMSfZ4woIwF2jHM5VbfBkLM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fhPy/mplUeLEHe1YiMztVljdDrq1RuwLwubgoPbL4xtfm4uXHJhTNDvkSxLXDeiCT\n\tEmBbDn43yOQUn4cPqWPvvtq/wq42UcNITrx4LyUJfoJTlG7WYP6CYcJuxJ4OR0A6qU\n\tY6PcToEr3IR4ydijpcLMIfWEBgAmzmtG/J7uoChQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250130074712.959046-1-pobrn@protonmail.com>\n\t<173822787340.1773152.12857012955768884574@ping.linuxembedded.co.uk>\n\t","Subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Date":"Thu, 30 Jan 2025 13:05:46 +0000","Message-ID":"<173824234649.1368758.13962383155084051060@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33240,"web_url":"https://patchwork.libcamera.org/comment/33240/","msgid":"<20250130145531.GE20611@pendragon.ideasonboard.com>","date":"2025-01-30T14:55:31","subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Thu, Jan 30, 2025 at 07:47:15AM +0000, Barnabás Pőcze wrote:\n> The mentioned commit mistakenly introduced a new variable for storing\n> the camera instead of just assigining to the global variable defined\n> earlier in the tutorial. Fix that by making it an assignment.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=252\n> Fixes: e77a2751100e38 (\"treewide: Query list of cameras just once\")\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/guides/application-developer.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index 67f5bd7e7..297586a1c 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -128,7 +128,7 @@ available.\n> \n> std::string cameraId = cameras[0]->id();\n> \n> - auto camera = cm->get(cameraId);\n> + camera = cm->get(cameraId);\n> /*\n> * Note that `camera` may not compare equal to `cameras[0]`.\n> * In fact, it might simply be a `nullptr`, as the particular","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 085A5BD808\n\tfor ;\n\tThu, 30 Jan 2025 14:55:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 556B768563;\n\tThu, 30 Jan 2025 15:55:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFDBF6034C\n\tfor ;\n\tThu, 30 Jan 2025 15:55:33 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13757886;\n\tThu, 30 Jan 2025 15:54:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kGPAO8YC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738248865;\n\tbh=dlswaOMmRoeI9kZt7ebLpgaSWVS7i/Kgyws/gboos/A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kGPAO8YCxMfBAQ9LaLdw5EV5QA6GfwCPiuam8CMMOBjfpPi/wdf5kvlfhw2ErKAoU\n\tcko2dkwToCIZ745U/1sy4xsTK/LzkLaJyJ7/tot2P+ZDV6IGDOoI2GYrPkk2or/YJV\n\tqTFgccTtVmkjAXjCzSTAD0iq9Ln9Tt+iGSh/U6OU=","Date":"Thu, 30 Jan 2025 16:55:31 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] Documentation: guides: application-developer: Fix\n\tvariable shadowing","Message-ID":"<20250130145531.GE20611@pendragon.ideasonboard.com>","References":"<20250130074712.959046-1-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250130074712.959046-1-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]