[{"id":33173,"web_url":"https://patchwork.libcamera.org/comment/33173/","msgid":"<20250125201425.GG1805@pendragon.ideasonboard.com>","date":"2025-01-25T20:14:25","subject":"Re: [RFC PATCH v2 12/13] apps: ppm_writer: Return EIO on I/O errors","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Jan 24, 2025 at 10:58:03PM +0100, Milan Zamazal wrote:\n> EINVAL should be returned only when the requested format is unsupported.\n> On errors when writing the data, let's return EIO, which is the closest\n> description of the situation when we don't inspect it more.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/common/ppm_writer.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/apps/common/ppm_writer.cpp b/src/apps/common/ppm_writer.cpp\n> index 2e9378aa..368de8bf 100644\n> --- a/src/apps/common/ppm_writer.cpp\n> +++ b/src/apps/common/ppm_writer.cpp\n> @@ -29,7 +29,7 @@ int PPMWriter::write(const char *filename,\n> \tstd::ofstream output(filename, std::ios::binary);\n> \tif (!output) {\n> \t\tstd::cerr << \"Failed to open ppm file: \" << filename << std::endl;\n> -\t\treturn -EINVAL;\n> +\t\treturn -EIO;\n> \t}\n> \n> \toutput << \"P6\" << std::endl\n> @@ -37,7 +37,7 @@ int PPMWriter::write(const char *filename,\n> \t << \"255\" << std::endl;\n> \tif (!output) {\n> \t\tstd::cerr << \"Failed to write the file header\" << std::endl;\n> -\t\treturn -EINVAL;\n> +\t\treturn -EIO;\n> \t}\n> \n> \tconst unsigned int rowLength = config.size.width * 3;\n> @@ -46,7 +46,7 @@ int PPMWriter::write(const char *filename,\n> \t\toutput.write(row, rowLength);\n> \t\tif (!output) {\n> \t\t\tstd::cerr << \"Failed to write image data at row \" << y << std::endl;\n> -\t\t\treturn -EINVAL;\n> +\t\t\treturn -EIO;\n> \t\t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39AB7BE175\n\tfor ;\n\tSat, 25 Jan 2025 20:14:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C85A66855D;\n\tSat, 25 Jan 2025 21:14:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A7746187B\n\tfor ;\n\tSat, 25 Jan 2025 21:14:36 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3E48352;\n\tSat, 25 Jan 2025 21:13:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eHPJgX+n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737836010;\n\tbh=681eRMaCDRqMJlRqWOj/FKU91i3WXgJVoCwNxVqwEQg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eHPJgX+n4Vk2DCOYzzAoDRwhtE77WcPoZPwUxBt2AD34Fh+cy0C6O5zBMa12/PFTl\n\tYBhK5h67p8rdbQKsXuk2Z3R4xKyeZirtd5APZZgKgku1ZBPDwr8Vpi5j53Hp0X0dNo\n\ty4MBEpUgSb3fGT6ggeUx79aPSw/1NQI0xSXEDxfM=","Date":"Sat, 25 Jan 2025 22:14:25 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 12/13] apps: ppm_writer: Return EIO on I/O errors","Message-ID":"<20250125201425.GG1805@pendragon.ideasonboard.com>","References":"<20250124215806.158024-1-mzamazal@redhat.com>\n\t<20250124215806.158024-13-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250124215806.158024-13-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]