[{"id":33172,"web_url":"https://patchwork.libcamera.org/comment/33172/","msgid":"<20250125201239.GF1805@pendragon.ideasonboard.com>","date":"2025-01-25T20:12:39","subject":"Re: [RFC PATCH v2 11/13] apps: ppm_writer: Add a missing include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Jan 24, 2025 at 10:58:02PM +0100, Milan Zamazal wrote:\n> should be included in the ppm writer, as the source of the\n> error code constants used there.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/apps/common/ppm_writer.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/apps/common/ppm_writer.cpp b/src/apps/common/ppm_writer.cpp\n> index d6c8641d..2e9378aa 100644\n> --- a/src/apps/common/ppm_writer.cpp\n> +++ b/src/apps/common/ppm_writer.cpp\n> @@ -7,6 +7,7 @@\n> \n> #include \"ppm_writer.h\"\n> \n> +#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90878BE175\n\tfor ;\n\tSat, 25 Jan 2025 20:12:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64EB06855D;\n\tSat, 25 Jan 2025 21:12:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA9EB6187B\n\tfor ;\n\tSat, 25 Jan 2025 21:12:50 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C744352;\n\tSat, 25 Jan 2025 21:11:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sks/+gSH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737835905;\n\tbh=cuak0YpGRsFbUTK7dwDWUH2sXPNGNO5j20kPiSs1Vfc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Sks/+gSHP9QH2hxL0J7XqGeCvB0BHuHjLnUsLGZKFjs8VtxoALUxHDB83E7s/nWLM\n\t+ZLD5y3D52GEv3v66i9NGX3GGD8NbR6SC/odtfgRFaBvOBeMbArwtlQJ8AOF89ne/e\n\tEuG+fdxgm4UKa2V3FiVZjAnn4eKmQs+F2YxuKKdc=","Date":"Sat, 25 Jan 2025 22:12:39 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 11/13] apps: ppm_writer: Add a missing include","Message-ID":"<20250125201239.GF1805@pendragon.ideasonboard.com>","References":"<20250124215806.158024-1-mzamazal@redhat.com>\n\t<20250124215806.158024-12-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250124215806.158024-12-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]