[{"id":33175,"web_url":"https://patchwork.libcamera.org/comment/33175/","msgid":"<20250125221301.GI1805@pendragon.ideasonboard.com>","date":"2025-01-25T22:13:01","subject":"Re: [RFC PATCH v2 01/13] libcamera: software_isp: Move a non-loop\n\tcondition out of the loop","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Jan 24, 2025 at 10:57:52PM +0100, Milan Zamazal wrote:\n> The check for the number of outputs is done in a loop over the outputs.\n> It should be moved out of the loop as it's not loop specific and is just\n> repeated there.\n> \n> This is a cosmetic change not changing any functionality.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/software_isp/software_isp.cpp | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 2bea64d9..67b27727 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -290,13 +290,12 @@ int SoftwareIsp::queueBuffers(uint32_t frame, FrameBuffer *input,\n> \t */\n> \tif (outputs.empty())\n> \t\treturn -EINVAL;\n\nWe could drop this condition, but I don't mind keeping it.\n\n> +\tif (outputs.size() != 1) /* only single stream atm */\n> +\t\treturn -EINVAL;\n\nWhile at it,\n\n\t/* We only support a single stream for now. */\n\tif (outputs.size() != 1)\n\t\treturn -EINVAL;\n\n> \n> -\tfor (auto [stream, buffer] : outputs) {\n> +\tfor (auto [stream, buffer] : outputs)\n> \t\tif (!buffer)\n> \t\t\treturn -EINVAL;\n> -\t\tif (outputs.size() != 1) /* only single stream atm */\n> -\t\t\treturn -EINVAL;\n> -\t}\n\nYou can keep the curly braces.\n\nReviewed-by: Laurent Pinchart \n\n> \n> \tfor (auto iter = outputs.begin(); iter != outputs.end(); iter++)\n> \t\tprocess(frame, input, iter->second);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6977BE175\n\tfor ;\n\tSat, 25 Jan 2025 22:13:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E74A6855D;\n\tSat, 25 Jan 2025 23:13:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7ECD6187B\n\tfor ;\n\tSat, 25 Jan 2025 23:13:11 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29B55670;\n\tSat, 25 Jan 2025 23:12:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"doubVKDt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737843126;\n\tbh=U20Dzg+bmbRTa0Xw29AXU358CHRXsf1d+zWZ32lI5X0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=doubVKDt4ZlGSG8ddfTVd3FKDZWniRKdaShUx2582WTqrxbppi6SCjIXCqzGsNf7D\n\tGnJ5/aH8TGdH2W/mVFubJFptUTOsdb6iCKawNXF2be8WHmpQMvZ9nJfaTIOgOc/xcB\n\te3EtSlGtVY2dEF/hsLcVHNemOYKp9qo4mhGM0PUI=","Date":"Sun, 26 Jan 2025 00:13:01 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 01/13] libcamera: software_isp: Move a non-loop\n\tcondition out of the loop","Message-ID":"<20250125221301.GI1805@pendragon.ideasonboard.com>","References":"<20250124215806.158024-1-mzamazal@redhat.com>\n\t<20250124215806.158024-2-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250124215806.158024-2-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]