{"id":22640,"url":"https://patchwork.libcamera.org/api/patches/22640/?format=json","web_url":"https://patchwork.libcamera.org/patch/22640/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250124215806.158024-2-mzamazal@redhat.com>","date":"2025-01-24T21:57:52","name":"[RFC,v2,01/13] libcamera: software_isp: Move a non-loop condition out of the loop","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8e9016e2c3f4f5a8682752e73a6b604d85630c76","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22640/mbox/","series":[{"id":4970,"url":"https://patchwork.libcamera.org/api/series/4970/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4970","date":"2025-01-24T21:57:51","name":"Enable raw streams with software ISP","version":2,"mbox":"https://patchwork.libcamera.org/series/4970/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22640/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22640/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31D75BD78E\n\tfor ;\n\tFri, 24 Jan 2025 21:58:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD7DD68561;\n\tFri, 24 Jan 2025 22:58:33 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8165568557\n\tfor ;\n\tFri, 24 Jan 2025 22:58:31 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-421-ycPVPeH4N7OK_8teTfPi5Q-1;\n\tFri, 24 Jan 2025 16:58:28 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 1DB7D19560B2 for ;\n\tFri, 24 Jan 2025 21:58:28 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id EAE69180035D; Fri, 24 Jan 2025 21:58:26 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"fs05nu2h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755910;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=TnlAtkDT63vSKs1/JVhFOfLW1cXnIYwGIT/DR9knAc4=;\n\tb=fs05nu2h+jTIxD2mJ8K9txxpd5IpF2YW9u+HbpalKggCFCwchd2MXESJBu/oGSEUzkeBJy\n\te0BadTZVY7VRU17oRVEY3KACSsg9NAwVjpTPayeqGKe6VTIjSLQ4JRMPl582zg1VYZ7riL\n\ts1Pd8dJNzqYnqJwfYBO7kCK5zSyY0yQ=","X-MC-Unique":"ycPVPeH4N7OK_8teTfPi5Q-1","X-Mimecast-MFC-AGG-ID":"ycPVPeH4N7OK_8teTfPi5Q","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[RFC PATCH v2 01/13] libcamera: software_isp: Move a non-loop\n\tcondition out of the loop","Date":"Fri, 24 Jan 2025 22:57:52 +0100","Message-ID":"<20250124215806.158024-2-mzamazal@redhat.com>","In-Reply-To":"<20250124215806.158024-1-mzamazal@redhat.com>","References":"<20250124215806.158024-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"aUqC2gOclA7y6Ft3Yai8mpv1xlcLOq946DFh1SzNDrY_1737755908","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The check for the number of outputs is done in a loop over the outputs.\nIt should be moved out of the loop as it's not loop specific and is just\nrepeated there.\n\nThis is a cosmetic change not changing any functionality.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/software_isp.cpp | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 2bea64d9..67b27727 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -290,13 +290,12 @@ int SoftwareIsp::queueBuffers(uint32_t frame, FrameBuffer *input,\n \t */\n \tif (outputs.empty())\n \t\treturn -EINVAL;\n+\tif (outputs.size() != 1) /* only single stream atm */\n+\t\treturn -EINVAL;\n \n-\tfor (auto [stream, buffer] : outputs) {\n+\tfor (auto [stream, buffer] : outputs)\n \t\tif (!buffer)\n \t\t\treturn -EINVAL;\n-\t\tif (outputs.size() != 1) /* only single stream atm */\n-\t\t\treturn -EINVAL;\n-\t}\n \n \tfor (auto iter = outputs.begin(); iter != outputs.end(); iter++)\n \t\tprocess(frame, input, iter->second);\n","prefixes":["RFC","v2","01/13"]}