[{"id":3072,"web_url":"https://patchwork.libcamera.org/comment/3072/","msgid":"<20191118191617.GG4888@pendragon.ideasonboard.com>","date":"2019-11-18T19:16:17","subject":"Re: [libcamera-devel] [RFC 04/12] libcamera: pipelines: Switch to\n\thelper to resolve request from buffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:25:17AM +0100, Niklas Söderlund wrote:\n> Use the pipeline helper instead of the soon to be removed request\n> recorded in the buffer.\n> \n> Signed-off-by: Niklas Söderlund \n\nAssuming we really need to remove the request pointer in the Buffer\nclass,\n\nReviewed-by: Laurent Pinchart \n\nas this patch is fine in itself, but I still have doubts.\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo.cpp | 2 +-\n> src/libcamera/pipeline/vimc.cpp | 2 +-\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index ff90b729e558c3a3..8aa5f34febf16585 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -948,7 +948,7 @@ void IPU3CameraData::imguInputBufferReady(Buffer *buffer)\n> */\n> void IPU3CameraData::imguOutputBufferReady(Buffer *buffer)\n> {\n> -\tRequest *request = buffer->request();\n> +\tRequest *request = requestFromBuffer(buffer);\n> \n> \tif (!pipe_->completeBuffer(camera_, request, buffer))\n> \t\t/* Request not completed yet, return here. */\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index cefdb54a06d440fb..0803572754364beb 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -991,7 +991,7 @@ void PipelineHandlerRkISP1::bufferReady(Buffer *buffer)\n> {\n> \tASSERT(activeCamera_);\n> \tRkISP1CameraData *data = cameraData(activeCamera_);\n> -\tRequest *request = buffer->request();\n> +\tRequest *request = data->requestFromBuffer(buffer);\n> \n> \tdata->timeline_.bufferReady(buffer);\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index 5aa6a8f9e0b2b7a4..679d82d38227b991 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -375,7 +375,7 @@ int UVCCameraData::init(MediaEntity *entity)\n> \n> void UVCCameraData::bufferReady(Buffer *buffer)\n> {\n> -\tRequest *request = buffer->request();\n> +\tRequest *request = requestFromBuffer(buffer);\n> \n> \tpipe_->completeBuffer(camera_, request, buffer);\n> \tpipe_->completeRequest(camera_, request);\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index 49b850cf0153020f..56898716a8cde074 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -460,7 +460,7 @@ int VimcCameraData::init(MediaDevice *media)\n> \n> void VimcCameraData::bufferReady(Buffer *buffer)\n> {\n> -\tRequest *request = buffer->request();\n> +\tRequest *request = requestFromBuffer(buffer);\n> \n> \tpipe_->completeBuffer(camera_, request, buffer);\n> \tpipe_->completeRequest(camera_, request);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7A1960F1C\n\tfor ;\n\tMon, 18 Nov 2019 20:16:39 +0100 (CET)","from pendragon.ideasonboard.com (unknown [38.98.37.142])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2098540;\n\tMon, 18 Nov 2019 20:16:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574104599;\n\tbh=S6+DS/VXQ7I+huPSZkXFn7cB87KNEL3bk9eQwhxG7EM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CDAo9zey6hQNoDnxiV6f3ZWxIPCpm24ZWsgg2DVwWDMFywDGz/rt5JFFlZ7JZqTzE\n\tLmtNGPq74Y6HrzPJqHTq4g6s8ftVSBHcCT7+Dg0drvMSf/tdJn793QeVXw3yE92u0E\n\to9VlTtbz/MBFaJ/+lnXGDmab9UhadpoYdrwJj+kA=","Date":"Mon, 18 Nov 2019 21:16:17 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118191617.GG4888@pendragon.ideasonboard.com>","References":"<20191028022525.796995-1-niklas.soderlund@ragnatech.se>\n\t<20191028022525.796995-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022525.796995-5-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 04/12] libcamera: pipelines: Switch to\n\thelper to resolve request from buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 19:16:40 -0000"}}]