{"id":22635,"url":"https://patchwork.libcamera.org/api/patches/22635/?format=json","web_url":"https://patchwork.libcamera.org/patch/22635/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250123140727.458567-2-dan.scally@ideasonboard.com>","date":"2025-01-23T14:07:25","name":"[v2,1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"592e961bb459a7ebc05673dec0e0bb147e4994de","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22635/mbox/","series":[{"id":4968,"url":"https://patchwork.libcamera.org/api/series/4968/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4968","date":"2025-01-23T14:07:24","name":"Add flicker mitigation controls to AgcMeanLuminance","version":2,"mbox":"https://patchwork.libcamera.org/series/4968/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22635/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22635/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59164BDE6B\n\tfor ;\n\tThu, 23 Jan 2025 14:07:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 799C468564;\n\tThu, 23 Jan 2025 15:07:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E047A61879\n\tfor ;\n\tThu, 23 Jan 2025 15:07:45 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11B15D1F;\n\tThu, 23 Jan 2025 15:06:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pwV60fLh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737641202;\n\tbh=+1sktMH3NyNzi9oYk3qIY3hescA5XHgRgeofWToMEyI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pwV60fLh/toelyfFEB271B4UuvB4WRRqXEE3w10tghVuevxtFpxYnZbIRQA2J4FdU\n\ttgwJQeVVMssMgL9Nt/7DuhWvTy/enk4HqA1eMpLOFkU5e4H8YO6U0UYSceQ/r41diM\n\tfzMMLQeU406BrO51HOmsnctNWb8Ed4EPoDjctwpw=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[PATCH v2 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function","Date":"Thu, 23 Jan 2025 14:07:25 +0000","Message-Id":"<20250123140727.458567-2-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20250123140727.458567-1-dan.scally@ideasonboard.com>","References":"<20250123140727.458567-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 IPA's AGC algorithm currently does not implement a\nqueueRequest() function. We will shortly need to use it, but to\navoid lots of noise in the future commit that adds a function call in\nto that function add it as a skeleton here.\n\nSigned-off-by: Daniel Scally \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n---\nChanges in v2:\n\n\t- None\n\n src/ipa/ipu3/algorithms/agc.cpp | 10 ++++++++++\n src/ipa/ipu3/algorithms/agc.h | 3 +++\n 2 files changed, 13 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 39d0aebb..383b046c 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -123,6 +123,16 @@ int Agc::configure(IPAContext &context,\n \treturn 0;\n }\n \n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::queueRequest\n+ */\n+void Agc::queueRequest([[maybe_unused]] typename Module::Context &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t [[maybe_unused]] typename Module::FrameContext &frameContext,\n+\t\t [[maybe_unused]] const ControlList &controls)\n+{\n+}\n+\n Histogram Agc::parseStatistics(const ipu3_uapi_stats_3a *stats,\n \t\t\t const ipu3_uapi_grid_config &grid)\n {\ndiff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\nindex 890c271b..c82b7acb 100644\n--- a/src/ipa/ipu3/algorithms/agc.h\n+++ b/src/ipa/ipu3/algorithms/agc.h\n@@ -32,6 +32,9 @@ public:\n \n \tint init(IPAContext &context, const YamlObject &tuningData) override;\n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n+\tvoid queueRequest(IPAContext &context, const uint32_t frame,\n+\t\t\t IPAFrameContext &frameContext,\n+\t\t\t const ControlList &controls) override;\n \tvoid process(IPAContext &context, const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t const ipu3_uapi_stats_3a *stats,\n","prefixes":["v2","1/3"]}