{"id":22631,"url":"https://patchwork.libcamera.org/api/patches/22631/?format=json","web_url":"https://patchwork.libcamera.org/patch/22631/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250123114204.79321-17-stefan.klug@ideasonboard.com>","date":"2025-01-23T11:41:06","name":"[v2,16/17] libipa: awb_bayes: Remove overly verbose log messages","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e1bc7e5da5fcc4de38c2d96b8acfc66fcbb57168","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22631/mbox/","series":[{"id":4966,"url":"https://patchwork.libcamera.org/api/series/4966/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4966","date":"2025-01-23T11:40:50","name":"Add Bayesian AWB algorithm to libipa and rkisp1","version":2,"mbox":"https://patchwork.libcamera.org/series/4966/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22631/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22631/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26335BDE6B\n\tfor ;\n\tThu, 23 Jan 2025 11:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C71026857D;\n\tThu, 23 Jan 2025 12:43:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D954168571\n\tfor ;\n\tThu, 23 Jan 2025 12:42:58 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c0a:33cd:b453:5d3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A8AB1189;\n\tThu, 23 Jan 2025 12:41:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p7MAE279\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737632515;\n\tbh=E3KIgkFPJeb67Axw3W6YCY98X3du1OG/vzDBhEKPFkU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=p7MAE279BNRf0xyVgwlAJ3zd7WKuX7x4XDb6XYfbvR7m6RZKQ7WgADggHLJ19nODF\n\tyBBOTiwiUOqcNHXcg5V8wBKRckEewxCWYMQm2PsycgwJlq3nORXC/URqkMxLHCc3bJ\n\tNQT5QXaNAJn1XCzVp1J3s7KI42JfdXdbe4CiXKTY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 16/17] libipa: awb_bayes: Remove overly verbose log\n\tmessages","Date":"Thu, 23 Jan 2025 12:41:06 +0100","Message-ID":"<20250123114204.79321-17-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20250123114204.79321-1-stefan.klug@ideasonboard.com>","References":"<20250123114204.79321-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Logging every search step is too verbose even with debug messages\nenabled and it hides the more important messages (min max values of\nerrors and likelihoods). Remove the debug messages in a separate commit,\nso that it can easily be reverted if needed.\n\nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v2:\n- Added this commit\n---\n src/ipa/libipa/awb_bayes.cpp | 13 -------------\n 1 file changed, 13 deletions(-)","diff":"diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp\nindex aaa8c7a663ad..6b88aebeffb5 100644\n--- a/src/ipa/libipa/awb_bayes.cpp\n+++ b/src/ipa/libipa/awb_bayes.cpp\n@@ -330,12 +330,6 @@ double AwbBayes::coarseSearch(const ipa::Pwl &prior, const AwbStats &stats) cons\n \t\terrorLimits.record(delta2Sum);\n \t\tpriorLogLikelihoodLimits.record(priorLogLikelihood);\n \n-\t\tLOG(Awb, Debug) << \"Coarse search t: \" << t\n-\t\t\t\t<< \" gains: \" << gains\n-\t\t\t\t<< \" error: \" << delta2Sum\n-\t\t\t\t<< \" prior: \" << priorLogLikelihood\n-\t\t\t\t<< \" likelihood: \" << finalLogLikelihood;\n-\n \t\tpoints.push_back({ { t, finalLogLikelihood } });\n \t\tif (points.back().y() < points[bestPoint].y())\n \t\t\tbestPoint = points.size() - 1;\n@@ -453,13 +447,6 @@ void AwbBayes::fineSearch(double &t, double &r, double &b, ipa::Pwl const &prior\n \t\tdouble delta2Sum = stats.computeColourError(gains);\n \t\terrorLimits.record(delta2Sum);\n \t\tdouble finalLogLikelihood = delta2Sum - priorLogLikelihood;\n-\t\tLOG(Awb, Debug)\n-\t\t\t<< \"Fine search t: \" << tTest\n-\t\t\t<< \" r: \" << rbTest[0]\n-\t\t\t<< \" b: \" << rbTest[1]\n-\t\t\t<< \" offset: \" << bestOffset\n-\t\t\t<< \" likelihood: \" << finalLogLikelihood\n-\t\t\t<< (finalLogLikelihood < bestLogLikelihood ? \" NEW BEST\" : \"\");\n \n \t\tif (bestT == 0 || finalLogLikelihood < bestLogLikelihood) {\n \t\t\tbestLogLikelihood = finalLogLikelihood;\n","prefixes":["v2","16/17"]}