[{"id":33203,"web_url":"https://patchwork.libcamera.org/comment/33203/","msgid":"","date":"2025-01-27T11:32:23","subject":"Re: [PATCH v2 13/17] utils: tuning: rkisp1: Add lux module","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jan 23, 2025 at 12:41:03PM +0100, Stefan Klug wrote:\n> Now that the lux module is available, add it to the rkisp1 tuner.\n> \n> While at it, sort the imports correctly.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> utils/tuning/rkisp1.py | 14 +++++++++-----\n> 1 file changed, 9 insertions(+), 5 deletions(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 9f40fd8bd63b..207b717a029c 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -6,18 +6,19 @@\n> #\n> # Tuning script for rkisp1\n> \n> -import coloredlogs\n> import logging\n> import sys\n> \n> +import coloredlogs\n> import libtuning as lt\n> -from libtuning.parsers import YamlParser\n> from libtuning.generators import YamlOutput\n> -from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> from libtuning.modules.awb import AWBRkISP1\n> from libtuning.modules.ccm import CCMRkISP1\n> +from libtuning.modules.lsc import LSCRkISP1\n> +from libtuning.modules.lux import LuxRkISP1\n> from libtuning.modules.static import StaticModule\n> +from libtuning.parsers import YamlParser\n> \n> coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> \n> @@ -45,12 +46,15 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> # This is the function that will be used to smooth the color ratio\n> # values. This can also be a custom function.\n> smoothing_function=lt.smoothing.MedianBlur(3),)\n> +lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> -tuner.set_output_order([agc, awb, blc, ccm, color_processing,\n> +\n> +# Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> +tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> filter, gamma_out, lsc])\n> \n> if __name__ == '__main__':\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AF5DBEFBE\n\tfor ;\n\tMon, 27 Jan 2025 11:32:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 543A06855D;\n\tMon, 27 Jan 2025 12:32:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABB3668549\n\tfor ;\n\tMon, 27 Jan 2025 12:32:30 +0100 (CET)","from pyrite.rasen.tech (unknown [206.0.71.13])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BAF618D;\n\tMon, 27 Jan 2025 12:31:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p7ttuP44\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737977484;\n\tbh=3lVz+LkY4lGEJBFYTH50JXxM/p8g/IDhVvQDdjAJxeQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=p7ttuP44ok7Tf0Vg5Nv3sCYHXbizmMkDE7HoWc27iUpETp3OuUtcXfeWgZ+DOXbO2\n\t1Wce3ZC0J7boj+lJIZE/o7MR8QjM0/yulo1yd0rz262Jhx8wGMxI0QybbYwICisf+C\n\tP0DAyAdnLzMcLAaTBtE3L9wGhN7cOOtodeP3uk84=","Date":"Mon, 27 Jan 2025 03:32:23 -0800","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 13/17] utils: tuning: rkisp1: Add lux module","Message-ID":"","References":"<20250123114204.79321-1-stefan.klug@ideasonboard.com>\n\t<20250123114204.79321-14-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250123114204.79321-14-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33365,"web_url":"https://patchwork.libcamera.org/comment/33365/","msgid":"","date":"2025-02-14T17:20:20","subject":"Re: [PATCH v2 13/17] utils: tuning: rkisp1: Add lux module","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"On 23/01/2025 11:41, Stefan Klug wrote:\n> Now that the lux module is available, add it to the rkisp1 tuner.\n>\n> While at it, sort the imports correctly.\n>\n> Signed-off-by: Stefan Klug \n\n\nReviewed-by: Daniel Scally \n\n> ---\n>\n> Changes in v2:\n> - Added this patch\n> ---\n> utils/tuning/rkisp1.py | 14 +++++++++-----\n> 1 file changed, 9 insertions(+), 5 deletions(-)\n>\n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 9f40fd8bd63b..207b717a029c 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -6,18 +6,19 @@\n> #\n> # Tuning script for rkisp1\n> \n> -import coloredlogs\n> import logging\n> import sys\n> \n> +import coloredlogs\n> import libtuning as lt\n> -from libtuning.parsers import YamlParser\n> from libtuning.generators import YamlOutput\n> -from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> from libtuning.modules.awb import AWBRkISP1\n> from libtuning.modules.ccm import CCMRkISP1\n> +from libtuning.modules.lsc import LSCRkISP1\n> +from libtuning.modules.lux import LuxRkISP1\n> from libtuning.modules.static import StaticModule\n> +from libtuning.parsers import YamlParser\n> \n> coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> \n> @@ -45,12 +46,15 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> # This is the function that will be used to smooth the color ratio\n> # values. This can also be a custom function.\n> smoothing_function=lt.smoothing.MedianBlur(3),)\n> +lux = LuxRkISP1(debug=[lt.Debug.Plot])\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc])\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> -tuner.set_output_order([agc, awb, blc, ccm, color_processing,\n> +\n> +# Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.\n> +tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,\n> filter, gamma_out, lsc])\n> \n> if __name__ == '__main__':","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D6F7C3273\n\tfor ;\n\tFri, 14 Feb 2025 17:20:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BB7F68658;\n\tFri, 14 Feb 2025 18:20:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BE996864E\n\tfor ;\n\tFri, 14 Feb 2025 18:20:23 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22A9973B\n\tfor ;\n\tFri, 14 Feb 2025 18:19:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XBxOiNd+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739553544;\n\tbh=DGeDtRXDETcejeZYVDAitVgejp+g02UHfgUqv3rTdRU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=XBxOiNd+Ml2o2tXcNGZ1usSTqYgw+w91QhXYdjpXAU+ZWYrKP2qP0SBLmI706x+5G\n\to3y4yVTS4/MvI9YwwjE9NC5idEZXY2+2aV6A1SD18ObkAdhEzRKXNlRodV9FTTOQcC\n\tqsXIaSZFOO1iulvLAAcuoFVQrm2ChvW55SXLxNfw=","Message-ID":"","Date":"Fri, 14 Feb 2025 17:20:20 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 13/17] utils: tuning: rkisp1: Add lux module","To":"libcamera-devel@lists.libcamera.org","References":"<20250123114204.79321-1-stefan.klug@ideasonboard.com>\n\t<20250123114204.79321-14-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250123114204.79321-14-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]