[{"id":33163,"web_url":"https://patchwork.libcamera.org/comment/33163/","msgid":"<20250124175927.GF13689@pendragon.ideasonboard.com>","date":"2025-01-24T17:59:27","subject":"Re: [RFC PATCH v1 6/7] libcamera: base: log: Pass dynamic prefix\n\tthrough","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Jan 21, 2025 at 06:56:11PM +0000, Barnabás Pőcze wrote:\n> Use move construction to essentially pass through the string\n> returned by `Loggable::logPrefix()` to avoid an unnecessary copy.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/log.h | 2 +-\n> src/libcamera/base/log.cpp | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n> index 9c7775660..ef161bece 100644\n> --- a/include/libcamera/base/log.h\n> +++ b/include/libcamera/base/log.h\n> @@ -64,7 +64,7 @@ class LogMessage\n> public:\n> \tLogMessage(const char *fileName, unsigned int line,\n> \t\t const LogCategory &category, LogSeverity severity,\n> -\t\t const std::string &prefix = std::string());\n> +\t\t std::string prefix = {});\n> \n> \tLogMessage(LogMessage &&);\n> \t~LogMessage();\n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 78db4990c..6430650ec 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -873,9 +873,9 @@ const LogCategory &LogCategory::defaultCategory()\n> */\n> LogMessage::LogMessage(const char *fileName, unsigned int line,\n> \t\t const LogCategory &category, LogSeverity severity,\n> -\t\t const std::string &prefix)\n> +\t\t std::string prefix)\n> \t: category_(category), severity_(severity),\n> -\t timestamp_(utils::clock::now()), prefix_(prefix)\n> +\t timestamp_(utils::clock::now()), prefix_(std::move(prefix))\n> {\n> \tstd::ostringstream ossFileInfo;\n> \tossFileInfo << utils::basename(fileName) << \":\" << line;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B27A1C3220\n\tfor ;\n\tFri, 24 Jan 2025 17:59:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC7D36855D;\n\tFri, 24 Jan 2025 18:59:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5339E68556\n\tfor ;\n\tFri, 24 Jan 2025 18:59:38 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5D9D564;\n\tFri, 24 Jan 2025 18:58:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CouaFkRn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737741513;\n\tbh=WfcvXIQSasakk8PfwbjjvuMoZX8bQQLWVJ6iS549yzk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CouaFkRn+vI/u2yNbwvBX0t+ZjYjuPGmK+LV7zqkerkJxq6SLk1E+Gk8ta8oguIbl\n\tVCEno7B0AxeZwFuewPqyka0nKrGq6IrdMwizsTc2H1XR6J/zfpzEfADTXgpD2h7m2W\n\tcwrT6q8x+PDJzJ1pL7db35v7DAhKgxe446jDJihA=","Date":"Fri, 24 Jan 2025 19:59:27 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v1 6/7] libcamera: base: log: Pass dynamic prefix\n\tthrough","Message-ID":"<20250124175927.GF13689@pendragon.ideasonboard.com>","References":"<20250121185554.301901-1-pobrn@protonmail.com>\n\t<20250121185554.301901-4-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20250121185554.301901-4-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]