[{"id":33119,"web_url":"https://patchwork.libcamera.org/comment/33119/","msgid":"<20250121131828.GN9249@pendragon.ideasonboard.com>","date":"2025-01-21T13:18:28","subject":"Re: [PATCH] libcamera: mali-c55: Fix error paths in ::init()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Tue, Jan 21, 2025 at 01:00:37PM +0000, Daniel Scally wrote:\n> In the ::init() function there are two places that return values they\n\nMaliC55CameraData::init() ? ::init() in C++ means global namespace.\n\n> shouldn't; the ret variable is returned after checking a pointer is\n> not null instead of an explicit -ENODEV and later the boolean value\n> false is returned on failure instead of the error value returned by\n> V4L2Subdevice::open() - fix both problems.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 5abd6b20..6aa2f2d9 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -159,15 +159,16 @@ int MaliC55CameraData::init()\n> \t */\n> \tsensor_ = CameraSensorFactoryBase::create(entity_);\n> \tif (!sensor_)\n> -\t\treturn ret;\n> +\t\treturn -ENODEV;\n> \n> \tconst MediaPad *sourcePad = entity_->getPadByIndex(0);\n> \tMediaEntity *csiEntity = sourcePad->links()[0]->sink()->entity();\n> \n> \tcsi_ = std::make_unique(csiEntity);\n> -\tif (csi_->open()) {\n> +\tret = csi_->open();\n> +\tif (ret) {\n> \t\tLOG(MaliC55, Error) << \"Failed to open CSI-2 subdevice\";\n> -\t\treturn false;\n> +\t\treturn ret;\n> \t}\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52BB5BD160\n\tfor ;\n\tTue, 21 Jan 2025 13:18:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B43068543;\n\tTue, 21 Jan 2025 14:18:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08E3268503\n\tfor ;\n\tTue, 21 Jan 2025 14:18:35 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 975591E3;\n\tTue, 21 Jan 2025 14:17:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dVGWN1z5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737465453;\n\tbh=dixluUocAbBVwzbHfHZDQVQkekU3mi4wGL9qZbvHxJE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dVGWN1z5N2mEoaV4yHQ+Qiy/zCncMOxTPL5l05LFQxQfDNL2LBpaEZ10uVwgKkljT\n\tVobVxHiFyMeCpYDYTc/Lm1SOsI8QxFXNQtqFeJQaS04ZNIxCoZXQrfP2Ygm5+eRl2/\n\tM3lGmIK05AsVB4vQZ4L208Lseqm3TLI2xkdbNrR8=","Date":"Tue, 21 Jan 2025 15:18:28 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: mali-c55: Fix error paths in ::init()","Message-ID":"<20250121131828.GN9249@pendragon.ideasonboard.com>","References":"<20250121130037.237947-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250121130037.237947-1-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33121,"web_url":"https://patchwork.libcamera.org/comment/33121/","msgid":"","date":"2025-01-21T15:33:40","subject":"Re: [PATCH] libcamera: mali-c55: Fix error paths in ::init()","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 21/01/2025 13:18, Laurent Pinchart wrote:\n> Hi Dan,\n>\n> Thank you for the patch.\n>\n> On Tue, Jan 21, 2025 at 01:00:37PM +0000, Daniel Scally wrote:\n>> In the ::init() function there are two places that return values they\n> MaliC55CameraData::init() ? ::init() in C++ means global namespace.\nYes, perhaps that wasn't clear - my bad.\n>\n>> shouldn't; the ret variable is returned after checking a pointer is\n>> not null instead of an explicit -ENODEV and later the boolean value\n>> false is returned on failure instead of the error value returned by\n>> V4L2Subdevice::open() - fix both problems.\n>>\n>> Signed-off-by: Daniel Scally \n> Reviewed-by: Laurent Pinchart \n\nThanks\n\nDan\n\n>\n>> ---\n>> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 7 ++++---\n>> 1 file changed, 4 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n>> index 5abd6b20..6aa2f2d9 100644\n>> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n>> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n>> @@ -159,15 +159,16 @@ int MaliC55CameraData::init()\n>> \t */\n>> \tsensor_ = CameraSensorFactoryBase::create(entity_);\n>> \tif (!sensor_)\n>> -\t\treturn ret;\n>> +\t\treturn -ENODEV;\n>> \n>> \tconst MediaPad *sourcePad = entity_->getPadByIndex(0);\n>> \tMediaEntity *csiEntity = sourcePad->links()[0]->sink()->entity();\n>> \n>> \tcsi_ = std::make_unique(csiEntity);\n>> -\tif (csi_->open()) {\n>> +\tret = csi_->open();\n>> +\tif (ret) {\n>> \t\tLOG(MaliC55, Error) << \"Failed to open CSI-2 subdevice\";\n>> -\t\treturn false;\n>> +\t\treturn ret;\n>> \t}\n>> \n>> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A88C0BD16B\n\tfor ;\n\tTue, 21 Jan 2025 15:33:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8075268543;\n\tTue, 21 Jan 2025 16:33:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE89768503\n\tfor ;\n\tTue, 21 Jan 2025 16:33:43 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61DC7788;\n\tTue, 21 Jan 2025 16:32:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iaWy6Ydu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737473561;\n\tbh=7irZdLuLPLVsVReyz8tma9GHBCnN4cIsUPMzYPrPEIc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=iaWy6YduuKzEi3261JF9FQjmCM+JLSvn0ESCuj5uHhzJ8ExrJiS0m/bi10l3TiHZB\n\thMfxlpFw3jUMW8ihwwc14rlAG8VJv8iw5UmDB4fVjIUvGSDvFY7/UInEvnHIZF3dw9\n\tAkOsbk+U6KjTGJ9i8taGD+Eh8epHipkvmJOd8A3M=","Message-ID":"","Date":"Tue, 21 Jan 2025 15:33:40 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: mali-c55: Fix error paths in ::init()","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20250121130037.237947-1-dan.scally@ideasonboard.com>\n\t<20250121131828.GN9249@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20250121131828.GN9249@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33304,"web_url":"https://patchwork.libcamera.org/comment/33304/","msgid":"<173884406427.1238111.5060573059043241492@ping.linuxembedded.co.uk>","date":"2025-02-06T12:14:24","subject":"Re: [PATCH] libcamera: mali-c55: Fix error paths in ::init()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Dan Scally (2025-01-21 15:33:40)\n> Hi Laurent\n> \n> On 21/01/2025 13:18, Laurent Pinchart wrote:\n> > Hi Dan,\n> >\n> > Thank you for the patch.\n> >\n> > On Tue, Jan 21, 2025 at 01:00:37PM +0000, Daniel Scally wrote:\n> >> In the ::init() function there are two places that return values they\n> > MaliC55CameraData::init() ? ::init() in C++ means global namespace.\n> Yes, perhaps that wasn't clear - my bad.\n\nWith namespace specified correctly, ship it, I think you can just merge\nthis!\n\n\nReviewed-by: Kieran Bingham \n\n> >\n> >> shouldn't; the ret variable is returned after checking a pointer is\n> >> not null instead of an explicit -ENODEV and later the boolean value\n> >> false is returned on failure instead of the error value returned by\n> >> V4L2Subdevice::open() - fix both problems.\n> >>\n> >> Signed-off-by: Daniel Scally \n> > Reviewed-by: Laurent Pinchart \n> \n> Thanks\n> \n> Dan\n> \n> >\n> >> ---\n> >> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 7 ++++---\n> >> 1 file changed, 4 insertions(+), 3 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> >> index 5abd6b20..6aa2f2d9 100644\n> >> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> >> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> >> @@ -159,15 +159,16 @@ int MaliC55CameraData::init()\n> >> */\n> >> sensor_ = CameraSensorFactoryBase::create(entity_);\n> >> if (!sensor_)\n> >> - return ret;\n> >> + return -ENODEV;\n> >> \n> >> const MediaPad *sourcePad = entity_->getPadByIndex(0);\n> >> MediaEntity *csiEntity = sourcePad->links()[0]->sink()->entity();\n> >> \n> >> csi_ = std::make_unique(csiEntity);\n> >> - if (csi_->open()) {\n> >> + ret = csi_->open();\n> >> + if (ret) {\n> >> LOG(MaliC55, Error) << \"Failed to open CSI-2 subdevice\";\n> >> - return false;\n> >> + return ret;\n> >> }\n> >> \n> >> return 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8022AC0F2A\n\tfor ;\n\tThu, 6 Feb 2025 12:14:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E7A7685E4;\n\tThu, 6 Feb 2025 13:14:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 149D0685D3\n\tfor ;\n\tThu, 6 Feb 2025 13:14:27 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 696301193;\n\tThu, 6 Feb 2025 13:13:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V/z4CEKI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738843993;\n\tbh=KEigkvV+Q/N21cPe8nNNbcbjdmDCt0egGmsomcul47E=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=V/z4CEKIfafb60mgaH2XtykT9cDP4uq17Idm9TJ3E80T0c/abFQ3kNi90WFbn0Uq0\n\tnS9IjRqOGUmubsWMW6X3NdGMg2AQZ98eRcfE8YXzF1LABXwrtsv6397vQyYd6cILSL\n\trtB45uWfkfhflpAZ/3nuW0jmP7q/V/2W+5Sw7L64=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250121130037.237947-1-dan.scally@ideasonboard.com>\n\t<20250121131828.GN9249@pendragon.ideasonboard.com>\n\t","Subject":"Re: [PATCH] libcamera: mali-c55: Fix error paths in ::init()","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Dan Scally ,\n\tLaurent Pinchart ","Date":"Thu, 06 Feb 2025 12:14:24 +0000","Message-ID":"<173884406427.1238111.5060573059043241492@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]