[{"id":3053,"web_url":"https://patchwork.libcamera.org/comment/3053/","msgid":"<20191118113010.GJ4724@pendragon.ideasonboard.com>","date":"2019-11-18T11:30:10","subject":"Re: [libcamera-devel] [PATCH 10/10] libcamera: pipeline: Drop\n\tforward declaration of BufferPool","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:22:24AM +0100, Niklas Söderlund wrote:\n> There is no need to forward declare BufferPool, drop it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/include/pipeline_handler.h | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 42b90a4bf1a6e414..320740746bc6e998 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -21,7 +21,6 @@\n> namespace libcamera {\n> \n> class Buffer;\n> -class BufferPool;\n> class Camera;\n> class CameraConfiguration;\n> class CameraManager;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30F6260F1C\n\tfor ;\n\tMon, 18 Nov 2019 12:30:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2048563;\n\tMon, 18 Nov 2019 12:30:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574076615;\n\tbh=h7a/qibnfz6MCXButNgyHZhnI8IfgOD2+7aMCn3XZvw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qmjP/ZTYYUQ2oMrP9iPr5RhoFaJox+qOXbNfxFX303DLld7uXpWNnL91GAXNL51is\n\tskyPikDJxe2GxJqsD1GT/1oahZhI/tuekRvUr9V4Okz4cOfq8ZB/N5nRXAj+PEGEhq\n\tGmr6EyPf/4dKs2wTLLyM5zXNtgX4AikYc/IE+T68=","Date":"Mon, 18 Nov 2019 13:30:10 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118113010.GJ4724@pendragon.ideasonboard.com>","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>\n\t<20191028022224.795355-11-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022224.795355-11-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 10/10] libcamera: pipeline: Drop\n\tforward declaration of BufferPool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 11:30:15 -0000"}}]