[{"id":33123,"web_url":"https://patchwork.libcamera.org/comment/33123/","msgid":"<20250121161153.GP9249@pendragon.ideasonboard.com>","date":"2025-01-21T16:11:53","subject":"Re: [PATCH 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Fri, Jan 17, 2025 at 02:34:08PM +0000, Daniel Scally wrote:\n> The IPU3 IPA's AGC algorithm currently does not implement a\n> queueRequest() function. We will shortly need to use it, but to\n> avoid lots of noise in the future commit that adds a function call in\n> to that function add it as a skeleton here.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 10 ++++++++++\n> src/ipa/ipu3/algorithms/agc.h | 3 +++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 39d0aebb..383b046c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -123,6 +123,16 @@ int Agc::configure(IPAContext &context,\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> + */\n> +void Agc::queueRequest([[maybe_unused]] typename Module::Context &context,\n> +\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t [[maybe_unused]] typename Module::FrameContext &frameContext,\n> +\t\t [[maybe_unused]] const ControlList &controls)\n> +{\n> +}\n> +\n> Histogram Agc::parseStatistics(const ipu3_uapi_stats_3a *stats,\n> \t\t\t const ipu3_uapi_grid_config &grid)\n> {\n> diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\n> index 890c271b..c82b7acb 100644\n> --- a/src/ipa/ipu3/algorithms/agc.h\n> +++ b/src/ipa/ipu3/algorithms/agc.h\n> @@ -32,6 +32,9 @@ public:\n> \n> \tint init(IPAContext &context, const YamlObject &tuningData) override;\n> \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> +\tvoid queueRequest(IPAContext &context, const uint32_t frame,\n> +\t\t\t IPAFrameContext &frameContext,\n> +\t\t\t const ControlList &controls) override;\n> \tvoid process(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t const ipu3_uapi_stats_3a *stats,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC23BBD16B\n\tfor ;\n\tTue, 21 Jan 2025 16:12:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A5B66854C;\n\tTue, 21 Jan 2025 17:12:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 754DA68503\n\tfor ;\n\tTue, 21 Jan 2025 17:12:01 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBCE655A;\n\tTue, 21 Jan 2025 17:10:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vKr3mnwA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737475859;\n\tbh=s7pkTUJOq3dmng49Eac4DqBOdLHPiEQawJqp1wme93g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vKr3mnwAJfpaJuckOf5O7vGIkxkcrXRqsz/doXWpvYhpP0gyylSRAnXGVJlog+Q/y\n\tq/Lx61IylrrU9G94jfXNaDuA0I9Rig4FCp9AZ9DYXgdcRElud0GezecS0vTTiK9Xmx\n\t7U2ztV86pL5g8vZFxeCbwuzGAwPRjU/wkj2Yu39U=","Date":"Tue, 21 Jan 2025 18:11:53 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function","Message-ID":"<20250121161153.GP9249@pendragon.ideasonboard.com>","References":"<20250117143410.20363-1-dan.scally@ideasonboard.com>\n\t<20250117143410.20363-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250117143410.20363-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33144,"web_url":"https://patchwork.libcamera.org/comment/33144/","msgid":"","date":"2025-01-23T04:05:05","subject":"Re: [PATCH 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Jan 17, 2025 at 02:34:08PM +0000, Daniel Scally wrote:\n> The IPU3 IPA's AGC algorithm currently does not implement a\n> queueRequest() function. We will shortly need to use it, but to\n> avoid lots of noise in the future commit that adds a function call in\n> to that function add it as a skeleton here.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 10 ++++++++++\n> src/ipa/ipu3/algorithms/agc.h | 3 +++\n> 2 files changed, 13 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 39d0aebb..383b046c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -123,6 +123,16 @@ int Agc::configure(IPAContext &context,\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> + */\n> +void Agc::queueRequest([[maybe_unused]] typename Module::Context &context,\n> +\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t [[maybe_unused]] typename Module::FrameContext &frameContext,\n> +\t\t [[maybe_unused]] const ControlList &controls)\n> +{\n> +}\n> +\n> Histogram Agc::parseStatistics(const ipu3_uapi_stats_3a *stats,\n> \t\t\t const ipu3_uapi_grid_config &grid)\n> {\n> diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\n> index 890c271b..c82b7acb 100644\n> --- a/src/ipa/ipu3/algorithms/agc.h\n> +++ b/src/ipa/ipu3/algorithms/agc.h\n> @@ -32,6 +32,9 @@ public:\n> \n> \tint init(IPAContext &context, const YamlObject &tuningData) override;\n> \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> +\tvoid queueRequest(IPAContext &context, const uint32_t frame,\n> +\t\t\t IPAFrameContext &frameContext,\n> +\t\t\t const ControlList &controls) override;\n> \tvoid process(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t const ipu3_uapi_stats_3a *stats,\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7420BE08B\n\tfor ;\n\tThu, 23 Jan 2025 04:05:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C759961878;\n\tThu, 23 Jan 2025 05:05:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20ADA61878\n\tfor ;\n\tThu, 23 Jan 2025 05:05:13 +0100 (CET)","from pyrite.rasen.tech (unknown [IPv6:2603:6081:63f0:60f0::17f2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1593110F; \n\tThu, 23 Jan 2025 05:04:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gHtUyKlR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737605049;\n\tbh=OFB4wCJZndEovCnP5Pbzc0JUgrsi3Fnvjq6qb015hes=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gHtUyKlRiSUvzvSeXmgtkYsbpDaZqOHpWHVMlazkK4EhaabsMF7rz8269DahDW4Ax\n\tPx6HHRxm3jnDqL/xcyPeVgr8ijTULOx9S6aN8dORl/iRNgYggoVjo3U6EtRsUtj0ai\n\tNJrIx35TsZf0tgJuKrGiotrJ0VheE09XQpO7dsC4=","Date":"Wed, 22 Jan 2025 23:05:05 -0500","From":"Paul Elder ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] ipa: ipu3: Add skeleton Agc::queueRequest() function","Message-ID":"","References":"<20250117143410.20363-1-dan.scally@ideasonboard.com>\n\t<20250117143410.20363-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20250117143410.20363-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]