[{"id":33070,"web_url":"https://patchwork.libcamera.org/comment/33070/","msgid":"","date":"2025-01-14T09:17:16","subject":"Re: [PATCH v8 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Paul,\n\nThanks for the patch.\n\nOn Mon, 13 Jan 2025 at 22:02, Paul Elder wrote:\n>\n> Even though the new AeEnable control internally switches on and off the\n> sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\n> be declared as available. Report this control as available in the\n> rpi IPA.\n>\n> Support for the control does not need to be added as it is handled by\n> the Camera class. It does not need to be handled in metadata either as\n> the new version of AeEnable is not returned in metadata.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Stefan Klug \n\nReviewed-by: Naushir Patuck \n\n>\n> ---\n> Changes in v8:\n> - add \"true\" as default value\n>\n> No change in v7\n>\n> New in v6\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index 0fb58c1d0..a5c46e6ec 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n>\n> /* List of controls handled by the Raspberry Pi IPA */\n> const ControlInfoMap::Map ipaControls{\n> + /* \\todo Move this to the Camera class */\n> + { &controls::AeEnable, ControlInfo(false, true, true) },\n> { &controls::ExposureTimeMode,\n> ControlInfo(static_cast(controls::ExposureTimeModeAuto),\n> static_cast(controls::ExposureTimeModeManual),\n> --\n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39CF5C3303\n\tfor ;\n\tTue, 14 Jan 2025 09:17:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40DFB68506;\n\tTue, 14 Jan 2025 10:17:51 +0100 (CET)","from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com\n\t[IPv6:2607:f8b0:4864:20::b35])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C94B9608A9\n\tfor ;\n\tTue, 14 Jan 2025 10:17:48 +0100 (CET)","by mail-yb1-xb35.google.com with SMTP id\n\t3f1490d57ef6-e54dbb2ea3fso936498276.0\n\tfor ;\n\tTue, 14 Jan 2025 01:17:48 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rU0p8/Hm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1736846267; x=1737451067;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=FdDCHbwWnJcqPKbzrpif4fYJDryjgpD5pyRX0XVNplc=;\n\tb=rU0p8/Hmpm3VlKxJbzEHYa5gSlSKhMS5Ag+m1iTt7/TNYNl5iPdkTT/dVBakp/zL1G\n\tnFRF9NXFmQDMwsaW8GJcEeiEns9dsWWGxlyCzE0eQYdkrcy1oVk3X9kCJAeOMjwJMlWk\n\t9e1xU1/oGPatjyC/SIuwFGNUZ8kW7Hg1AO9blAq7usLJj8OOH5cr+fimZ2543rPRfs2y\n\txz5VJon9BZOSf0DgGPGmA+W7rEFeGPLzUxk8iVmce+NDE7dFlB4aRacRhCPt+NI6rbcR\n\t9P/EZHBZUFvO+E6Ki5FGoZFJGGoGuddYG51cAfdnoFGFDeeGJQU3Gvhx8l2pmLR3e8jB\n\tKCIg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1736846267; x=1737451067;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=FdDCHbwWnJcqPKbzrpif4fYJDryjgpD5pyRX0XVNplc=;\n\tb=CMxtYYIX8MeNswP751gL7P3Q1xj1gBFcXPI6Ts3+YT3parjTC+ec+C9LQhPEQt4smI\n\tYhH4Ub8gdHTbB3ARWdrKTmWvRRq4WB+8DlOkFnYiA/aVIg9hy8zLf8UutI838yeOmAFZ\n\tJpyTC6LGHhGuHrJ7ewBr5Spx/jE8uprG/vgYoHoG0EIvEOAW54Xfp37TyLG9KTogjzM6\n\tccFu+CljjNCOzvsdg/jO1/57MuYlhw4nxvuF1JiPOQRoaM04vt/m3fSgzBltfWIw4Sbw\n\t7PXv33BKusWX5PSSOtm1h1BcX3FYk1umbUaqKSlfuqzzBEufRyu5tP0apejf3BdJt3IG\n\tnSkA==","X-Gm-Message-State":"AOJu0Yz8D13wZhcqWjOVhKtUMjeeYfZUAidp/9HVhANPlQWeen3LBM9J\n\tD5XB/j9Nshc3ksmsvuR3gt+zYlZgIslgexwj8D/JUowladJVbq2izAdUTlKNo064eVEC1bO7Y4/\n\tGS1HsHF15HXmRaB6SBPuPZTYxrO6C17JOZedAEA==","X-Gm-Gg":"ASbGncso3plGa7g5aqxKLSc54yoOnRWO/CMv5keiERc0HR1ASmha7ft8o64h6+li/PK\n\t5uruhhkH8puePaafKs+HVb4kSPx/PQtnwLVk+snskem0pCD0fN//A/Ive1F0VgSZxonGwwA==","X-Google-Smtp-Source":"AGHT+IHYHMS13/hzWcPCkidizAGLtftDd8+ugLYDwgMkexwADf/CwEqrkg1jADEYKQYDNx6IS420Mn2SlcXlK1nV74Y=","X-Received":"by 2002:a05:6902:2403:b0:e4c:b42e:14f5 with SMTP id\n\t3f1490d57ef6-e54ee17d17emr8150872276.5.1736846267520; Tue, 14 Jan 2025\n\t01:17:47 -0800 (PST)","MIME-Version":"1.0","References":"<20250113215946.1033762-1-paul.elder@ideasonboard.com>\n\t<20250113215946.1033762-13-paul.elder@ideasonboard.com>","In-Reply-To":"<20250113215946.1033762-13-paul.elder@ideasonboard.com>","From":"Naushir Patuck ","Date":"Tue, 14 Jan 2025 09:17:16 +0000","X-Gm-Features":"AbW1kvYE6Cwax1khNJajddVpEcN27bM9zay1sY1HHDuK5n_aZy_DsfZJ9p_qKqw","Message-ID":"","Subject":"Re: [PATCH v8 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tstefan.klug@ideasonboard.com, david.plowman@raspberrypi.com","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]