[{"id":3052,"web_url":"https://patchwork.libcamera.org/comment/3052/","msgid":"<20191118112915.GI4724@pendragon.ideasonboard.com>","date":"2019-11-18T11:29:15","subject":"Re: [libcamera-devel] [PATCH 07/10] libcamera: pipeline_handler: Do\n\tnot use argument as local variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:22:21AM +0100, Niklas Söderlund wrote:\n> In completeRequest() the request argument is used as a local variable,\n> this is confusing. Add a separate local variable instead of reusing the\n> argument.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index bf8c86d35c4fb6f4..f9ae767d529d44d9 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -409,13 +409,13 @@ void PipelineHandler::completeRequest(Camera *camera, Request *request)\n> \tCameraData *data = cameraData(camera);\n> \n> \twhile (!data->queuedRequests_.empty()) {\n> -\t\trequest = data->queuedRequests_.front();\n> -\t\tif (request->status() == Request::RequestPending)\n> +\t\tRequest *req = data->queuedRequests_.front();\n> +\t\tif (req->status() == Request::RequestPending)\n> \t\t\tbreak;\n> \n> -\t\tASSERT(!request->hasPendingBuffers());\n> +\t\tASSERT(!req->hasPendingBuffers());\n> \t\tdata->queuedRequests_.pop_front();\n> -\t\tcamera->requestComplete(request);\n> +\t\tcamera->requestComplete(req);\n> \t}\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6691B60F1C\n\tfor ;\n\tMon, 18 Nov 2019 12:29:20 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7D17563;\n\tMon, 18 Nov 2019 12:29:19 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574076560;\n\tbh=q01gsKsoWGIIpL5wRrhqTg9wbgpSYjym7vxqbIodzOI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=maUVok9L6jU3UhI/Db/FACUVKZBImQg4HY68sNb90XltpV0PMNvSPmBkYQVTTeb6j\n\t2F+a1LVnssa0QXmDOPzmtl5hPRFDIva4qb5pFottFaiBMtBA5QIgEqbedAsztOh8q0\n\t5MVcCukAwil7x/N9t88FzGDm5BhBcA5OOySHA2rI=","Date":"Mon, 18 Nov 2019 13:29:15 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118112915.GI4724@pendragon.ideasonboard.com>","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>\n\t<20191028022224.795355-8-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022224.795355-8-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 07/10] libcamera: pipeline_handler: Do\n\tnot use argument as local variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 11:29:20 -0000"}}]