[{"id":33188,"web_url":"https://patchwork.libcamera.org/comment/33188/","msgid":"<20250126235817.GK1133@pendragon.ideasonboard.com>","date":"2025-01-26T23:58:17","subject":"Re: [PATCH v4 7/9] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Jan 13, 2025 at 02:51:04PM +0100, Milan Zamazal wrote:\n> For performance reasons, color correction matrix (CCM) is not applied by\n> default in software ISP. But let's add a commented out example how to\n> define it to the default tuning file.\n> \n> Signed-off-by: Milan Zamazal \n> Acked-by: Kieran Bingham \n> ---\n> src/ipa/simple/data/uncalibrated.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n> index 3f147112..8df3cd4e 100644\n> --- a/src/ipa/simple/data/uncalibrated.yaml\n> +++ b/src/ipa/simple/data/uncalibrated.yaml\n> @@ -5,6 +5,13 @@ version: 1\n> algorithms:\n> - BlackLevel:\n> - Awb:\n> + # Color correction matrices can be defined here:\n\nYou could explain why this is commented out:\n\n # Color correction matrices can be defined here. The CCM algorithm has a\n # significant performance impact, and should only be enabled if tuned.\n\nReviewed-by: Laurent Pinchart \n\n> + # - Ccm:\n> + # ccms:\n> + # - ct: 6500\n> + # ccm: [ 1, 0, 0,\n> + # 0, 1, 0,\n> + # 0, 0, 1]\n> - Lut:\n> - Agc:\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F2D4BDCBF\n\tfor ;\n\tSun, 26 Jan 2025 23:58:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CBFF6855D;\n\tMon, 27 Jan 2025 00:58:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9804A6187B\n\tfor ;\n\tMon, 27 Jan 2025 00:58:29 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8ECA0496;\n\tMon, 27 Jan 2025 00:57:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YsE/28V2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737935843;\n\tbh=FYakYTvNRSzjQPPOybGP1P5xDDAo6QblgvwkAc86wew=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YsE/28V2E20+wh6/OV7Tgfy5QF5N4xlQFQMy3gD6tfN757qkB5MDMT/GNzseovQkL\n\tsBYCRk2VOsGwPsHzfpzhy8/+y6zqFCsyhqcjEwSH4Dc86GcEYqFA/4FV1rbYP+fhOX\n\tOA8M9M9iuGrHgZ07PE5KL7ocNl7MucvT+HU15+0c=","Date":"Mon, 27 Jan 2025 01:58:17 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tRobert Mader ,\n\tHans de Goede ,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 7/9] libcamera: software_isp: Add an example CCM to\n\tuncalibrated.yaml","Message-ID":"<20250126235817.GK1133@pendragon.ideasonboard.com>","References":"<20250113135108.13924-1-mzamazal@redhat.com>\n\t<20250113135108.13924-8-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250113135108.13924-8-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]