[{"id":33184,"web_url":"https://patchwork.libcamera.org/comment/33184/","msgid":"<20250126230433.GG1133@pendragon.ideasonboard.com>","date":"2025-01-26T23:04:33","subject":"Re: [PATCH v4 3/9] libcamera: software_isp: lut: Remove maybe_unused\n\ton a used argument","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Jan 13, 2025 at 02:51:00PM +0100, Milan Zamazal wrote:\n> `params' argument of Lut::prepare is actually used, let's remove\n> maybe_unused from it.\n> \n> Signed-off-by: Milan Zamazal \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/simple/algorithms/lut.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index d75ff710..243f0818 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -83,7 +83,7 @@ void Lut::updateGammaTable(IPAContext &context)\n> void Lut::prepare(IPAContext &context,\n> \t\t [[maybe_unused]] const uint32_t frame,\n> \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n> -\t\t [[maybe_unused]] DebayerParams *params)\n> +\t\t DebayerParams *params)\n> {\n> \t/*\n> \t * Update the gamma table if needed. This means if black level changes","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D67ECBEFBE\n\tfor ;\n\tSun, 26 Jan 2025 23:04:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3B686855E;\n\tMon, 27 Jan 2025 00:04:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B97B6187B\n\tfor ;\n\tMon, 27 Jan 2025 00:04:44 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C70AB6DF;\n\tMon, 27 Jan 2025 00:03:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sfxTGjdg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737932618;\n\tbh=gUGwDwWtQR91n8wN+Y7nkBBYKMVsWzk2nrI2VQ1ijxA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sfxTGjdg182gJEsSgqTWLLP9RdwZpSmFbikRCMVFvo5iJn1L2VmmsjQr2SPAJpZ1j\n\tc4NjcYsmimgEoV7g6zUe0S5VGw3K3j8CM3KbtttiMIjxEGtl9buTubJbk7ADfuce1i\n\tqukp3W7XYOCHdiqCHMgqy2VvAUd3tMm+lEUviYYk=","Date":"Mon, 27 Jan 2025 01:04:33 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tRobert Mader ,\n\tHans de Goede ,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 3/9] libcamera: software_isp: lut: Remove maybe_unused\n\ton a used argument","Message-ID":"<20250126230433.GG1133@pendragon.ideasonboard.com>","References":"<20250113135108.13924-1-mzamazal@redhat.com>\n\t<20250113135108.13924-4-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250113135108.13924-4-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]