[{"id":33196,"web_url":"https://patchwork.libcamera.org/comment/33196/","msgid":"<20250127071026.GB11289@pendragon.ideasonboard.com>","date":"2025-01-27T07:10:26","subject":"Re: [PATCH v3 6/6] ipa: simple: Report exposure in metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Jan 13, 2025 at 02:34:05PM +0100, Milan Zamazal wrote:\n> Report the exposure+gain in metadata.\n> \n> The exposure value is especially dubious because it should be in\n> microseconds but it's handled using V4L2_CID_EXPOSURE control, which\n> doesn't specify the unit, see\n> https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html.\n\nPlease convert it to the right unit.\n\n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/simple/algorithms/agc.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\n> index 72aade14..ba7e7adc 100644\n> --- a/src/ipa/simple/algorithms/agc.cpp\n> +++ b/src/ipa/simple/algorithms/agc.cpp\n> @@ -11,6 +11,8 @@\n> \n> #include \n> \n> +#include \"control_ids.h\"\n> +\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftExposure)\n> @@ -99,8 +101,11 @@ void Agc::process(IPAContext &context,\n> \t\t [[maybe_unused]] const uint32_t frame,\n> \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n> \t\t const SwIspStats *stats,\n> -\t\t [[maybe_unused]] ControlList &metadata)\n> +\t\t ControlList &metadata)\n> {\n> +\tmetadata.set(controls::ExposureTime, frameContext.sensor.exposure);\n> +\tmetadata.set(controls::AnalogueGain, frameContext.sensor.gain);\n> +\n> \t/*\n> \t * Calculate Mean Sample Value (MSV) according to formula from:\n> \t * https://www.araa.asn.au/acra/acra2007/papers/paper84final.pdf","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F54ABEFBE\n\tfor ;\n\tMon, 27 Jan 2025 07:10:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F33B16855F;\n\tMon, 27 Jan 2025 08:10:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03CC868557\n\tfor ;\n\tMon, 27 Jan 2025 08:10:38 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7DF878D;\n\tMon, 27 Jan 2025 08:09:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SsBgaRxb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737961771;\n\tbh=ZhRiELIGBlF6Y6e2vEARz2zrHEqIT38Rc7KkKKgYW00=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SsBgaRxbde5XGqLo/SFi11wcHpSHBojOlkckk7Qt7va1Pr+fguhaCj8p4Jm7NJ7Mq\n\tB7sab3zizQYJCH2NIAXaQkiqUbLIe+ppgFGMgJ8bXOeBpDg9qIC6qc9tB1knKKZUMi\n\tK2ieB6HEoidG7tZsjaAs0oyzE6Js3BQaTy8FqKN4=","Date":"Mon, 27 Jan 2025 09:10:26 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"Re: [PATCH v3 6/6] ipa: simple: Report exposure in metadata","Message-ID":"<20250127071026.GB11289@pendragon.ideasonboard.com>","References":"<20250113133405.12167-1-mzamazal@redhat.com>\n\t<20250113133405.12167-7-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250113133405.12167-7-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33210,"web_url":"https://patchwork.libcamera.org/comment/33210/","msgid":"<85sep4mnoq.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","date":"2025-01-27T12:44:05","subject":"Re: [PATCH v3 6/6] ipa: simple: Report exposure in metadata","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for review.\n\nLaurent Pinchart writes:\n\n> Hi Milan,\n>\n> Thank you for the patch.\n>\n> On Mon, Jan 13, 2025 at 02:34:05PM +0100, Milan Zamazal wrote:\n>> Report the exposure+gain in metadata.\n>> \n>> The exposure value is especially dubious because it should be in\n>> microseconds but it's handled using V4L2_CID_EXPOSURE control, which\n>> doesn't specify the unit, see\n>> https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html.\n>\n> Please convert it to the right unit.\n\nBut what's the original unit? It's unspecified in the link above:\n\n V4L2_CID_EXPOSURE (integer)\n Exposure (cameras). [Unit?]\n\nIs there any better source of information?\n\n>> Signed-off-by: Milan Zamazal \n>> ---\n>> src/ipa/simple/algorithms/agc.cpp | 7 ++++++-\n>> 1 file changed, 6 insertions(+), 1 deletion(-)\n>> \n>> diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\n>> index 72aade14..ba7e7adc 100644\n>> --- a/src/ipa/simple/algorithms/agc.cpp\n>> +++ b/src/ipa/simple/algorithms/agc.cpp\n>> @@ -11,6 +11,8 @@\n>> \n>> #include \n>> \n>> +#include \"control_ids.h\"\n>> +\n>> namespace libcamera {\n>> \n>> LOG_DEFINE_CATEGORY(IPASoftExposure)\n>> @@ -99,8 +101,11 @@ void Agc::process(IPAContext &context,\n>> \t\t [[maybe_unused]] const uint32_t frame,\n>> \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n>> \t\t const SwIspStats *stats,\n>> -\t\t [[maybe_unused]] ControlList &metadata)\n>> +\t\t ControlList &metadata)\n>> {\n>> +\tmetadata.set(controls::ExposureTime, frameContext.sensor.exposure);\n>> +\tmetadata.set(controls::AnalogueGain, frameContext.sensor.gain);\n>> +\n>> \t/*\n>> \t * Calculate Mean Sample Value (MSV) according to formula from:\n>> \t * https://www.araa.asn.au/acra/acra2007/papers/paper84final.pdf","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 445BABDCC1\n\tfor ;\n\tMon, 27 Jan 2025 12:44:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1F016855D;\n\tMon, 27 Jan 2025 13:44:12 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A09E868549\n\tfor ;\n\tMon, 27 Jan 2025 13:44:11 +0100 (CET)","from mail-ej1-f71.google.com (mail-ej1-f71.google.com\n\t[209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-466-AExvuw2ANgSPXq1tIlsemw-1; Mon, 27 Jan 2025 07:44:09 -0500","by mail-ej1-f71.google.com with SMTP id\n\ta640c23a62f3a-aa63b02c69cso470712966b.0\n\tfor ;\n\tMon, 27 Jan 2025 04:44:08 -0800 (PST)","from mzamazal-thinkpadp1gen3.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-ab6aa40824asm132664866b.134.2025.01.27.04.44.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 27 Jan 2025 04:44:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"cS5gxTHr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737981850;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=esTgtcoGg02IVndB9igTiZH+ZFMdFCXTeXn/2krjzu4=;\n\tb=cS5gxTHrRT8OsM0KplVzKpLeFB0R6tpW36CCgJ4uTsgQD+OwrZRUG1QxwFLA9bW9u1LLiw\n\tKeZk0fCaM0SYZYDblO1Kkykq21+9bGXWaCtTN/9os4fJ7WT9nmMnMfLe6mJkt0rF+RYvpj\n\tXSDS44ZeXyfTNVz+qNcd+YlEKdOkyp8=","X-MC-Unique":"AExvuw2ANgSPXq1tIlsemw-1","X-Mimecast-MFC-AGG-ID":"AExvuw2ANgSPXq1tIlsemw","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1737981847; x=1738586647;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=esTgtcoGg02IVndB9igTiZH+ZFMdFCXTeXn/2krjzu4=;\n\tb=I/+mN2jZ17b7ixy0fx6bw79qi83++xySn30zn3EWaOmXcBq6HfJW2wAEV4Ra7B9rBu\n\tZGmlnWlykMgfWP7sD2Ml3hbHe2bAZZSXCCHp3lceFKe4JGQchiRuoarDIoxq8ZmC6SDH\n\t0gx6LMtFrO2+JXFYf6O7pJDhJAh9f9kpyrZMNTOQ4SNtjQjr/e1taemOz04mNPpKk+c5\n\teOdnGFT6oM3nnbXHjWDb+DFAv+zI2WbLkPhyG3pRakisKVt6pc43aM/pZT+2qahMpbNm\n\tSRH/YUWy6gJ1wBUYzY/kn4AEwVcEXontqXC/grDnqajXkNRVL9kJyFYA0v7uE1Z6Nh9A\n\tck5Q==","X-Gm-Message-State":"AOJu0YxT9hYxlj0uGTzOBUKPg9ZGCYEIK8FbjyzfO3e2M8dcqxriMVvS\n\tAEwgZzaKmSgjS/xt63hqRagofdC5mVR3OjJS/4YYnVDshPBgqSlQWCnBSKeKvud6Gq6pCQZ2Wi/\n\t8pWAj+Nt3Ey93vcrURL33q8TIZppVQcHBufAGm//Dj13k73CqOpXjjud0VU3ihHArDAw1NyuOEz\n\tCB8CQ=","X-Gm-Gg":"ASbGncul63RXHa9eyec9RWH2i6EItz4ySvhDc08LXHHoyTuJA3h5TlojYwNnYB7PDTu\n\tA4uehgyelgLIxS0TOm1cloONvA16yWbkb8uauL2z8JrsqszlPRef9x7ImClmjgyyIyFBxhFD48u\n\tz80uDz+tZ4KF0n1piqd6m0MNR37fJgZHMSg92CvQ7kGfj377u2Jx3pTOKS9pKmvvJfmLpYUAj5k\n\tvtFvah2fwhTjiHegGa5YIGvekUGPzrMgcIz+zeVZH0sJTq+p+kVKVcgvwVvpRStaxFQD9ES44ut\n\tgNlxzpKzv17RthammxB7tOsLrTZ9UksI3EsriuEde31hs5/F4kwjYZXHgQ==","X-Received":["by 2002:a17:907:94d5:b0:ab2:f255:59f5 with SMTP id\n\ta640c23a62f3a-ab6629d01c4mr1506940666b.16.1737981847327; \n\tMon, 27 Jan 2025 04:44:07 -0800 (PST)","by 2002:a17:907:94d5:b0:ab2:f255:59f5 with SMTP id\n\ta640c23a62f3a-ab6629d01c4mr1506938066b.16.1737981846957; \n\tMon, 27 Jan 2025 04:44:06 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IG/LEtFOPXXm8pjK3+tr0tIhOwTHq2OUth7TwIFdgGKGOrpZ71L5+/DGFPVcirG+VCef4cDbw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham , =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= ","Subject":"Re: [PATCH v3 6/6] ipa: simple: Report exposure in metadata","In-Reply-To":"<20250127071026.GB11289@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Mon, 27 Jan 2025 09:10:26 +0200\")","References":"<20250113133405.12167-1-mzamazal@redhat.com>\n\t<20250113133405.12167-7-mzamazal@redhat.com>\n\t<20250127071026.GB11289@pendragon.ideasonboard.com>","Date":"Mon, 27 Jan 2025 13:44:05 +0100","Message-ID":"<85sep4mnoq.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"1nCkgjBc3EK-6qk7q1rVlaWy1uf4RIunH3MT_VkMnrE_1737981848","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33211,"web_url":"https://patchwork.libcamera.org/comment/33211/","msgid":"<20250127163510.GK17899@pendragon.ideasonboard.com>","date":"2025-01-27T16:35:10","subject":"Re: [PATCH v3 6/6] ipa: simple: Report exposure in metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nOn Mon, Jan 27, 2025 at 01:44:05PM +0100, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> > On Mon, Jan 13, 2025 at 02:34:05PM +0100, Milan Zamazal wrote:\n> >> Report the exposure+gain in metadata.\n> >> \n> >> The exposure value is especially dubious because it should be in\n> >> microseconds but it's handled using V4L2_CID_EXPOSURE control, which\n> >> doesn't specify the unit, see\n> >> https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html.\n> >\n> > Please convert it to the right unit.\n> \n> But what's the original unit? It's unspecified in the link above:\n> \n> V4L2_CID_EXPOSURE (integer)\n> Exposure (cameras). [Unit?]\n> \n> Is there any better source of information?\n\nThe camera helpers in libipa provide functions to convert exposure time\nbetween time units and V4L2 control units. You can look at how rkisp1\nhandles that for instance.\n\n> >> Signed-off-by: Milan Zamazal \n> >> ---\n> >> src/ipa/simple/algorithms/agc.cpp | 7 ++++++-\n> >> 1 file changed, 6 insertions(+), 1 deletion(-)\n> >> \n> >> diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\n> >> index 72aade14..ba7e7adc 100644\n> >> --- a/src/ipa/simple/algorithms/agc.cpp\n> >> +++ b/src/ipa/simple/algorithms/agc.cpp\n> >> @@ -11,6 +11,8 @@\n> >> \n> >> #include \n> >> \n> >> +#include \"control_ids.h\"\n> >> +\n> >> namespace libcamera {\n> >> \n> >> LOG_DEFINE_CATEGORY(IPASoftExposure)\n> >> @@ -99,8 +101,11 @@ void Agc::process(IPAContext &context,\n> >> \t\t [[maybe_unused]] const uint32_t frame,\n> >> \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n> >> \t\t const SwIspStats *stats,\n> >> -\t\t [[maybe_unused]] ControlList &metadata)\n> >> +\t\t ControlList &metadata)\n> >> {\n> >> +\tmetadata.set(controls::ExposureTime, frameContext.sensor.exposure);\n> >> +\tmetadata.set(controls::AnalogueGain, frameContext.sensor.gain);\n> >> +\n> >> \t/*\n> >> \t * Calculate Mean Sample Value (MSV) according to formula from:\n> >> \t * https://www.araa.asn.au/acra/acra2007/papers/paper84final.pdf","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1232BBEFBE\n\tfor ;\n\tMon, 27 Jan 2025 16:35:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 066EA6855D;\n\tMon, 27 Jan 2025 17:35:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C560F68549\n\tfor ;\n\tMon, 27 Jan 2025 17:35:21 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3D16675;\n\tMon, 27 Jan 2025 17:34:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CHJktCdD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737995655;\n\tbh=Wr6LIeXSSdjYfbg+pTKBmFgm3L83YVxBhnExtiliv0U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CHJktCdDekQhP8CKDLeScPYSWYPZ2ehEODMpIeG/A6ppo472bUk9JfqtyHAl4oj0+\n\tWyg7omfeVexIB9GSYvCPbPAGBDZdsp6MfOMYIFvWiWAW5NhuEQqJt1dMIuHd2XG0W6\n\t3+nRs3A/bTnC5LHPKSlgM8cBXTJOhIxTHi8DLKvA=","Date":"Mon, 27 Jan 2025 18:35:10 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"Re: [PATCH v3 6/6] ipa: simple: Report exposure in metadata","Message-ID":"<20250127163510.GK17899@pendragon.ideasonboard.com>","References":"<20250113133405.12167-1-mzamazal@redhat.com>\n\t<20250113133405.12167-7-mzamazal@redhat.com>\n\t<20250127071026.GB11289@pendragon.ideasonboard.com>\n\t<85sep4mnoq.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<85sep4mnoq.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]