{"id":22533,"url":"https://patchwork.libcamera.org/api/patches/22533/?format=json","web_url":"https://patchwork.libcamera.org/patch/22533/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250113133405.12167-6-mzamazal@redhat.com>","date":"2025-01-13T13:34:04","name":"[v3,5/6] ipa: simple: Report contrast in metadata","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f741ff6b7687f576d1dc5d7736d1f2e28837fb95","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22533/mbox/","series":[{"id":4945,"url":"https://patchwork.libcamera.org/api/series/4945/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4945","date":"2025-01-13T13:33:59","name":"ipa: simple: Introduce metadata reporting","version":3,"mbox":"https://patchwork.libcamera.org/series/4945/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22533/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22533/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CC14C32F6\n\tfor ;\n\tMon, 13 Jan 2025 13:34:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 296FA68543;\n\tMon, 13 Jan 2025 14:34:41 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 126BA68543\n\tfor ;\n\tMon, 13 Jan 2025 14:34:34 +0100 (CET)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-225-5HiwXV2MNKyqSkiKHOmqHQ-1;\n\tMon, 13 Jan 2025 08:34:30 -0500","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 685091956053; Mon, 13 Jan 2025 13:34:29 +0000 (UTC)","from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.6])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 66C7F1956056; Mon, 13 Jan 2025 13:34:27 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TZWVgLRV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1736775273;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=uHykbYD7MDtWsxRk5Af6RPo3CkhqH7ljLzX3XYozjNs=;\n\tb=TZWVgLRVsSAvaSoZREt0VJELFxt2p4FYn2QKzWAi+l1C+zS74hQgOvM4ZsUyKvGu5A+5Td\n\tLxr4woa52QNKyoMARmBt/DdcDTrUdnLBcRAwpvqc9EFWIJPPDeYL/NvrtAb80JVyjwrY2E\n\tAdwaM7e/iibfP/fmXj8KitsxT2TkSM4=","X-MC-Unique":"5HiwXV2MNKyqSkiKHOmqHQ-1","X-Mimecast-MFC-AGG-ID":"5HiwXV2MNKyqSkiKHOmqHQ","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, Laurent Pinchart\n\t, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","Subject":"[PATCH v3 5/6] ipa: simple: Report contrast in metadata","Date":"Mon, 13 Jan 2025 14:34:04 +0100","Message-ID":"<20250113133405.12167-6-mzamazal@redhat.com>","In-Reply-To":"<20250113133405.12167-1-mzamazal@redhat.com>","References":"<20250113133405.12167-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"j8bcdCZgXNv9uzmRzHojzmN_tmG0y9_fZQ6_1TQf54s_1736775269","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide the requested contrast value, if any, in the metadata to add to\nthe completed requests.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/lut.cpp | 11 +++++++++++\n src/ipa/simple/algorithms/lut.h | 5 +++++\n 2 files changed, 16 insertions(+)","diff":"diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 0ba2391f..31208bfe 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -116,6 +116,17 @@ void Lut::prepare(IPAContext &context,\n \t}\n }\n \n+void Lut::process(IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t [[maybe_unused]] const SwIspStats *stats,\n+\t\t ControlList &metadata)\n+{\n+\tconst auto contrast = context.activeState.knobs.contrast;\n+\tif (contrast)\n+\t\tmetadata.set(controls::Contrast, contrast.value());\n+}\n+\n REGISTER_IPA_ALGORITHM(Lut, \"Lut\")\n \n } /* namespace ipa::soft::algorithms */\ndiff --git a/src/ipa/simple/algorithms/lut.h b/src/ipa/simple/algorithms/lut.h\nindex 889f864b..ab4e1094 100644\n--- a/src/ipa/simple/algorithms/lut.h\n+++ b/src/ipa/simple/algorithms/lut.h\n@@ -30,6 +30,11 @@ public:\n \t\t const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t DebayerParams *params) override;\n+\tvoid process(IPAContext &context,\n+\t\t const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const SwIspStats *stats,\n+\t\t ControlList &metadata) override;\n \n private:\n \tvoid updateGammaTable(IPAContext &context);\n","prefixes":["v3","5/6"]}