[{"id":33193,"web_url":"https://patchwork.libcamera.org/comment/33193/","msgid":"<20250127070427.GF17899@pendragon.ideasonboard.com>","date":"2025-01-27T07:04:27","subject":"Re: [PATCH v3 3/6] ipa: simple: Report the ColourGains in metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Jan 13, 2025 at 02:34:02PM +0100, Milan Zamazal wrote:\n> From: Kieran Bingham \n> \n> Provide the determined colour gains back into the metadata\n> to add to completed requests.\n> \n> Metadata must be set before computing the new gain values in order to\n> report the metadata used to process the image rather than the metadata\n> determined from the image (and to be used for processing the next\n> image).\n\nThat's not right. Setting the metadata before computing the gains won't\nmagically solve the synchronization problem. The code can be kept as-is\n(ideally with a comment to indicate synchronization needs to be fixed),\nbut the commit message shouldn't be misleading.\n\n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/simple/algorithms/awb.cpp | 11 +++++++++--\n> 1 file changed, 9 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index 195de41d..95ff4434 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -14,6 +14,8 @@\n> \n> #include \"simple/ipa_context.h\"\n> \n> +#include \"control_ids.h\"\n> +\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftAwb)\n> @@ -33,10 +35,16 @@ void Awb::process(IPAContext &context,\n> \t\t [[maybe_unused]] const uint32_t frame,\n> \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n> \t\t const SwIspStats *stats,\n> -\t\t [[maybe_unused]] ControlList &metadata)\n> +\t\t ControlList &metadata)\n> {\n> \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n> \tconst uint8_t blackLevel = context.activeState.blc.level;\n> +\tauto &gains = context.activeState.gains;\n> +\n> +\tconst float maxGain = 1024.0;\n> +\tconst float mdGains[] = { static_cast(gains.red / maxGain),\n> +\t\t\t\t static_cast(gains.blue / maxGain) };\n> +\tmetadata.set(controls::ColourGains, mdGains);\n> \n> \t/*\n> \t * Black level must be subtracted to get the correct AWB ratios, they\n> @@ -54,7 +62,6 @@ void Awb::process(IPAContext &context,\n> \t * Calculate red and blue gains for AWB.\n> \t * Clamp max gain at 4.0, this also avoids 0 division.\n> \t */\n> -\tauto &gains = context.activeState.gains;\n> \tgains.red = sumR <= sumG / 4 ? 4.0 : static_cast(sumG) / sumR;\n> \tgains.blue = sumB <= sumG / 4 ? 4.0 : static_cast(sumG) / sumB;\n> \t/* Green gain is fixed to 1.0 */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1048BDCBF\n\tfor ;\n\tMon, 27 Jan 2025 07:04:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1CDE6855D;\n\tMon, 27 Jan 2025 08:04:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7B0E61875\n\tfor ;\n\tMon, 27 Jan 2025 08:04:38 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A6D1496;\n\tMon, 27 Jan 2025 08:03:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TsTRk5Lw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737961412;\n\tbh=P0pK2S49sr+VhKW0nnPYHS8FhpVLOGpZJxzzUBIt2VA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TsTRk5LwtTHzF0eDyJKylvchcrN2tc7mqTxZPXzcv4bvlQyEQOdARawBNOnj5mc1l\n\tXiEa6eQ3YEuxPVp0kmksdyYn0IWfK1RYNuJwBDF4koR7bBtt8rDiyNvetNCxMI9Kpw\n\t92uLsdsjIOBZN38tlb+gDvf/fASZdR5hr2hSCjZ0=","Date":"Mon, 27 Jan 2025 09:04:27 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","Subject":"Re: [PATCH v3 3/6] ipa: simple: Report the ColourGains in metadata","Message-ID":"<20250127070427.GF17899@pendragon.ideasonboard.com>","References":"<20250113133405.12167-1-mzamazal@redhat.com>\n\t<20250113133405.12167-4-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250113133405.12167-4-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33213,"web_url":"https://patchwork.libcamera.org/comment/33213/","msgid":"<173800280958.1773152.13968025240832613966@ping.linuxembedded.co.uk>","date":"2025-01-27T18:33:29","subject":"Re: [PATCH v3 3/6] ipa: simple: Report the ColourGains in metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-01-27 07:04:27)\n> Hi Milan,\n> \n> Thank you for the patch.\n> \n> On Mon, Jan 13, 2025 at 02:34:02PM +0100, Milan Zamazal wrote:\n> > From: Kieran Bingham \n> > \n> > Provide the determined colour gains back into the metadata\n> > to add to completed requests.\n> > \n> > Metadata must be set before computing the new gain values in order to\n> > report the metadata used to process the image rather than the metadata\n> > determined from the image (and to be used for processing the next\n> > image).\n> \n> That's not right. Setting the metadata before computing the gains won't\n> magically solve the synchronization problem. The code can be kept as-is\n> (ideally with a comment to indicate synchronization needs to be fixed),\n> but the commit message shouldn't be misleading.\n\nI think this patch was written before we had a frame context queue.\n\nNow this patch should be discarded, (or re-written) to store during\nprepare() the gains used for that frame in the frame context, and set\nthe metadata from the values that were used when preparing the frame.\n\n\n--\nKieran\n \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/ipa/simple/algorithms/awb.cpp | 11 +++++++++--\n> > 1 file changed, 9 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> > index 195de41d..95ff4434 100644\n> > --- a/src/ipa/simple/algorithms/awb.cpp\n> > +++ b/src/ipa/simple/algorithms/awb.cpp\n> > @@ -14,6 +14,8 @@\n> > \n> > #include \"simple/ipa_context.h\"\n> > \n> > +#include \"control_ids.h\"\n> > +\n> > namespace libcamera {\n> > \n> > LOG_DEFINE_CATEGORY(IPASoftAwb)\n> > @@ -33,10 +35,16 @@ void Awb::process(IPAContext &context,\n> > [[maybe_unused]] const uint32_t frame,\n> > [[maybe_unused]] IPAFrameContext &frameContext,\n> > const SwIspStats *stats,\n> > - [[maybe_unused]] ControlList &metadata)\n> > + ControlList &metadata)\n> > {\n> > const SwIspStats::Histogram &histogram = stats->yHistogram;\n> > const uint8_t blackLevel = context.activeState.blc.level;\n> > + auto &gains = context.activeState.gains;\n> > +\n> > + const float maxGain = 1024.0;\n> > + const float mdGains[] = { static_cast(gains.red / maxGain),\n> > + static_cast(gains.blue / maxGain) };\n> > + metadata.set(controls::ColourGains, mdGains);\n> > \n> > /*\n> > * Black level must be subtracted to get the correct AWB ratios, they\n> > @@ -54,7 +62,6 @@ void Awb::process(IPAContext &context,\n> > * Calculate red and blue gains for AWB.\n> > * Clamp max gain at 4.0, this also avoids 0 division.\n> > */\n> > - auto &gains = context.activeState.gains;\n> > gains.red = sumR <= sumG / 4 ? 4.0 : static_cast(sumG) / sumR;\n> > gains.blue = sumB <= sumG / 4 ? 4.0 : static_cast(sumG) / sumB;\n> > /* Green gain is fixed to 1.0 */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8F2DBEFBE\n\tfor ;\n\tMon, 27 Jan 2025 18:33:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6B836855D;\n\tMon, 27 Jan 2025 19:33:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 370C568549\n\tfor ;\n\tMon, 27 Jan 2025 19:33:32 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BEC418D;\n\tMon, 27 Jan 2025 19:32:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wjXvji4H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1738002745;\n\tbh=8FYOXzThY/Y9NO53W6MRZaakdFvKq+1AhRmCRIM1/bU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wjXvji4H23XK/Fh0StSWZ9/fCc5ZzS4EOIaxVScn+zWFMyP5v87v5jPXHMnqbca+U\n\trdiNhUkVX7RIPionV+RVYsxWFK3xzyKr5iso329Av/Tb7i3Jc+V410QirwX2SlRzSQ\n\tRyo8Bg+bf1CXoLygXXSQe+e37EOf75D2OWghJgXg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250127070427.GF17899@pendragon.ideasonboard.com>","References":"<20250113133405.12167-1-mzamazal@redhat.com>\n\t<20250113133405.12167-4-mzamazal@redhat.com>\n\t<20250127070427.GF17899@pendragon.ideasonboard.com>","Subject":"Re: [PATCH v3 3/6] ipa: simple: Report the ColourGains in metadata","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","To":"Laurent Pinchart ,\n\tMilan Zamazal ","Date":"Mon, 27 Jan 2025 18:33:29 +0000","Message-ID":"<173800280958.1773152.13968025240832613966@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33235,"web_url":"https://patchwork.libcamera.org/comment/33235/","msgid":"<85frl0h97m.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","date":"2025-01-30T10:44:45","subject":"Re: [PATCH v3 3/6] ipa: simple: Report the ColourGains in metadata","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> Quoting Laurent Pinchart (2025-01-27 07:04:27)\n>> Hi Milan,\n>> \n>\n>> Thank you for the patch.\n>> \n>> On Mon, Jan 13, 2025 at 02:34:02PM +0100, Milan Zamazal wrote:\n>> > From: Kieran Bingham \n>> > \n>> > Provide the determined colour gains back into the metadata\n>> > to add to completed requests.\n>> > \n>> > Metadata must be set before computing the new gain values in order to\n>> > report the metadata used to process the image rather than the metadata\n>> > determined from the image (and to be used for processing the next\n>> > image).\n>> \n>> That's not right. Setting the metadata before computing the gains won't\n>> magically solve the synchronization problem. The code can be kept as-is\n>> (ideally with a comment to indicate synchronization needs to be fixed),\n>> but the commit message shouldn't be misleading.\n>\n> I think this patch was written before we had a frame context queue.\n>\n> Now this patch should be discarded, (or re-written) to store during\n> prepare() the gains used for that frame in the frame context, and set\n> the metadata from the values that were used when preparing the frame.\n\nI'll do this in v4.\n\n> --\n> Kieran\n> \n>> > Signed-off-by: Kieran Bingham \n>> > ---\n>> > src/ipa/simple/algorithms/awb.cpp | 11 +++++++++--\n>> > 1 file changed, 9 insertions(+), 2 deletions(-)\n>> > \n>> > diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n>> > index 195de41d..95ff4434 100644\n>> > --- a/src/ipa/simple/algorithms/awb.cpp\n>> > +++ b/src/ipa/simple/algorithms/awb.cpp\n>> > @@ -14,6 +14,8 @@\n>> > \n>> > #include \"simple/ipa_context.h\"\n>> > \n>> > +#include \"control_ids.h\"\n>> > +\n>> > namespace libcamera {\n>> > \n>> > LOG_DEFINE_CATEGORY(IPASoftAwb)\n>> > @@ -33,10 +35,16 @@ void Awb::process(IPAContext &context,\n>> > [[maybe_unused]] const uint32_t frame,\n>> > [[maybe_unused]] IPAFrameContext &frameContext,\n>> > const SwIspStats *stats,\n>> > - [[maybe_unused]] ControlList &metadata)\n>> > + ControlList &metadata)\n>> > {\n>> > const SwIspStats::Histogram &histogram = stats->yHistogram;\n>> > const uint8_t blackLevel = context.activeState.blc.level;\n>> > + auto &gains = context.activeState.gains;\n>> > +\n>> > + const float maxGain = 1024.0;\n>> > + const float mdGains[] = { static_cast(gains.red / maxGain),\n>> > + static_cast(gains.blue / maxGain) };\n>> > + metadata.set(controls::ColourGains, mdGains);\n>> > \n>> > /*\n>> > * Black level must be subtracted to get the correct AWB ratios, they\n>> > @@ -54,7 +62,6 @@ void Awb::process(IPAContext &context,\n>> > * Calculate red and blue gains for AWB.\n>> > * Clamp max gain at 4.0, this also avoids 0 division.\n>> > */\n>> > - auto &gains = context.activeState.gains;\n>> > gains.red = sumR <= sumG / 4 ? 4.0 : static_cast(sumG) / sumR;\n>> > gains.blue = sumB <= sumG / 4 ? 4.0 : static_cast(sumG) / sumB;\n>> > /* Green gain is fixed to 1.0 */\n>> \n>> -- \n>> Regards,\n>> \n>> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80E37BD808\n\tfor ;\n\tThu, 30 Jan 2025 10:44:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4275468568;\n\tThu, 30 Jan 2025 11:44:53 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08E3168560\n\tfor ;\n\tThu, 30 Jan 2025 11:44:51 +0100 (CET)","from mail-ej1-f72.google.com (mail-ej1-f72.google.com\n\t[209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-511-U5Xv-XuKPAekxVtPrynRAw-1; Thu, 30 Jan 2025 05:44:48 -0500","by mail-ej1-f72.google.com with SMTP id\n\ta640c23a62f3a-aa6b904a886so53946666b.0\n\tfor ;\n\tThu, 30 Jan 2025 02:44:48 -0800 (PST)","from mzamazal-thinkpadp1gen3.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-ab6e47a7be3sm99007766b.20.2025.01.30.02.44.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Jan 2025 02:44:46 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"e2azInD2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738233890;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=KmGxvPJP//PDXqVpDDgoTDueFCwBTE5oBIwao9fnUpY=;\n\tb=e2azInD2s2ZZO0ud8ILvsFtCgCd7k91VSI45ZSXSTvcDUS3cIAu+iD3dJWpuohszbllx4Y\n\tLtL2/Mnn7/FCAZ00h6Jyo4gX7FxNle6s63MjjvybnSyhSNmmHqd2M7ChpeiWZC/yoX86zE\n\tG7IJObqEoULyhu6BKJ56zi4mEMywDzU=","X-MC-Unique":"U5Xv-XuKPAekxVtPrynRAw-1","X-Mimecast-MFC-AGG-ID":"U5Xv-XuKPAekxVtPrynRAw","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1738233888; x=1738838688;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KmGxvPJP//PDXqVpDDgoTDueFCwBTE5oBIwao9fnUpY=;\n\tb=lxEsJ61NoSctRv62geqobaBakm4MkoKU5aOoZmAKpnuDjILSqf45ulPhzmpAWYZ7lg\n\tIDyPswv7VlHLRf9NmGAL4/0KYyxwUshbQ7EjdbqpTVLqhVXtkvsw2f6+66VJLsFLxR2j\n\t7zAFMtVOJT1cMSC4Oe1x9ZvEAbMq4xaJJ6n+Cr6h1kX8crCpkzXYia7vgf/3mWCT/r/S\n\twUQ0IH9bENvvpoE4TYc81Lco82t41M1pP4aL6GfIEejEhsauc43oP9mjQZYOAZyzbc/V\n\tMfuoXi1lI8d81jC9kKJKGS194r7QefmmxPRIOK59Gdy74hNJ50cdl5es5ySR38ULZDNf\n\tOzpQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWp0SGRjNo+J9YWeRduap6gyBC6ISW08fJDkoBMBuRNvADTgQjakado+bj26WL6RK3egF+muGMbo6Nyk0WH81U=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YycSQN2d+IQclvQxzWmImqepBY277DHu9rlm/nT8V/TIluwVe81\n\t+EjsqxHIvRwHXwNNercllyRfzFeyJW1tTuNU8FYeKvlE7zEUJMXaBuK9wKY0ieqmFfMz4tfDytT\n\t/p0M0KSJYicNVkoL6mBBjJ4riUWEI0qN2g7e3vluGWiyKho9p9gSlKwZn6MsWGv32KDan9Io=","X-Gm-Gg":"ASbGnctYala84kw9TfICbiyD30X1Q4L7RBCljq5bPAdFLwZjVjF4yxtwxPZBwFjKR/r\n\tEokxMThOZABBmnpvu/cduVVNF8SHKCF2bGyEsHLej/5DidRtsRs2jw02dLJKftGwno8fez2qJnH\n\tcpBKWbc/gwYg+rmfdSGQMI63HlOWu4VkK7gokvwItWhl7HZpUnjN9cTbQCYfI3ZekkfxjlphgET\n\t5pH2YJBIJbaeUCx1kNdohW2EbnzEhSrN9OfX6hCtVInIA61fOQDuNemAFPJYi2zD40OXQsB4VQ2\n\tuMgKti+/8nolJfslNVK7T/AhunjnwY78e1hMaBIgQ9qf2AA12Tnv25JpzA==","X-Received":["by 2002:a17:907:7d8f:b0:ab6:32d2:16d4 with SMTP id\n\ta640c23a62f3a-ab6cfe17758mr702037266b.56.1738233887710; \n\tThu, 30 Jan 2025 02:44:47 -0800 (PST)","by 2002:a17:907:7d8f:b0:ab6:32d2:16d4 with SMTP id\n\ta640c23a62f3a-ab6cfe17758mr702035866b.56.1738233887315; \n\tThu, 30 Jan 2025 02:44:47 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEk1zdrhB4eG1mM5dOd/GwEPryNFBtiUddYHrKAJ8ehNVg7Fs+mdpupwt5RCTHpaSVadoeYnQ==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","Subject":"Re: [PATCH v3 3/6] ipa: simple: Report the ColourGains in metadata","In-Reply-To":"<173800280958.1773152.13968025240832613966@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Mon, 27 Jan 2025 18:33:29 +0000\")","References":"<20250113133405.12167-1-mzamazal@redhat.com>\n\t<20250113133405.12167-4-mzamazal@redhat.com>\n\t<20250127070427.GF17899@pendragon.ideasonboard.com>\n\t<173800280958.1773152.13968025240832613966@ping.linuxembedded.co.uk>","Date":"Thu, 30 Jan 2025 11:44:45 +0100","Message-ID":"<85frl0h97m.fsf@mzamazal-thinkpadp1gen3.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"zEtxk1GQiASMcFPb_clgq472NGgpzAGcX6tFrFopRfM_1738233888","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]