[{"id":33664,"web_url":"https://patchwork.libcamera.org/comment/33664/","msgid":"<174246982943.2025019.749115952103914847@ping.linuxembedded.co.uk>","date":"2025-03-20T11:23:49","subject":"Re: [PATCH v1 4/4] pipeline: rpi: Add support for Raspberry Pi 5","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-01-13 09:24:46)\n> Add the Raspberry Pi 5 ISP (PiSP) pipeline handler to libcamera. To\n> include this pipeline handler in the build, set the following meson\n> option:\n> \n> meson configure -Dpipelines=rpi/pisp\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> ---\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> include/libcamera/ipa/meson.build | 1 +\n> include/libcamera/meson.build | 1 +\n> meson.build | 1 +\n> meson_options.txt | 1 +\n\nFor core:\n\nReviewed-by: Kieran Bingham \n\n> .../pipeline/rpi/pisp/data/example.yaml | 45 +\n> .../pipeline/rpi/pisp/data/meson.build | 8 +\n> src/libcamera/pipeline/rpi/pisp/meson.build | 12 +\n> src/libcamera/pipeline/rpi/pisp/pisp.cpp | 2372 +++++++++++++++++\n\nFor RPi specifics:\n\nThere are a couple of interesting Todo items in the code base, \n\nFor instance:\n\nLIBCAMERA_RPI_PISP_CONFIG_DUMP mentions it could be a vendor control\nwhen available, and now it is. It should also be documented in\nDocumentation/environment_variables.rst.\n\nI also saw there is dma sync handling that could be managed by\nDmaSyncer() objects now instead of inline coding the ioctls. But that\nlikely wasn't available when this code was originally written.\n\nI'd consider those fine for patches and improvements on top - and I\nthink it's important that we get a baseline in for RPi5 now.\n\nAcked-by: Kieran Bingham ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A6CCC3301\n\tfor ;\n\tThu, 20 Mar 2025 11:23:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D26A617F7;\n\tThu, 20 Mar 2025 12:23:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88136617F5\n\tfor ;\n\tThu, 20 Mar 2025 12:23:52 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD4FF743;\n\tThu, 20 Mar 2025 12:22:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WNd9NCdc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742469729;\n\tbh=7cOnz9I0QVTRt7yNJkEugKgX+wms6vXfqMN9IQIMna4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=WNd9NCdchftNzoZDJsNr01hGtLlSMOEql8gIrN6Z4bpp6MlSV0o89EOnpqjSjnpzw\n\tTjZx8IBB3WdW6rxIllSTWrJ5lmUqRwdO1dIIcg7X7v8qbQw9BVWQkzGCNI67F8I/JL\n\tIRQBgh1L80zY1qUIcBxbOivI5MaE4Cn7mNR3HhXs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250113093532.4054142-5-naush@raspberrypi.com>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<20250113093532.4054142-5-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 4/4] pipeline: rpi: Add support for Raspberry Pi 5","From":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tDavid Plowman ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 20 Mar 2025 11:23:49 +0000","Message-ID":"<174246982943.2025019.749115952103914847@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]