[{"id":33663,"web_url":"https://patchwork.libcamera.org/comment/33663/","msgid":"<174246918363.2025019.9282122400767893839@ping.linuxembedded.co.uk>","date":"2025-03-20T11:13:03","subject":"Re: [PATCH v1 3/4] pipeline: rpi: Add new stream flags for PiSP","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2025-01-13 09:24:45)\n> Add the following new stream flags:\n> \n> Needs16bitEndianSwap - Indicates that a 16-bit endian swap needs to be\n> performed on the framebuffer in software.\n> \n> Needs14bitUnpack - Indicates that a CSI-2 14-bit unpacking (to 16-bits)\n> needs to be performed on the framebuffer in software.\n> \n> These are to workaround hardware restrictions in the CFE hardware that\n> will be supported in a future commit.\n> \n> Signed-off-by: Naushir Patuck \n\n\nAcked-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rpi/common/rpi_stream.h | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n> index a13d5dc0d5e9..0dba12961743 100644\n> --- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n> +++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n> @@ -82,6 +82,16 @@ public:\n> * to be applied after ISP processing.\n> */\n> Needs32bitConv = (1 << 4),\n> + /*\n> + * Indicates that the input stream needs a software 16-bit endian\n> + * conversion to be applied before ISP processing.\n> + */\n> + Needs16bitEndianSwap = (1 << 5),\n> + /*\n> + * Indicates that the input stream needs a software 14-bit to\n> + * 16-bit unpacking.\n> + */\n> + Needs14bitUnpack = (1 << 6),\n> };\n> \n> using StreamFlags = Flags;\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4E90C3304\n\tfor ;\n\tThu, 20 Mar 2025 11:13:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64DAE68950;\n\tThu, 20 Mar 2025 12:13:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18E8F617F5\n\tfor ;\n\tThu, 20 Mar 2025 12:13:06 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A07F1743;\n\tThu, 20 Mar 2025 12:11:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"llZCj4kz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742469082;\n\tbh=kNP6p0Xbv3C06DJffvang+dZ7y+itCFEEWyhwXoAxoA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=llZCj4kzf+wQXG+1LzeBPq4GtwNWmysxP/14uQSj/3oDCOvxJCqYZY56CJaB72c5a\n\tFtBau0nqcp/pwmjwEo5wkbfaom+MtYq9MLP0BBi0Q+QbD1OfBFlBt4tW+ef2QIpXIy\n\tTywnAo3Pmlbq8UrTTtYOHiRzF6EBLi1dGrt/Z4bU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250113093532.4054142-4-naush@raspberrypi.com>","References":"<20250113093532.4054142-1-naush@raspberrypi.com>\n\t<20250113093532.4054142-4-naush@raspberrypi.com>","Subject":"Re: [PATCH v1 3/4] pipeline: rpi: Add new stream flags for PiSP","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 20 Mar 2025 11:13:03 +0000","Message-ID":"<174246918363.2025019.9282122400767893839@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]