[{"id":33041,"web_url":"https://patchwork.libcamera.org/comment/33041/","msgid":"","date":"2025-01-13T11:19:48","subject":"Re: [PATCH v7 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch. \n\nOn Fri, Jan 10, 2025 at 05:57:37PM -0600, Paul Elder wrote:\n> Even though the new AeEnable control internally switches on and off the\n> sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\n> be declared as available. Report this control as available in the\n> rpi IPA.\n> \n> Support for the control does not need to be added as it is handled by\n> the Camera class. It does not need to be handled in metadata either as\n> the new version of AeEnable is not returned in metadata.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> No change in v7\n> \n> New in v6\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index d6721c49c..95aa460ab 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -55,6 +55,8 @@ constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n> \n> /* List of controls handled by the Raspberry Pi IPA */\n> const ControlInfoMap::Map ipaControls{\n> +\t/* \\todo Move this to the Camera class */\n> +\t{ &controls::AeEnable, ControlInfo(false, true) },\n\nI think we could also safely default to true here.\n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \t{ &controls::ExposureTimeMode,\n> \t ControlInfo(static_cast(controls::ExposureTimeModeAuto),\n> \t\t static_cast(controls::ExposureTimeModeManual)) },\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70FF3C32F6\n\tfor ;\n\tMon, 13 Jan 2025 11:19:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E83068509;\n\tMon, 13 Jan 2025 12:19:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3864684D9\n\tfor ;\n\tMon, 13 Jan 2025 12:19:51 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3c15:8eea:8742:2e5a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 755B763F;\n\tMon, 13 Jan 2025 12:18:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AU020ntI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736767135;\n\tbh=aLpz3CcnFsD1rU+oQbAp4PbbaOootHfvb7958HzoYrQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AU020ntIl71PM3VLPolFL0D/VPK4sJTnD+wOxFr8+zqz+nF8ribh4J+RpLpDD5Qdp\n\tTreaLlnWHfKRDqKjy16zkkY+WPSbRcvkuHkL8cXcAPgT2/1zw/agDmUzj0HoQDpXWi\n\tOsGD1RGgwKYz8zWzXf73/g3fQgoVD5ytJIsafM28=","Date":"Mon, 13 Jan 2025 12:19:48 +0100","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com","Subject":"Re: [PATCH v7 12/12] ipa: raspberry: Report new AeEnable control as\n\tavailable","Message-ID":"","References":"<20250110235737.1524733-1-paul.elder@ideasonboard.com>\n\t<20250110235737.1524733-13-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250110235737.1524733-13-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]