[{"id":33039,"web_url":"https://patchwork.libcamera.org/comment/33039/","msgid":"<5kgqekplpnqi7smtoelqdasksidugi5g66rrznzgkwvtcfidk3@c2wpcqj7uucd>","date":"2025-01-13T11:09:08","subject":"Re: [PATCH v7 11/12] ipa: rkisp1: agc: Report new AeEnable control\n\tas available","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Jan 10, 2025 at 05:57:36PM -0600, Paul Elder wrote:\n> Even though the new AeEnable control internally switches on and off the\n> sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\n> be declared as available. Report this control as available in the\n> rkisp1 IPA.\n> \n> Support for the control does not need to be added as it is handled by\n> the Camera class. It does not need to be handled in metadata either as\n> the new version of AeEnable is not returned in metadata.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> No change in v7\n> \n> New in v6\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 78122a1f0..ff9a96a43 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> \t\tControlInfo(static_cast(controls::AnalogueGainModeAuto),\n> \t\t\t static_cast(controls::AnalogueGainModeManual),\n> \t\t\t static_cast(controls::AnalogueGainModeAuto));\n> +\t/* \\todo Move this to the Camera class */\n> +\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true);\n\nNit: This is a nice chance of setting the default to true also. In\ncamshark I display all the controls, so I guess a default value for\ncontrols that don't provide one. I think it would be good to supply a\ndefault to all control info (maybe even enforce it). And in this case\ndefaulting it to true is actually the truth.\n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \tcontext.ctrlMap.merge(controls());\n> \n> \treturn 0;\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01949C326C\n\tfor ;\n\tMon, 13 Jan 2025 11:09:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38128684D9;\n\tMon, 13 Jan 2025 12:09:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3C52684D9\n\tfor ;\n\tMon, 13 Jan 2025 12:09:10 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3c15:8eea:8742:2e5a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C22C63F;\n\tMon, 13 Jan 2025 12:08:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UFbi83u3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736766494;\n\tbh=LsOmyaPiIr3hpHISc4p/a9v14NUWJsXsxRwGCCm9rHc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UFbi83u3K1A82lZvtsoufWu3IoQ1OEtmORr6yxul6YEGmwtTJXIsquSEcNz+w1Sc/\n\toZ3mQa+MOgcdxcg4/EZvTz51XcDX0UqZk/k5HgaxeBhl7efhNw55y2M/dXCFhZLNKk\n\tEM+daQiI+zEPS5J2QEhw6kfHD0HSbPgJgRKwiuqg=","Date":"Mon, 13 Jan 2025 12:09:08 +0100","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com","Subject":"Re: [PATCH v7 11/12] ipa: rkisp1: agc: Report new AeEnable control\n\tas available","Message-ID":"<5kgqekplpnqi7smtoelqdasksidugi5g66rrznzgkwvtcfidk3@c2wpcqj7uucd>","References":"<20250110235737.1524733-1-paul.elder@ideasonboard.com>\n\t<20250110235737.1524733-12-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250110235737.1524733-12-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]