[{"id":3048,"web_url":"https://patchwork.libcamera.org/comment/3048/","msgid":"<20191118111910.GE4724@pendragon.ideasonboard.com>","date":"2019-11-18T11:19:10","subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: buffer: Drop friend\n\tstatment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:22:17AM +0100, Niklas Söderlund wrote:\n> The Buffer class do not need to friend PipelineHandler, drop it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/buffer.h | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index d7784d9d24ab3f41..c349b995e1eb35ee 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -88,7 +88,6 @@ public:\n> \n> private:\n> \tfriend class Camera;\n> -\tfriend class PipelineHandler;\n> \tfriend class Request;\n> \tfriend class Stream;\n> \tfriend class V4L2VideoDevice;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 258E760F1C\n\tfor ;\n\tMon, 18 Nov 2019 12:19:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83196563;\n\tMon, 18 Nov 2019 12:19:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574075954;\n\tbh=J3G6ndTzrqmsiAv3jeSnGNLc6mq65t70zVzPIK7ysbs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=G2ummvwMyk2+vnJfR5fLFarUJy9fZrrKMU4jiA2YRRHL58/FeQiYz4zpERGy5hZ6+\n\t1gJeZ1RPlFvk9HRyuF4tlVi66DezHXoQVQbdzxfo1dUBQFFEowtQwBi9gZaRuVvBe6\n\t8vorE6W4TIRa2B+RsoHFsoll3rpVRLrFAhc4yN9U=","Date":"Mon, 18 Nov 2019 13:19:10 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118111910.GE4724@pendragon.ideasonboard.com>","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>\n\t<20191028022224.795355-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022224.795355-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: buffer: Drop friend\n\tstatment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 11:19:15 -0000"}}]