[{"id":33036,"web_url":"https://patchwork.libcamera.org/comment/33036/","msgid":"","date":"2025-01-13T10:45:17","subject":"Re: [PATCH v7 08/12] controls: Remove AeLocked","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo, hi Paul,\n\nThank you for the patch. \n\nOn Fri, Jan 10, 2025 at 05:57:33PM -0600, Paul Elder wrote:\n> From: Jacopo Mondi \n> \n> Now that the codebase has been ported to use the new AEGC controls\n> remove the definition of AeLocked. AeEnable is not be removed as it will\n> be redefined.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Paul Elder \n> Reviewed-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \n> ---\n> No change in v7\n> \n> Changes in v6:\n> - remove only AeLocked, as AeEnable will be redefined instead of removed\n> - (used to be \"controls: Remove AeEnable and AeLocked\")\n> \n> No change in v5\n> \n> No change in v4\n> \n> No change in v3\n> ---\n> src/libcamera/control_ids_core.yaml | 12 ------------\n> 1 file changed, 12 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 553095481..d88c1852e 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -16,18 +16,6 @@ controls:\n> \n> \\sa ExposureTime AnalogueGain\n> \n> - - AeLocked:\n> - type: bool\n> - direction: out\n> - description: |\n> - Report the lock status of a running AE algorithm.\n> -\n> - If the AE algorithm is locked the value shall be set to true, if it's\n> - converging it shall be set to false. If the AE algorithm is not\n> - running the control shall not be present in the metadata control list.\n> -\n> - \\sa AeEnable\n> -\n> - AeState:\n> type: int32_t\n> direction: out\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4532C32F6\n\tfor ;\n\tMon, 13 Jan 2025 10:45:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CEC868506;\n\tMon, 13 Jan 2025 11:45:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC5BE607D6\n\tfor ;\n\tMon, 13 Jan 2025 11:45:20 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3c15:8eea:8742:2e5a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E044928;\n\tMon, 13 Jan 2025 11:44:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tNEFOMDA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736765064;\n\tbh=4o9B/VkOH7aYi8Aa97dNs/EoVWol5nd6rU/N+BZSa+o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tNEFOMDApgCZc5u9qYTu1gZa8tIvr6G2Vws9bX3ae75S7L27eZWrtBvKcDUldPg+1\n\tkQvAf6emSeVkzz7NgskvlobwQb6kWOqW7i3qZgBgFPOShSzM34OCPtc6J7JF4wOpco\n\tCs7k3fpNg2BLYvmDsuq7jnvXIIIuhdvGKk3BNdjw=","Date":"Mon, 13 Jan 2025 11:45:17 +0100","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, Jacopo Mondi , \n\tlaurent.pinchart@ideasonboard.com","Subject":"Re: [PATCH v7 08/12] controls: Remove AeLocked","Message-ID":"","References":"<20250110235737.1524733-1-paul.elder@ideasonboard.com>\n\t<20250110235737.1524733-9-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250110235737.1524733-9-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]