[{"id":33034,"web_url":"https://patchwork.libcamera.org/comment/33034/","msgid":"","date":"2025-01-13T10:24:59","subject":"Re: [PATCH v7 04/12] test: ipa_data_serialization: Use\n\tDebugMetadataEnable","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch. \n\nOn Fri, Jan 10, 2025 at 05:57:29PM -0600, Paul Elder wrote:\n> From: Jacopo Mondi \n> \n> Replace the deprecated AeEnable control with DebugMetadataEnable\n> in ipa_data_serialization test. We use DebugMetadataEnable instead of\n> one of the controls replacing AeEnable as they are not boolean controls.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Paul Elder \n> Reviewed-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \n> ---\n> No change in v7\n> \n> No change in v6\n> \n> No change in v5\n> \n> Changes in v4:\n> - s/ExposureTimeMode/DebugMetadataEnable/\n> \n> No change in v3\n> ---\n> test/serialization/ipa_data_serializer_test.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\n> index aea63c731..afea93a6c 100644\n> --- a/test/serialization/ipa_data_serializer_test.cpp\n> +++ b/test/serialization/ipa_data_serializer_test.cpp\n> @@ -29,7 +29,7 @@ using namespace std;\n> using namespace libcamera;\n> \n> static const ControlInfoMap Controls = ControlInfoMap({\n> -\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n> +\t\t{ &controls::DebugMetadataEnable, ControlInfo(false, true) },\n> \t\t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t\t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> \t\t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 488CBC326C\n\tfor ;\n\tMon, 13 Jan 2025 10:25:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB386684EA;\n\tMon, 13 Jan 2025 11:25:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E07D3684D9\n\tfor ;\n\tMon, 13 Jan 2025 11:25:02 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3c15:8eea:8742:2e5a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 006567E9;\n\tMon, 13 Jan 2025 11:24:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YxTZBM9J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736763846;\n\tbh=vrSQ1TgBl0zYe07kk7j9gof3/SGzlDZ2JEV8zfJ1rxk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YxTZBM9JMMsuiiC9bfQM+eS1TDnrP0EWhMs5z9Xm5YsNhME215iCFKROSN57j0jGI\n\tZkssTFfZ/oWjsGiFD2aktE0kzIvCxxMGYOgeW/tqikOyedZ0ldPqTyzbWXWYPiTgsr\n\tDK1x4x9IHbTxUR6q4/Odlw0u+oV4uPHtknkFZy98=","Date":"Mon, 13 Jan 2025 11:24:59 +0100","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, Jacopo Mondi , \n\tlaurent.pinchart@ideasonboard.com","Subject":"Re: [PATCH v7 04/12] test: ipa_data_serialization: Use\n\tDebugMetadataEnable","Message-ID":"","References":"<20250110235737.1524733-1-paul.elder@ideasonboard.com>\n\t<20250110235737.1524733-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20250110235737.1524733-5-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]