[{"id":3047,"web_url":"https://patchwork.libcamera.org/comment/3047/","msgid":"<20191118111704.GD4724@pendragon.ideasonboard.com>","date":"2019-11-18T11:17:04","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: buffer: Plane: Drop\n\tfriend statement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:22:16AM +0100, Niklas Söderlund wrote:\n> The Plane class do not need to friend Stream, drop it.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/buffer.h | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index e14c9bd390a13bfc..d7784d9d24ab3f41 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -29,8 +29,6 @@ public:\n> \tunsigned int length() const { return length_; }\n> \n> private:\n> -\tfriend class Stream;\n> -\n> \tint mmap();\n> \tint munmap();\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 822EB60F1C\n\tfor ;\n\tMon, 18 Nov 2019 12:17:09 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA464563;\n\tMon, 18 Nov 2019 12:17:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574075829;\n\tbh=TK/1JVByRKy8QfIObhzB03rIV3Iv2XW9TyLE11aFCbE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KMwGKgfblJmv0e5ZIdVEQXtR09UUyKpjymA5LnbYShvCNp450o39SQoKh5HT6Gp1a\n\tLQdqrU1D9F+tw1KpPWOHTwg3FgvbwN+c+pPNcX/mhMTsRVNTO/qTbqPtecJrnrkYjE\n\tPCd8/UALGezneodeCTaI4VL93RVv6ZSk4i09C4nI=","Date":"Mon, 18 Nov 2019 13:17:04 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118111704.GD4724@pendragon.ideasonboard.com>","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>\n\t<20191028022224.795355-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022224.795355-3-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: buffer: Plane: Drop\n\tfriend statement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 Nov 2019 11:17:09 -0000"}}]