{"id":22508,"url":"https://patchwork.libcamera.org/api/patches/22508/?format=json","web_url":"https://patchwork.libcamera.org/patch/22508/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250110023920.28502-2-laurent.pinchart@ideasonboard.com>","date":"2025-01-10T02:39:20","name":"[2/2] libcamera: pipeline: virtual: Demote config file error message to debug","commit_ref":"6841ea8d3694c76911bb2b346753134ae3a5091b","pull_url":null,"state":"accepted","archived":false,"hash":"944f00259abdd4d941ae868aadb326ff1651a361","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22508/mbox/","series":[{"id":4940,"url":"https://patchwork.libcamera.org/api/series/4940/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4940","date":"2025-01-10T02:39:19","name":"[1/2] libcamera: pipeline_handler: Enable silent configuration file lookup","version":1,"mbox":"https://patchwork.libcamera.org/series/4940/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22508/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22508/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C971C32F5\n\tfor ;\n\tFri, 10 Jan 2025 02:39:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C450684E1;\n\tFri, 10 Jan 2025 03:39:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF1A1684E1\n\tfor ;\n\tFri, 10 Jan 2025 03:39:24 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F10778C;\n\tFri, 10 Jan 2025 03:38:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"COZ7zzdM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736476710;\n\tbh=NgOmw+Q0MvISgl9DgSN25qEcRbaSDn27DbXQW2oWkYc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=COZ7zzdM+M2h0LsX/7mwHFlIDtGQxYO/Z+anuP0SW0zt+bXSKSU577CDbf089Zmt7\n\t1a2VcAdeAngX/1vVlWLwSVtWy867I3TfcCqRDhoo9abciYL/jqyvtu28jDkYMFP0/n\n\tmbLaNbVpAHSoLMRCkYE8iISxOMPviJqwzXuVs668=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tJulien Vuillaumier , \n\tHarvey Yang ","Subject":"[PATCH 2/2] libcamera: pipeline: virtual: Demote config file error\n\tmessage to debug","Date":"Fri, 10 Jan 2025 04:39:20 +0200","Message-ID":"<20250110023920.28502-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20250110023920.28502-1-laurent.pinchart@ideasonboard.com>","References":"<20250110023920.28502-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The virtual pipeline handler prints an error message when its\nconfiguration file can't be opened. Not providing a configuration file\nis the default method to disable virtual cameras, so this error is\nconfusing for users. Replace it with a debug message when the\nconfiguration file is not found, and keep an error message when it\nexists but can't be opened.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/virtual/virtual.cpp | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex e692a5433dde8cd5..469f56556f5eb40d 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -329,10 +329,17 @@ bool PipelineHandlerVirtual::match([[maybe_unused]] DeviceEnumerator *enumerator\n \n \tcreated_ = true;\n \n-\tFile file(configurationFile(\"virtual\", \"virtual.yaml\"));\n-\tbool isOpen = file.open(File::OpenModeFlag::ReadOnly);\n-\tif (!isOpen) {\n-\t\tLOG(Virtual, Error) << \"Failed to open config file: \" << file.fileName();\n+\tstd::string configFile = configurationFile(\"virtual\", \"virtual.yaml\", true);\n+\tif (configFile.empty()) {\n+\t\tLOG(Virtual, Debug)\n+\t\t\t<< \"Configuration file not found, skipping virtual cameras\";\n+\t\treturn false;\n+\t}\n+\n+\tFile file(configFile);\n+\tif (!file.open(File::OpenModeFlag::ReadOnly)) {\n+\t\tLOG(Virtual, Error)\n+\t\t\t<< \"Failed to open config file `\" << file.fileName() << \"`\";\n \t\treturn false;\n \t}\n \n","prefixes":["2/2"]}