[{"id":33019,"web_url":"https://patchwork.libcamera.org/comment/33019/","msgid":"","date":"2025-01-10T14:30:22","subject":"Re: [PATCH 1/2] libcamera: pipeline_handler: Enable silent\n\tconfiguration file lookup","submitter":{"id":190,"url":"https://patchwork.libcamera.org/api/people/190/","name":"Julien Vuillaumier","email":"julien.vuillaumier@nxp.com"},"content":"Hi Laurent,\n\nOn 10/01/2025 03:39, Laurent Pinchart wrote:\n> \n> The PipelineHandler::configurationFile() function prints an error\n> message when no configuration file is found. It can be useful for\n> pipeline handlers to silence the lookup operation and handle errors\n> themselves. Add a silent parameter to the function to enable this.\n> \n> Signed-off-by: Laurent Pinchart \n\nThose patches mute the noisy logs indeed. Thank you for looking at it.\nIf tag is appropriate (otherwise please ignore), for the series:\n\nTested-by: Julien Vuillaumier \n\nRegards,\nJulien\n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 3 ++-\n> src/libcamera/pipeline_handler.cpp | 12 ++++++++----\n> 2 files changed, 10 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index fb28a18d0f4668ab..972a2fa65310e1d9 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -63,7 +63,8 @@ public:\n> void cancelRequest(Request *request);\n> \n> std::string configurationFile(const std::string &subdir,\n> - const std::string &name) const;\n> + const std::string &name,\n> + bool silent = false) const;\n> \n> const char *name() const { return name_; }\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index caa5c20e74836956..d84dff3c9f198756 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -581,6 +581,7 @@ void PipelineHandler::cancelRequest(Request *request)\n> * \\brief Retrieve the absolute path to a platform configuration file\n> * \\param[in] subdir The pipeline handler specific subdirectory name\n> * \\param[in] name The configuration file name\n> + * \\param[in] silent Disable error messages\n> *\n> * This function locates a named platform configuration file and returns\n> * its absolute path to the pipeline handler. It searches the following\n> @@ -596,7 +597,8 @@ void PipelineHandler::cancelRequest(Request *request)\n> * string if no configuration file can be found\n> */\n> std::string PipelineHandler::configurationFile(const std::string &subdir,\n> - const std::string &name) const\n> + const std::string &name,\n> + bool silent) const\n> {\n> std::string confPath;\n> struct stat statbuf;\n> @@ -626,9 +628,11 @@ std::string PipelineHandler::configurationFile(const std::string &subdir,\n> if (ret == 0 && (statbuf.st_mode & S_IFMT) == S_IFREG)\n> return confPath;\n> \n> - LOG(Pipeline, Error)\n> - << \"Configuration file '\" << confPath\n> - << \"' not found for pipeline handler '\" << PipelineHandler::name() << \"'\";\n> + if (!silent)\n> + LOG(Pipeline, Error)\n> + << \"Configuration file '\" << confPath\n> + << \"' not found for pipeline handler '\"\n> + << PipelineHandler::name() << \"'\";\n> \n> return std::string();\n> }\n> \n> base-commit: d49a84a4f3aa63efc900564ff32558e4f5d85b04\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 591B5C32EF\n\tfor ;\n\tFri, 10 Jan 2025 14:29:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5ED9161891;\n\tFri, 10 Jan 2025 15:29:23 +0100 (CET)","from EUR05-VI1-obe.outbound.protection.outlook.com\n\t(mail-vi1eur05on20611.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2613::611])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CC96608AA\n\tfor ;\n\tFri, 10 Jan 2025 15:29:21 +0100 (CET)","from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)\n\tby PAXPR04MB8490.eurprd04.prod.outlook.com (2603:10a6:102:1de::18)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.16;\n\tFri, 10 Jan 2025 14:29:14 +0000","from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::eace:e980:28a4:ef8a]) by\n\tAM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::eace:e980:28a4:ef8a%5]) with mapi id 15.20.8335.012;\n\tFri, 10 Jan 2025 14:29:14 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"nH3GA3zU\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=mlZ7E7w6jiq+aMYLIB8n+uROEZpq0iHu0wJhnH4vDgaTdl4LNQDlQogiVmZFylbdfuBvJYBGCjaRH3YMTtKSagIP/6mVfEl5PW1TQ3qAfv8L1CDTtSsRH8KjwkvPw8a5Uoj6J1JHLzCNs4B67W2eO30TsMAjPdkJ34OaVsk0wftFpla3RMVrZhZkHThFynt96+Jrc3eowdjuRqByv+cMWuHgZBno9pfvqnTwkwe4ghQRAkw67/NxY1bNmdya9nsTOwaLX0Vcnd051W1FHS8jASK6zrYkDLU2Vs3f1bOAPIRK+UIi+Y/KZNDb22Qms88eoAsj6G8L9ROvDPN5v33Eew==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=mEA41kDdl88taErc9WZicdkuaI1wp2WqPTFmiNf0XuU=;\n\tb=GNdtc7rLkJTz8u+3Pa/xBdqgFEFKojn1LYi5vNwqOniheEICqGtplarJXftGAE87atNBZO6gRfVIKCJ/lGGHBsgY4UFv/1rcXeHqiZLZ1Bui0sODUwT0Z26I4+NV97eHt9fhB+HZdQj2qmGB4CsDXeZYA1TtAO/uYFkMbeRdsXXXMdG3v7Fo/thQNHx/m4mkW5KaWg5M7bPkjCA6/DHLKFSLajiqJi7R+bqByjaU/7/t3Kfb39lq8hUzdQ9jFLOucQFZYV2JMzEK5iScROGRpE0jApUqTKAlcR6OvWJjVwJa03uDpOJfUdQS3xjYs7VsMYz9FIg2sP5ZgpoQdreJww==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=mEA41kDdl88taErc9WZicdkuaI1wp2WqPTFmiNf0XuU=;\n\tb=nH3GA3zU8CyvGW2UUngdLlEbk1UTcgCD2klV/ZheBwKHM95S31w7Oa7UiR5eogE/sich2tubQ5s+GVvRyfrBoInps9ZA0rmysQcmH+72J7NCPWlYcBijyGfk5dGVwAi1rgG12ZA2FLMVmDbAgihiV0Um6IwwqpXkriDjGpJF0REEcWwaKQDFkwJLKxcCpM/jvjrdMcmxznjqVAIPTeVNNkmpOT5n9MbF6rVmeJJcQ+a8pVE1FQKWXRB+EYcUjdGA6MVSM4U+FNw596YU9xWyeS543v+Oz4lyT3eUS41TWxr3E0otVKwlXMlhPnTMxxhyUgoKVuqvsdFaahE1RDhCkg==","Message-ID":"","Date":"Fri, 10 Jan 2025 15:30:22 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] libcamera: pipeline_handler: Enable silent\n\tconfiguration file lookup","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tHarvey Yang ","References":"<20250110023920.28502-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Julien Vuillaumier ","In-Reply-To":"<20250110023920.28502-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"AM0PR10CA0111.EURPRD10.PROD.OUTLOOK.COM\n\t(2603:10a6:208:e6::28) To AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM9PR04MB8147:EE_|PAXPR04MB8490:EE_","X-MS-Office365-Filtering-Correlation-Id":"ce9c109d-64a7-4700-9c61-08dd31832862","X-LD-Processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0; ARA:13230040|376014|366016|1800799024|7053199007;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?kd+HHCtq25kjs115W+GIY+T7YmNg?=\n\t=?utf-8?q?X4xXo8i78yGkGBPzYNItOvL9ZUw4UbuCoSgIhzUleTpMzjJgQPCeUuzu?=\n\t=?utf-8?q?b9Ns2T+GQH3B20aidV499ZG1TvlcUHmUkOxF9bfMZoy8zlfZt4pDZOZe?=\n\t=?utf-8?q?cOIP/mDpIfKTMRuGAz7ymrap4S8CMhTN2RJ4AwF6ZVJd4ShcxRg1HX6u?=\n\t=?utf-8?q?kksw8Cz2MXoSP+RNmHsUIuiCbRTo/1OnZZEVMQxtwhom/YqXb58d2uV3?=\n\t=?utf-8?q?FfXdfBlIbi4mbTuFTRkW+zJ6ksKAfG+fCQZv4/TYvqzlS4rpWWc7tclz?=\n\t=?utf-8?q?URLXz2rFCVh0qgEK55wgwMG5o7eSTzAcIVzdUaC1eXnbeodrJHaLAIHe?=\n\t=?utf-8?q?HYNvz8XVBe/F//SQcoOs20f7RHKzPNkk/f+pMlbOtadS83DKvalynPGW?=\n\t=?utf-8?q?TlrLQEaWR2USA8FF+vdBY4jNUT34gAia8bNOWHBJE4gjjfxNULOARu2W?=\n\t=?utf-8?q?cCsaRCMhOkXycOfreAsewubLitYk3E/E7RG08Ss1uERTH16EOILAdAw5?=\n\t=?utf-8?q?ruXilHLEc6OPoZYleI2wQFyChxlvQ9YdyJTQFfFeIhzXdGGOQI7VcXEu?=\n\t=?utf-8?q?CwsFmSsdLsBy6Jmy5arDwXnkUPlumrXUe4aiAZC6akniqUpauWVzTNe4?=\n\t=?utf-8?q?Douc72Bf6zzrqFbQCDgJloW7lR9/J32NBTWCwDCiUzhT6faVrYHwlPPC?=\n\t=?utf-8?q?cI/KonhF43BvSpG7JcVa4t0xcRvjjh1B7vZXFydlOhAFKCAatczIPYJU?=\n\t=?utf-8?q?bWLBcErdUqj7h0xYE02izN5aRMIeJrZ3jRkOmKI5N7E1s1IwFVGF1yKS?=\n\t=?utf-8?q?NBjzCuqaNN/LpMpkyit/3uDuy0VD+N5Al87/VXh+SpadZGudtRLq+4yf?=\n\t=?utf-8?q?KiM8VNsHi02mnCuV89MNO4ZvWb1GAVh5g5ugijxLrTy7Wofhck/dZoJI?=\n\t=?utf-8?q?SX2+cs9TXKpk712Cj+MCoOJigY1JqvNDV+aUc+NArI73sSho/ktPFmOU?=\n\t=?utf-8?q?BqqX0D2Ue0DfqLCi5v/1ejwYPe6gD92cX+GliqrzxkcwfP1QOW28qi8J?=\n\t=?utf-8?q?sIH3Tc74bildFoRbKw6DJggVyii2S4XZNuHfs6UBngB2QO8rwamnEgH4?=\n\t=?utf-8?q?+Lvk7sfkCxZY9QeJcFzxYvh3KybpZ3Z23vOl41mzHTNtgIVkw0uwplPJ?=\n\t=?utf-8?q?NWhLdr/iKLcreyD4izkNUsMBVJdBR/kRtfw6wfs/4peFzGWkM3YMRpGS?=\n\t=?utf-8?q?aF98ONA26jr/9YuL9mfhgxdZJ6G1j1UtP/0oamqwBuO4ouMuP+e6KvJg?=\n\t=?utf-8?q?pX46blYNCZSAzGOafM7/sSEoEtcm5GFGU4T5oJU9JkV+dmLo8fSZbVx+?=\n\t=?utf-8?q?GxsC+nWST/W326pSF74YY7eok3oPj1fUUy6subqrsEbgGUjP4wvIw4DJ?=\n\t=?utf-8?q?d2qMZYEYf2tC69b+VBaRPhWXRCi6Rp3H/x66?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(376014)(366016)(1800799024)(7053199007); DIR:OUT;\n\tSFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?hMc7K91BE34AFjgcf2HqnxWxC?=\n\t=?utf-8?q?8nlbLKVm3DkwtyJGHtuy40kHuUlGM8eHsisHPtrT0tFK4H6Hos0ly6qt?=\n\t=?utf-8?q?+N1sNSo4thooFRGaXQOiMvqZkS9JEz56RqFl3BgG/QDvG4x2hyby8ffP?=\n\t=?utf-8?q?m+ZVj63P3q5lm5sbTTHLn8KJ+F/drHa0L3UZlkOkYXGvxfVx4vcSoa8g?=\n\t=?utf-8?q?692nfLIxCaG2NkaBPI2VULdQXcwTChFQTB/G7QpPx5QsWR3XUAT5xFzb?=\n\t=?utf-8?q?9oQqphmPPqdi9/ETkD0uWOdU8JbpsqK5cvqzFC35Ahzkv+WYeEhXilfW?=\n\t=?utf-8?q?T/at7FfDxL2nPXT331xYjzAG9XI2/4ELyBC5a5G0Pq6XKg6fmoAOA7gN?=\n\t=?utf-8?q?yDhG0ZIkVGnP8QYzBeoQ4QkkbsX0YJi/3s/VRxW5Blk3n8fqZTArpNeu?=\n\t=?utf-8?q?9u0gk3WXt1asTbyPrDbflOj2kMODNm3hwG4l+IyeYcLQc4uMYe8ozgxT?=\n\t=?utf-8?q?hNywc5gwC2XEi6kTa/oq9VKKWhyB6PQdNmukMP0tGt/GciYTrq95a4KN?=\n\t=?utf-8?q?3ly9Q3Ydv6+FzDC53Fc1mZ2KMXMm9+S72HFIejFoPuLngA8z6VJVrZKs?=\n\t=?utf-8?q?0vTNxLq8luhPoUjd/utAObPI3A9EsC3SA0hivruLyCnO1QVFyQWwPvj7?=\n\t=?utf-8?q?xawQVf9KLjjW9woUkmgNbMNZO33X/Bdimuadh4gQd+dSyQ0otehs5xha?=\n\t=?utf-8?q?Qd25YmjbwSzxM7zdxgMPqsk4oLrONcFurtk3M9763bImeF+rgDRrjuS6?=\n\t=?utf-8?q?bgdhb58y6ul8RTpjfGbF7Hk8a3tCiZu/A3HYBPGhtxTA43wYyQkY9RpO?=\n\t=?utf-8?q?G0ypDhEubO5omqKu0PEfMtgpYOC4eH2diQOfXaEMPG3Q7Fd2nWofyizk?=\n\t=?utf-8?q?8M5hXIsdwR3dSpE7ZcdpcjwOjZPYr9PAlJ7wMQeBj3dhsyzsNl16UnkZ?=\n\t=?utf-8?q?iNJj5QIs22RgzNIdn6uv0N+mmj4IMZKrDHXrrHyRqJsvLUC2/bdsKUTi?=\n\t=?utf-8?q?W902mfHlBxU6HHdsEg9tBab6EMshxY8iIaXh1Z/pEVwqrFOXP3/3+o7M?=\n\t=?utf-8?q?+z0INN9k+FCRozAHrR0vG16X3x9EhptSDtg5S5BVN1SmJ6ffT0cHasoz?=\n\t=?utf-8?q?ep+S9TPXx/E7FyeghPtotft8ThJJlUlK5UCzDQBxeOfs/Ik8oYhLMFn2?=\n\t=?utf-8?q?Tod+DznjJwvDDygSUqNw40ea0NgwFh1D2hAoR+0EwywwcxjwyrqBvsAf?=\n\t=?utf-8?q?IKr9sE4jaFiMHAh8otWXskye2BFIClnzxGl8NJlRS+PfY1VJVehFCcVp?=\n\t=?utf-8?q?c6QkpyMQ6gUYLEM1Drks99X9bSx8lrL0cp5U8WddPef0LfR96g1iYQCM?=\n\t=?utf-8?q?0XrdmsO0JMAikK4DUvfawz9mYJEBxunxF1Kpp0TkhhIfaz4uF2Ni6epk?=\n\t=?utf-8?q?bSG3/bGjrJ5jn9rOwwdxnaX3vdLCBWXUrjwnTDUZtojDHXy/6qJP7SPq?=\n\t=?utf-8?q?WOs8sWQNp53+puCi3UCiK5pUg2ZBDyVea++JF5toxFSkdBITvB77tpjR?=\n\t=?utf-8?q?WW5nh8G3meP/wXLhQVjTHoPLVn79yuQkMu+qU0zGqw4iQvBngQF3UK/b?=\n\t=?utf-8?q?K0BizV7Oyc1F2m5nqGmvqKHdyQag5j2+8WAG/LgnZ8894TwRoAgBvhRT?=\n\t=?utf-8?q?SixsDVNgvUG7lMONarkKoCtwS3MDQ=3D=3D?=","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"ce9c109d-64a7-4700-9c61-08dd31832862","X-MS-Exchange-CrossTenant-AuthSource":"AM9PR04MB8147.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"10 Jan 2025 14:29:14.5998\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"gTvm9soE2mY4eL+gTcvemmc+CjAGRP4CmhsmhZdI/YHg2Zm4VjLQLCg9xVi5JSH30t5Dr2CIE9Lin/0VxCVZxQRW9JD0prJnwxy7kFDaC2E=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PAXPR04MB8490","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":33021,"web_url":"https://patchwork.libcamera.org/comment/33021/","msgid":"<173652248577.3771432.18387029144009173328@ping.linuxembedded.co.uk>","date":"2025-01-10T15:21:25","subject":"Re: [PATCH 1/2] libcamera: pipeline_handler: Enable silent\n\tconfiguration file lookup","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Julien Vuillaumier (2025-01-10 14:30:22)\n> \n> Hi Laurent,\n> \n> On 10/01/2025 03:39, Laurent Pinchart wrote:\n> > \n> > The PipelineHandler::configurationFile() function prints an error\n> > message when no configuration file is found. It can be useful for\n> > pipeline handlers to silence the lookup operation and handle errors\n> > themselves. Add a silent parameter to the function to enable this.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Those patches mute the noisy logs indeed. Thank you for looking at it.\n> If tag is appropriate (otherwise please ignore), for the series:\n> \n> Tested-by: Julien Vuillaumier \n\nTags are enormously valuable and welcome, thanks!\n\nAlso for both patches from me:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Regards,\n> Julien\n> \n> > ---\n> > include/libcamera/internal/pipeline_handler.h | 3 ++-\n> > src/libcamera/pipeline_handler.cpp | 12 ++++++++----\n> > 2 files changed, 10 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> > index fb28a18d0f4668ab..972a2fa65310e1d9 100644\n> > --- a/include/libcamera/internal/pipeline_handler.h\n> > +++ b/include/libcamera/internal/pipeline_handler.h\n> > @@ -63,7 +63,8 @@ public:\n> > void cancelRequest(Request *request);\n> > \n> > std::string configurationFile(const std::string &subdir,\n> > - const std::string &name) const;\n> > + const std::string &name,\n> > + bool silent = false) const;\n> > \n> > const char *name() const { return name_; }\n> > \n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index caa5c20e74836956..d84dff3c9f198756 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -581,6 +581,7 @@ void PipelineHandler::cancelRequest(Request *request)\n> > * \\brief Retrieve the absolute path to a platform configuration file\n> > * \\param[in] subdir The pipeline handler specific subdirectory name\n> > * \\param[in] name The configuration file name\n> > + * \\param[in] silent Disable error messages\n> > *\n> > * This function locates a named platform configuration file and returns\n> > * its absolute path to the pipeline handler. It searches the following\n> > @@ -596,7 +597,8 @@ void PipelineHandler::cancelRequest(Request *request)\n> > * string if no configuration file can be found\n> > */\n> > std::string PipelineHandler::configurationFile(const std::string &subdir,\n> > - const std::string &name) const\n> > + const std::string &name,\n> > + bool silent) const\n> > {\n> > std::string confPath;\n> > struct stat statbuf;\n> > @@ -626,9 +628,11 @@ std::string PipelineHandler::configurationFile(const std::string &subdir,\n> > if (ret == 0 && (statbuf.st_mode & S_IFMT) == S_IFREG)\n> > return confPath;\n> > \n> > - LOG(Pipeline, Error)\n> > - << \"Configuration file '\" << confPath\n> > - << \"' not found for pipeline handler '\" << PipelineHandler::name() << \"'\";\n> > + if (!silent)\n> > + LOG(Pipeline, Error)\n> > + << \"Configuration file '\" << confPath\n> > + << \"' not found for pipeline handler '\"\n> > + << PipelineHandler::name() << \"'\";\n> > \n> > return std::string();\n> > }\n> > \n> > base-commit: d49a84a4f3aa63efc900564ff32558e4f5d85b04\n> > --\n> > Regards,\n> > \n> > Laurent Pinchart\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26470C32EF\n\tfor ;\n\tFri, 10 Jan 2025 15:21:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5664661891;\n\tFri, 10 Jan 2025 16:21:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2FDF608AA\n\tfor ;\n\tFri, 10 Jan 2025 16:21:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43FCF22E;\n\tFri, 10 Jan 2025 16:20:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"POeRRPyB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736522435;\n\tbh=YkJFLAMECvG7m7O8tq1GDWYidQooTnAuOEhXrRqNmSs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=POeRRPyBV19ypCQwfThUXhsFtR5N3xkj4lXIhSDL7tqKTkw1Up+dGZRfDZ6Ny7Ktl\n\t6vzpie+nOlfZREY7z7ejFF/m1U8EB/TkgxJi+Dzp6QFkdcisQNNTsbZIcoTmXYou5c\n\tRJzYeoo19sQOcK1ewn6Sem33eNbWclyLIJDUJpQw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20250110023920.28502-1-laurent.pinchart@ideasonboard.com>\n\t","Subject":"Re: [PATCH 1/2] libcamera: pipeline_handler: Enable silent\n\tconfiguration file lookup","From":"Kieran Bingham ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tHarvey Yang ","To":"Julien Vuillaumier ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 10 Jan 2025 15:21:25 +0000","Message-ID":"<173652248577.3771432.18387029144009173328@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]