[{"id":33091,"web_url":"https://patchwork.libcamera.org/comment/33091/","msgid":"","date":"2025-01-17T09:26:56","subject":"Re: [PATCH v3 7/7] ipa: rpi: vc4: Update all tuning files for sync\n\talgorithm","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nOn Thu, 9 Jan 2025 at 14:32, David Plowman\n wrote:\n>\n> Default to all the standard parameter values.\n>\n> Signed-off-by: David Plowman \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/rpi/vc4/data/imx219.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx219_noir.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx283.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx290.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx296.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx296_mono.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx378.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx477.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx477_noir.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx477_scientific.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx519.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx708.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx708_noir.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx708_wide.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/imx708_wide_noir.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/ov5647.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/ov5647_noir.json | 7 ++++++-\n> src/ipa/rpi/vc4/data/se327m12.json | 7 ++++++-\n> 18 files changed, 108 insertions(+), 18 deletions(-)\n>\n> diff --git a/src/ipa/rpi/vc4/data/imx219.json b/src/ipa/rpi/vc4/data/imx219.json\n> index a020b12f..21f82dd2 100644\n> --- a/src/ipa/rpi/vc4/data/imx219.json\n> +++ b/src/ipa/rpi/vc4/data/imx219.json\n> @@ -690,6 +690,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> diff --git a/src/ipa/rpi/vc4/data/imx219_noir.json b/src/ipa/rpi/vc4/data/imx219_noir.json\n> index d8bc9639..a51a5387 100644\n> --- a/src/ipa/rpi/vc4/data/imx219_noir.json\n> +++ b/src/ipa/rpi/vc4/data/imx219_noir.json\n> @@ -624,6 +624,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> diff --git a/src/ipa/rpi/vc4/data/imx283.json b/src/ipa/rpi/vc4/data/imx283.json\n> index bfacecc8..d98f3f08 100644\n> --- a/src/ipa/rpi/vc4/data/imx283.json\n> +++ b/src/ipa/rpi/vc4/data/imx283.json\n> @@ -308,6 +308,11 @@\n> },\n> {\n> \"rpi.sharpen\": { }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> diff --git a/src/ipa/rpi/vc4/data/imx290.json b/src/ipa/rpi/vc4/data/imx290.json\n> index 8f41bf51..b2757e29 100644\n> --- a/src/ipa/rpi/vc4/data/imx290.json\n> +++ b/src/ipa/rpi/vc4/data/imx290.json\n> @@ -209,6 +209,11 @@\n> }\n> ]\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\n> index 8f24ce5b..222cb372 100644\n> --- a/src/ipa/rpi/vc4/data/imx296.json\n> +++ b/src/ipa/rpi/vc4/data/imx296.json\n> @@ -438,6 +438,11 @@\n> \"strength\": 1.0,\n> \"limit\": 0.18\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\n> index fe331569..bbf78b3b 100644\n> --- a/src/ipa/rpi/vc4/data/imx296_mono.json\n> +++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n> @@ -235,6 +235,11 @@\n> \"strength\": 1.0,\n> \"limit\": 0.18\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx378.json b/src/ipa/rpi/vc4/data/imx378.json\n> index 363b47e1..e4276732 100644\n> --- a/src/ipa/rpi/vc4/data/imx378.json\n> +++ b/src/ipa/rpi/vc4/data/imx378.json\n> @@ -422,6 +422,11 @@\n> },\n> {\n> \"rpi.sharpen\": { }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx477.json b/src/ipa/rpi/vc4/data/imx477.json\n> index fa25ee86..ece91db9 100644\n> --- a/src/ipa/rpi/vc4/data/imx477.json\n> +++ b/src/ipa/rpi/vc4/data/imx477.json\n> @@ -695,6 +695,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx477_noir.json b/src/ipa/rpi/vc4/data/imx477_noir.json\n> index 472f33fe..13426ee3 100644\n> --- a/src/ipa/rpi/vc4/data/imx477_noir.json\n> +++ b/src/ipa/rpi/vc4/data/imx477_noir.json\n> @@ -651,6 +651,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> diff --git a/src/ipa/rpi/vc4/data/imx477_scientific.json b/src/ipa/rpi/vc4/data/imx477_scientific.json\n> index 9dc32eb1..de028986 100644\n> --- a/src/ipa/rpi/vc4/data/imx477_scientific.json\n> +++ b/src/ipa/rpi/vc4/data/imx477_scientific.json\n> @@ -483,6 +483,11 @@\n> },\n> {\n> \"rpi.sharpen\": { }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx519.json b/src/ipa/rpi/vc4/data/imx519.json\n> index ce194256..d7e33f9f 100644\n> --- a/src/ipa/rpi/vc4/data/imx519.json\n> +++ b/src/ipa/rpi/vc4/data/imx519.json\n> @@ -422,6 +422,11 @@\n> },\n> {\n> \"rpi.sharpen\": { }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\n> index 4de6f079..35c60509 100644\n> --- a/src/ipa/rpi/vc4/data/imx708.json\n> +++ b/src/ipa/rpi/vc4/data/imx708.json\n> @@ -666,6 +666,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx708_noir.json b/src/ipa/rpi/vc4/data/imx708_noir.json\n> index 7b7ee874..495a2a9e 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_noir.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_noir.json\n> @@ -765,6 +765,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\n> index 6f45aafc..077f740e 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_wide.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_wide.json\n> @@ -677,6 +677,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/imx708_wide_noir.json b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> index b9a5227e..3760925d 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n> @@ -668,6 +668,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/ov5647.json b/src/ipa/rpi/vc4/data/ov5647.json\n> index 40c6059c..d8241004 100644\n> --- a/src/ipa/rpi/vc4/data/ov5647.json\n> +++ b/src/ipa/rpi/vc4/data/ov5647.json\n> @@ -691,6 +691,11 @@\n> }\n> }\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> diff --git a/src/ipa/rpi/vc4/data/ov5647_noir.json b/src/ipa/rpi/vc4/data/ov5647_noir.json\n> index 488b7119..accceb8b 100644\n> --- a/src/ipa/rpi/vc4/data/ov5647_noir.json\n> +++ b/src/ipa/rpi/vc4/data/ov5647_noir.json\n> @@ -407,6 +407,11 @@\n> },\n> {\n> \"rpi.sharpen\": { }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> diff --git a/src/ipa/rpi/vc4/data/se327m12.json b/src/ipa/rpi/vc4/data/se327m12.json\n> index 948169db..48512b50 100644\n> --- a/src/ipa/rpi/vc4/data/se327m12.json\n> +++ b/src/ipa/rpi/vc4/data/se327m12.json\n> @@ -427,6 +427,11 @@\n> \"strength\": 0.5,\n> \"limit\": 0.5\n> }\n> - }\n> + },\n> + {\n> + \"rpi.sync\":\n> + {\n> + }\n> + }\n> ]\n> }\n> \\ No newline at end of file\n> --\n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4371EBD7D8\n\tfor ;\n\tFri, 17 Jan 2025 09:27:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBF416854A;\n\tFri, 17 Jan 2025 10:27:33 +0100 (CET)","from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com\n\t[IPv6:2607:f8b0:4864:20::b2f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B4D66851D\n\tfor ;\n\tFri, 17 Jan 2025 10:27:32 +0100 (CET)","by mail-yb1-xb2f.google.com with SMTP id\n\t3f1490d57ef6-e422de4d1c5so297132276.3\n\tfor ;\n\tFri, 17 Jan 2025 01:27:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FH0MQhIV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1737106051; x=1737710851;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yeQlCD3ywvd01QjH36dz5TwDrrQFZEAITf7DyExInDM=;\n\tb=FH0MQhIVRBdG7Oc6ZjTgfgx/Hop67BE5NsHtjvcxKuqihF1RAKTF/UNKu8m1H2sjxd\n\t6CZctBYt4v0GOmOy3l+4JLK8lTWR52xZpS7No7WsAfTcC7+5uc0ykvG5VzFjzy8qkLIU\n\tFHd8SKjGQaJwdqDSvhHY1k6qMwU8RfzHeObFK7FRDCtY2mnkm+QelCDo6FFkpt+b1+dp\n\t3fOwYu+AgFAzZbQOfP7NmpWnSAXcLGRWxKpfHDaHPvJbR5DxQdfsWNEedb/fHHYVCRHm\n\t1ashae/ODj6Bqg9sV2N7omn2SxnndtCDDX+/4joSjz10sk8qVUwFxAJBNyf3Ex9IPKcs\n\tj8IQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1737106051; x=1737710851;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=yeQlCD3ywvd01QjH36dz5TwDrrQFZEAITf7DyExInDM=;\n\tb=KAoY9qtSoytpSAnaIdr4Zf0YeVCNUihZ2F2UpmA/EzfUPTcr4FE6PlhF7S98zXeIev\n\tyTj7+7+YZ9iBRiK9Feq2dMeZP0fYUNeLO9b4IVUQqL+wHuqyYjOm+HSkJUAa9XLfTTC4\n\t7z9HSq/3NtiN8BBzUczZRa/ERiH6h8T6+cXgZ2GUrIZNZHWXsUIgnjYlyGss97vqZpGc\n\tLE93GH9kXMyBJRilQeVFlq1darikQbbUV2kflLGcFGoYFfw1DX5nG9Qjpy7V/NoZwQDh\n\t+/8r9vgHu+N1hHNRxTVZJVWbk+/7eRMdYZSy1BHYhQK6MwEL4xQiQQ6rgkdHe+1aDeve\n\toJ+w==","X-Gm-Message-State":"AOJu0Yzy8jdU6Jyboh2/2smQcsT+cCALlfkpWmlZbz+I3fBMFn2pcscN\n\tBm92VGtDgZn2fi9kQ2bUn/h4vyjruKbG3SandTUBAxVEg4x+nTO2Z8L6JniGZP1e/ItQivbumMy\n\tsMMYVTvnK3Y7HWsATXBVrdRK0YZrpTFaic7AZVXBUCafVbjr4s4U=","X-Gm-Gg":"ASbGnctt1Z7cGrmMDDaDT/QJ73S+a+nvglwXu83gg73qyKZrWq4BFjd2N3N80Rx+e4g\n\tyZ5Mg/Yi9clV3Hj8J3Q5c1ISHkI9WHOtTsS3OijHdk4lPZVk7PmeOGwdqkod+yjLXRkCSpQ==","X-Google-Smtp-Source":"AGHT+IHMYUyglaxXPRohni5iMXlMKmtsM9ORDPufcZhsZssAy2FvLXsW1N9cTcJltI3JY+i88IY+lfQWvaGCXALXo8U=","X-Received":"by 2002:a05:690c:9a8b:b0:6ef:9cbc:44be with SMTP id\n\t00721157ae682-6f6eb93fdbbmr4728157b3.4.1737106050968; Fri, 17 Jan 2025\n\t01:27:30 -0800 (PST)","MIME-Version":"1.0","References":"<20250109143211.11939-1-david.plowman@raspberrypi.com>\n\t<20250109143211.11939-8-david.plowman@raspberrypi.com>","In-Reply-To":"<20250109143211.11939-8-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Fri, 17 Jan 2025 09:26:56 +0000","X-Gm-Features":"AbW1kvY5qomlvGsEzqxzm_eueKimM3eWrnGZQyWSZnp4_AVVZgDWTOnYmwL6IYc","Message-ID":"","Subject":"Re: [PATCH v3 7/7] ipa: rpi: vc4: Update all tuning files for sync\n\talgorithm","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]