[{"id":3046,"web_url":"https://patchwork.libcamera.org/comment/3046/","msgid":"<20191118111437.GC4724@pendragon.ideasonboard.com>","date":"2019-11-18T11:14:37","subject":"Re: [libcamera-devel] [PATCH 01/10] libcamera: buffer: Drop forward\n\tdeclaration of BufferPool","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2019 at 03:22:15AM +0100, Niklas Söderlund wrote:\n> There is no need to forward declare BufferPool, drop it.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  include/libcamera/buffer.h | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index 7b657509ab5f5d41..e14c9bd390a13bfc 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -13,7 +13,6 @@\n>  \n>  namespace libcamera {\n>  \n> -class BufferPool;\n>  class Request;\n>  class Stream;\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5D3760F1C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Nov 2019 12:14:41 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CD5A563;\n\tMon, 18 Nov 2019 12:14:41 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574075681;\n\tbh=aqxcdL9RpLbxiaSyFWVqjHKBSzozW++MRJmn9sPfS5Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b5leHbiYxrqFNBH/mwyGVwvdVk7RKOo6BwifFrTsFU+KmA652+K4cC42GtzuRtgcM\n\tOX9YBdrpoYq/DNYni0KcTKG4+nqEgq3iLTbQoUbC+WXXwJSgg3y+TGFmMsqrCcxd4u\n\t6Dtbn6LXuNQ2qVEncc5AiPU0UXa+1Dal2WSsPp4w=","Date":"Mon, 18 Nov 2019 13:14:37 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191118111437.GC4724@pendragon.ideasonboard.com>","References":"<20191028022224.795355-1-niklas.soderlund@ragnatech.se>\n\t<20191028022224.795355-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191028022224.795355-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 01/10] libcamera: buffer: Drop forward\n\tdeclaration of BufferPool","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 18 Nov 2019 11:14:42 -0000"}}]